Convert python script to ArcMap Script tool

KurtEdwards

I am new to using python scripting and need help making my python script into a script tool.  My script converts area measurments into other area units.  It runs fine in pythonwin and gives me correct output but when I try to attach it to a script tool it just bombs.  I could use all the help that anybody would be willing to give me.  Below is my coding for the conversions.  Thanks.

#create an empty dictionary
areaD = {}
# populate dictionary using indexing and assignment with units and conversion factors relative to sqmeter = 1.0
# to convert x sqmeters to any of the other area units multiply by the factor
# to convert x of any of the other area units to sqmeter divide by the factor
# to convert x of any area unit to any of the other area units go over interim sqmeter
# this minimizes the total number of conversion factors
areaD['sqmeter']      = 1.0
areaD['sqmillimeter'] = 1000000.0
areaD['sqcentimeter'] = 10000.0
areaD['sqkilometer']  = 0.000001
areaD['hectare']      = 0.0001
areaD['sqinch']       = 1550.003
areaD['sqfoot']       = 10.76391
areaD['sqyard']       = 1.19599
areaD['acre']         = 0.0002471054
areaD['sqmile']       = 0.0000003861022


def convertArea(x, unit1, unit2):
    """area conversion with error trapping"""
    if (unit1 in areaD) and (unit2 in areaD):
        factor1 = areaD[unit1]
        factor2 = areaD[unit2]
        return factor2*x/factor1
    else:
        return False
number=1
while x != 0:
    number = raw_input ("Number of Units:")
    unit1 = raw_input ("Unit Converting From:")
    unit2 = raw_input ("Unit Converting To:")
    outcome = convertArea(x, unit1, unit2)
    if outcome is not False:
        print "%f %s = %f %s" % (x, unit1, outcome, unit2)
    else:
        print "There was an error converting %s to %s"  % (unit1,unit2)

SilasToms

I have a related issue. I have written many ArcGIS specific Python scripts that run fine in IDLE/PythonWin, producing the results expected and putting them in the correct place within my file structure.

However, when I try to add the script to a toolbox as a script tool, I don't have the same success. I usually include iteration in the script (invoking the geoprocessor object as a 9.3 object to use the more pythonic for-loop structure, usually, though I explored using the 9.0-9.2 versions and the while-next structure) to perform the same operation on all feature classes within a feature dataset. The script will run 'successfully', according to the output, and yet, nothing happens.

For instance, I might Clip all the feature classes in the dataset. I'll set the workspace to the feature dataset, and have the operation run and place all the output feature classes listed in that dataset (using gp.listfeatureclasses) in another feature dataset. While again, this works fine in IDLE/PythonWin, it will not run if invoked as a script tool. The basic operation, the Clip, will work if performed (as a script tool) on a single feature class (i.e. no iteration).

Here is an example of the code, and again, it works just fine from a stand alone editor:


import sys, string, os, arcgisscripting

gp = arcgisscripting.create(9.3)
gp.overwriteoutput =1
# Load required toolboxes...
gp.AddToolbox("C:/Program Files/ArcGIS/ArcToolbox/Toolboxes/Data Management Tools.tbx")
gp.AddToolbox("C:/Program Files/ArcGIS/ArcToolbox/Toolboxes/Analysis Tools.tbx")

workspace = 'C:/Example.gdb/FeatureDataset/'
clippedPath = 'C:/Example.gdb/OutputDataset/'
clipfeature = 'C:/Example.gdb/Clip_feature_class'
gp.workspace = workspace

featureClasses = gp.listfeatureclasses()

for feature in featureClasses:
        gp.Clip_analysis(feature, clipfeature,clippedPath +feature+'_clip' , "")


Why won't this work as a script tool?