update cursor fails to work

StuartMoore

so this is to check if any annotation overlaps and if it does it rotates one by 90 degrees

 

this just loops through the features and works fine

with arcpy.da.UpdateCursor(fc, ["objectid", "FeatureID","Angle" ,"SHAPE@", "SHAPE@X", "SHAPE@Y","LEGACY_TABLE_NAME"],"objectid in (4007789,4007788,4007787,4007786,4007791,4007790)") as Cur:
    for row in Cur:

        # read in the data

        print row[0]

        SA_Filter = "OBJECTID = {0}".format(row[0])
        try:
            arcpy.management.SelectLayerByAttribute(fc, "NEW_SELECTION", SA_Filter)
            annocount = arcpy.management.GetCount(fc)
            print "tmp count: {0}".format(annocount[0])
            if int(annocount[0]) == 1:
                print "selected one anno"

                arcpy.management.SelectLayerByLocation(fc, "INTERSECT", fc, "", "NEW_SELECTION")
                tmpcount = arcpy.management.GetCount(fc)
                print "tmp count: {0}".format(tmpcount[0])
                if int(tmpcount[0]) >= 2 and int(tmpcount[0]) < 74:
                    print "more than 1"
                    row[2] = float(row[2]) + 90
        except:
            print "Error"

but when i add in a simple update to a text field it fails

with arcpy.da.UpdateCursor(fc, ["objectid", "FeatureID","Angle" ,"SHAPE@", "SHAPE@X", "SHAPE@Y","LEGACY_TABLE_NAME"],"objectid in (4007789,4007788,4007787,4007786,4007791,4007790)") as Cur:
    for row in Cur:

        # read in the data

        print row[0]

        SA_Filter = "OBJECTID = {0}".format(row[0])
        try:
            arcpy.management.SelectLayerByAttribute(fc, "NEW_SELECTION", SA_Filter)
            annocount = arcpy.management.GetCount(fc)
            print "tmp count: {0}".format(annocount[0])
            if int(annocount[0]) == 1:
                print "selected one anno"

                arcpy.management.SelectLayerByLocation(fc, "INTERSECT", fc, "", "NEW_SELECTION")
                tmpcount = arcpy.management.GetCount(fc)
                print "tmp count: {0}".format(tmpcount[0])
                if int(tmpcount[0]) >= 2 and int(tmpcount[0]) < 74:
                    print "more than 1"
                    row[2] = float(row[2]) + 90
                    row[6] = "updated"
                    Cur.updateRow(row)
        except:
            print "Error"

 

Hayden Welch

Nesting Cursors is generally pretty bad, but it can be useful when you want the spatial query to be done in SQL instead of iterating the whole dataset for each feature in python:

 

import arcpy
from arcpy.da import SearchCursor, UpdateCursor, Editor
import os

def rotate_annotations(feature_class: os.PathLike, *, angle_field: str = 'Angle') -> None:
    field_names = ('OID@', 'SHAPE@', angle_field)
    
    with UpdateCursor(feature_class, field_names) as upd_cursor:
        for row in upd_cursor:
            oid, shape, angle = row
            intersecting_features = \
                [
                    feature
                    for feature in SearchCursor(feature_class, field_names, spatial_filter=shape)
                    if feature[0] != oid
                ]
            if intersecting_features:
                angle += 90.0
                upd_cursor.updateRow([oid, shape, angle])
    return

if __name__ == '__main__':
    
    fc = r"path\to\your\feature_class"
    wsp = arcpy.Describe(fc).workspace.catalogPath
    
    with Editor(wsp) as edit:
        try:
            rotate_annotations(fc)
        except Exception as e:
            print(e)
            edit.stopEditing(False)

 

I also threw the operation in an Editor session, which should prevent locks. Also since the rotation code is now a function call, you can call it multiple times on the data if you want to continue rotating annotations that entered a collision after the initial rotation was applied.