Latest Contributions by RyanSutcliffe

I was recently tasked to create a custom basemap layer for our apps that combine some of ESRI's published Vector Basemaps and one of their hillshade basemaps. To accomplish, I did something like this: /** * Returns a custom ESRI Basemap * * @returns {Promise<Object>} ESRI Basemap */ export async function createCustomHillshadeBasemap() { const [Basemap, esriRequest, TileLayer, VectorTileLayer] = await loadModules([ "esri/Basemap", "esri/request", "esri/layers/TileLayer", "esri/layers/VectorTileLayer", ]); let labelStyle; let canvasStyle; // The label style used by the World ESRI Dark Gray Canvas (taken from looking at network request, is this subject to change?): let labelStyleUrl = "https://www.arcgis.com/sharing/rest/content/items/747cb7a5329c478cbe6981076cc879c5/resources/styles/root.json"; labelStyle = await esriRequest(labelStyleUrl, { responseType: "json", }); // The canvas style used by the World ESRI Dark Gray Canvas: let canvasStyleUrl = "https://www.arcgis.com/sharing/rest/content/items/5e9b3685f4c24d8781073dd928ebda50/resources/styles/root.json"; canvasStyle = await esriRequest(canvasStyleUrl, { responseType: "json", }); let baseLayers = [ new VectorTileLayer({ effect: "opacity(80%) brightness(90%)", style: canvasStyle.data, title: "darkCanvas", url: "https://basemaps.arcgis.com/arcgis/rest/services/World_Basemap_v2/VectorTileServer", }), new VectorTileLayer({ style: labelStyle.data, title: "labels", url: "https://basemaps.arcgis.com/arcgis/rest/services/World_Basemap_v2/VectorTileServer", }), ]; baseLayers.unshift( new TileLayer({ title: "hillshade", url: "https://services.arcgisonline.com/arcgis/rest/services/Elevation/World_Hillshade/MapServer", }) ); const basemap = new Basemap({ baseLayers: baseLayers, id: "basemap", title: "basemap", }); return basemap; }   Above works well. But note at line 25 I am using a url to  json that I found ESRI uses for its basemap vector styling rules. The only way I encountered this was by inspecting the network requests in my browser when loading this layer. What I'm wondering, is: will this change? Is that style url something we can count on as a constant or will what that entails change without notice (possible concern)? Or is it possible that the url suddenly changes (note that hex string as part of the url) and we're suddenly referencing a dead endpoint (bigger concern)?  I didn't see any documentation on this so wondering if there are any pitfalls I should be aware of. Does ESRI want us to make our own styles and publish them ourselves (I hope not) and/or is there a more recommended way to create a custom basemap layer in ArcGIS JavaScript API that does not require specifying the style url for the basemap if we just want to combine a couple of ESRI's already published sources? ... View more

Looking at moving from 4.19 to 4.21+ and ran into a problem loading FeatureLayers from our backend ArcGIS Server REST MapServices. At 4.21 loading point layers with over a few million records becomes really slow on initial load. The time from initial request to draw went from a couple seconds or less to 30+ seconds.   When I watch the network traffic I can see that as of 4.21 there is now an initial fetch for the count of records with params like so:        `returnIdsOnly=true&returnCountOnly=true&spatialRel=esriSpatialRelIntersects&where=1%3D1`         This is returning the count of the records in the service layer and it consistently takes our server over 30 seconds to process. The release notes for ArcGIS 4.21 say: At version 4.19, we improved the performance of point FeatureLayers hosted on ArcGIS Online. Version 4.21 brings these changes to ArcGIS Enterprise point services. It looks like this fetch of the count is part of a trick to try to speed up subsequent requests. As an aside we haven't noticed any improvement for any of our datasets/apps on subsequent fetches/draws either.   Some details: Our point layer(s) come from an SDE Database Feature Class layer. The MapService is not cached. ESRI Canada technical support have confirmed they have been able to reproduce this problem with other large datasets of their own.  For our large datasets our use case is that these layers are configured to only draw at a very large scale where a couple thousand records draw at a time. Note that in the use case that ESRI demonstrates in their 4.19 release notes shows all the data drawn at once at full scale. I think their trick might provide advantages in that use case at the detriment of my own. I would like this performance improvement approach to be opt-in in the API (Feature Idea) since ESRI won't consider it a bug. I am also interested if users here know of tricks to speed up getting the recordCount of a large dataset via REST.  For example I can get the recordCount via a direct SQL request to the database table in less than 2 seconds. Why does it take suddenly 30 seconds for ArcGIS Server? Is there some trick or optimization to cache this?    ... View more

I'm looking to implement a custom ArcGIS API for JavaScript baseElevationLayer like the example provided here. I basically take the example ESRI provide that creates a custom class and put it in a function `getClass` that returns the class for me. In vanilla JavaScript all seems to work fine. Here is a CodePen of the code.  When I do the same thing in my React app, which uses esriLoader to load the API modules and react-arcgis to create a SceneView, loading this custom baseElevationLayer fails. Here is that in CodePen also. If you look at the browser's developer console, you see an error about "Cannot read properties of undefined (reading '_elevation')." Can anyone spot what I'm missing?  ... View more