I have two polygonal feature classes of about 15,000 objects. Layer "SNB Building" contains a very accurate outline of buildings while "All Buildings" contains attribute info like building type etc. Basically I want to do this for all records in "All Buildings":
Find intersecting "SNB Building" that intersect or are mostly contained within and copy their geometry to All Buildings. If no intersection found skip to next record.
See the attachment
why not just do a spatial join to get the attributes that you want over to the featureclass with the better geometry?
Spatial Join (Analysis)—ArcGIS Pro | Documentation
All I want is the geometry, not interested in any of the fields.
If you do the spatial join to get the attributes from the simpler building features (all Buildings) onto the complex (SNB) building features, then you can select and delete all the simpler ones that intersect the complex ones, and then append the complex ones with attributes back into the simpler feature class.
I would do this on a copy of your data first to make sure you're getting the results you expect.