topic Re: Locator not solving in right order in Web AppBuilder Custom Widgets Questions

Locator not solving in right order

HamishKingsbury1 — Thu, 09 Jul 2015 00:18:00 GMT

Hey there

I've a list of addresses that I want to solve, ive tried two things:

using locator.addressToLocations - I iterate through the list of addresses. This will solve the results, but sometimes they will not be in the same order as they were in the list - this is an issue.
using locator.addressessToLocations - this will simply not solve. I can't even get it to work in the REST end point.

I'd like to try to fix the issues with my first attempt as i also need to do some other things during the iteration. Below is my code:

    for (i in depotLocs) {
        console.log(i)
        var locator = new esri.tasks.Locator(this.config.geoCoder);
        console.log("A")
        locator.outSpatialReference = sRef;
        console.log("B")
        var optionsFrom = {
            address: { "SingleLine": depotLocs },
            outFields: ["Loc_name"]
        };
       
        locator.addressToLocations(optionsFrom,function(candidate){
            var r = candidate;
            facilitiesGraphicsLayer.add(new Graphic(new Point(r[0].location.x,r[0].location.y,sRef)));
            depotGraphic.push(new Graphic(new Point(r[0].location.x,r[0].location.y,sRef)));
            console.log(i)
            console.log(r[0].location.x)
            console.log(r[0].location.y)
            });

Does anyone have a possible solution to it being solved out of order? it is a bit of pain as it doesn't consistently happen.

Cheers

Hamish

Re: Locator not solving in right order

RobertScheitlin__GISP — Sun, 12 Dec 2021 10:32:00 GMT

Hamish,

I am not real sure about the order issue but here are some other things I would change about your code:

No need to have the locator var inside the loop where it is recreated each time.

Use dojo for handling array looping.

You will need to require 'dojo/_base/array'.

If you have already required esri/tasks/Locator then do not use the Legacy "esri.tasks.Locator" when you you construct the var using new.

var locator = new Locator(this.config.geoCoder);
array.map(depotLocs, function(depotLoc){
  console.log(depotLoc);
  locator.outSpatialReference = sRef;
  var optionsFrom = {
    address: {"SingleLine": depotLoc},
    outFields: ["Loc_name"]
  };
  locator.addressToLocations(optionsFrom, function(candidate){
    var r = candidate;
    facilitiesGraphicsLayer.add(new Graphic(new Point(r[0].location.x, r[0].location.y, sRef)));
    depotGraphic.push(new Graphic(new Point(r[0].location.x, r[0].location.y, sRef)));
    console.log(i);
    console.log(r[0].location.x);
    console.log(r[0].location.y);
  });
}, this);

Let me know if this changes anything for you.

Re: Locator not solving in right order

HamishKingsbury1 — Thu, 09 Jul 2015 05:03:43 GMT

Unfortunately that's still returning them out of order... Its really bizarre.

Re: Locator not solving in right order

RobertScheitlin__GISP — Sun, 12 Dec 2021 10:32:02 GMT

Hamish,

I think you need to use addressesToLocations. Here is a sample of how to use this method (untested):

    var locator = new Locator(this.config.geoCoder);
    locator.outSpatialReference = sRef;
    var dadds = []; 
    array.map(depotLocs, function(depotLoc, index){
      dadds.push({
        "OBJECTID":index,
        "SingleLine":depotLoc
      });
    };
    var options = { 
      addresses: dadds, 
      outFields: ["Loc_name"] 
    };
    locator.addressesToLocations(options, function(result){
        array.map(result.locations, function(candidate){
          facilitiesGraphicsLayer.add(new Graphic(new Point(candidate.location.x, candidate.location.y, sRef))); 
          depotGraphic.push(new Graphic(new Point(candidate.location.x, candidate.location.y, sRef)));
        } 
      }); 
    }, this);

Re: Locator not solving in right order

HamishKingsbury1 — Thu, 09 Jul 2015 21:19:32 GMT

Cheers Robert, I have tried something similar, but I will try your approach.

And well done on winning the competition! With all the help you've given me recently I think you very much deserve it!

Re: Locator not solving in right order

RobertScheitlin__GISP — Thu, 09 Jul 2015 21:21:20 GMT

Thanks Hamish

Re: Locator not solving in right order

HamishKingsbury1 — Thu, 09 Jul 2015 21:38:31 GMT

So using your code I'm getting the same issue when I tried to implement the addressesToLocations.. The console is saying its a 400 error

Re: Locator not solving in right order

RobertScheitlin__GISP — Thu, 09 Jul 2015 22:26:14 GMT

Hamish,

Whose geocoding service are you using, one of your own or esris? If you are using esris then batch geocoding costs credits against your AGOL account.

Re: Locator not solving in right order

HamishKingsbury1 — Thu, 09 Jul 2015 22:42:36 GMT

We're using our own. We've access to a few and I've pointed it to them as well with no luck

Re: Locator not solving in right order

RobertScheitlin__GISP — Thu, 09 Jul 2015 22:53:38 GMT

Hamish,

So it has to be something in the overall code then. Can you share more of the code with me?

Re: Locator not solving in right order

HamishKingsbury1 — Thu, 09 Jul 2015 23:20:33 GMT

I'm fairly confident that the issue is with the code I put in my first post. Here is a screenshot of the console when the tasks are called

The addresses have been called from top to bottom (they basically appear in the console simultaneously) but looking at the input parameters they are in the right order. What i think the problem is is that the solve times are different. The last one is being solved second (looking at the solve/return time - and I have confirmed this later down the track when I needed to use the x/y locations of the addresses in order) and is therefore being added before the second and third address

Re: Locator not solving in right order

RobertScheitlin__GISP — Fri, 10 Jul 2015 00:02:34 GMT

Hamish,

If there is only a couple of addresses that you are locating then you could just set the code up to not process the next until the last on is done. But really the addressesToLocations is the proper way as it will maintain the order.

	for (i in depotLocs) {
	console.log(i)
	var locator = new esri.tasks.Locator(this.config.geoCoder);
	console.log("A")
	locator.outSpatialReference = sRef;
	console.log("B")
	var optionsFrom = {
	address: { "SingleLine": depotLocs },
	outFields: ["Loc_name"]
	};

	locator.addressToLocations(optionsFrom,function(candidate){
	var r = candidate;
	facilitiesGraphicsLayer.add(new Graphic(new Point(r[0].location.x,r[0].location.y,sRef)));
	depotGraphic.push(new Graphic(new Point(r[0].location.x,r[0].location.y,sRef)));
	console.log(i)
	console.log(r[0].location.x)
	console.log(r[0].location.y)
	});