topic Re: Setting Script Tool Parameters - Python in ModelBuilder in Python Questions

Setting Script Tool Parameters - Python in ModelBuilder

NickBauer — Mon, 11 May 2015 07:35:02 GMT

Hi All,

I am wondering if you could help with following. Essentially it relates to the following help article "Setting Script Tool Parameters" ArcGIS Help (10.2, 10.2.1, and 10.2.2)

I have a used ModelBuilder to create a geoprocessing workflow. However for part of this I need to run a script within the model to dissolve some features within a layer (the inbuilt modelbuilder geoprocessing function for this does not give me multi-part polygons, despite this being a supposed option).

Thanks in advance (Using ArcGIS 10.2)

Nick

Essentially the problem I encounter is that when I run the model ArcGIS goes in to 'not responding mode' and does not recover. I suspect there is something wrong with wither my python script or the way I am passing variables between modelbuilder and my python script?

Python Script - Dissolve2

import arcpy

arcpy.env.workspace = "C:/Data/ArcGIS/Default.gdb/Dissolve1"

inLayer = arcpy.GetParameter(0)

outLayer = "C:/Data/ArcGIS/temp/OutDisolve.shp"

arcpy.Dissolve_management(inLayer, outLayer, "Id", "","MULTI_PART", "")

arcpy.SetParameter(1, OutLayer)

I have provided screenshots below

1. A simplified view of the model

2. Parameter Input and Output

Re: Setting Script Tool Parameters - Python in ModelBuilder

FreddieGibson — Mon, 11 May 2015 16:04:07 GMT

Does the Model freeze up with this particular dataset?

Re: Setting Script Tool Parameters - Python in ModelBuilder

DarrenWiens2 — Mon, 11 May 2015 16:45:53 GMT

Check the capitalization of outLayer vs. OutLayer. These are two different things according to Python.

Try:

arcpy.SetParameter(1, outLayer)

Re: Setting Script Tool Parameters - Python in ModelBuilder

curtvprice — Sat, 11 Dec 2021 06:29:02 GMT

> (the inbuilt modelbuilder geoprocessing function for this does not give me multi-part polygons, despite this being a supposed option).

I'm kind of confused by this because the Dissolve tool is the same tool, whether called from ModelBuilder, a Python script, or run from a toolbox in ArcMap interactively.

Another option to the overhead of setting up a script tool is to use the Calculate Value tool in ModelBuilder. Especially handy for situations where the logic of ModelBuilder validations and preconditions get complicated or problematic, but you don't want to bother with a python script tool.

Expression

proc(r"%InLayer%", r"%OutName%")

Code Block

import os
import arcpy
def  proc(lyr, outname):
  output = os.path.join(
    os.path.dirname(arcpy.Describe(lyr).catalogPath),
    outname)
  arcpy.Dissolve_management(lyr, output)
  return output

Data Type:

Feature Class

Re: Setting Script Tool Parameters - Python in ModelBuilder

JohnBrodnicki — Tue, 12 May 2015 13:14:08 GMT

I'm not sure if it will help but you may want to try changing arcpy.GetParameter(0) to arcpy.GetParameterAsText(0). If that doesn't help you may want to use a

try:

code

except arcpy.ExecuteError:

msg = arcpy.GetMessage(0)

arcpy.AddError(msgs)

This might show what's going wrong. If not, you could import os and traceback and write a more detailed "except" to catch other python errors.

Re: Setting Script Tool Parameters - Python in ModelBuilder

curtvprice — Wed, 13 May 2015 01:01:24 GMT

GetParameterAsText and SetParameterAsText should always be used unless you have a good reason to use the GetParameter and SetParameter functions. The GP environment is really setup to move data around as strings (think XML) and generally you'll be happier just going with that flow.

As for trapping exceptions and traceback - always a great idea. There are some nice code samples in the help here:

Error handling with Python—Help | ArcGIS for Desktop

Re: Setting Script Tool Parameters - Python in ModelBuilder

NickBauer — Wed, 13 May 2015 02:23:14 GMT

Thanks Freddie,

No I have tried with several different and simplified datasets and this does not help.

Re: Setting Script Tool Parameters - Python in ModelBuilder

NickBauer1 — Thu, 14 May 2015 23:25:32 GMT

Thanks picking this up Darren,

I have tried this but it does not seem to be the source of my issue. I am still trying to solve this.

Cheers

Nick

Re: Setting Script Tool Parameters - Python in ModelBuilder

NickBauer1 — Thu, 14 May 2015 23:27:01 GMT

Thanks Curtis,

This is definitely helping me eliminate some issues, but I am still trying to get to the bottom of the issue I am having.

Re: Setting Script Tool Parameters - Python in ModelBuilder

NickBauer1 — Thu, 14 May 2015 23:37:19 GMT

Curtis Price wrote:
> (the inbuilt modelbuilder geoprocessing function for this does not give me multi-part polygons, despite this being a supposed option).
I'm kind of confused by this because the Dissolve tool is the same tool, whether called from ModelBuilder, a Python script, or run from a toolbox in ArcMap interactively.

Hi Curtis, yes I agree that the underlying tools are (should) be the same... but when I put the dissolve action into modelbuilder I can't seem to get it make multi-polygons (only single-part), despite this being an obvious option to specify? Is this your experience?

With regards to the "Calculate Value Tool" should the expression have an r before %OutName%? This does seem like a more simple way to go. Do you know of any other examples I can follow?

Thanks

Nick

Re: Setting Script Tool Parameters - Python in ModelBuilder

curtvprice — Fri, 15 May 2015 03:07:59 GMT

No I have not seen this behavior. I'm wondering if there is a logic thing going on here.

The raw strings are only needed when you are passing a model variable that is a path (like a dataset path) into the function used by Calculate Value. The r is needed to ensure the backslashes are always interpreted as path delimeters instead of part of an escape sequence (for example so "path\temp" isn't intepretes as "path" + <tab> + "emp").

Re: Setting Script Tool Parameters - Python in ModelBuilder

SusanJones — Fri, 15 May 2015 03:36:59 GMT

Your workspace is set as a folder inside of a file geodatabase,

Your output layer is specifying an output shapefile.

The data type is incompatible

Try

arcpy.env.workspace = "C:/Data/ArcGIS/Default.gdb/"

Replace

outLayer = "C:/Data/ArcGIS/temp/OutDisolve"

Susan

Re: Setting Script Tool Parameters - Python in ModelBuilder

SusanJones — Fri, 15 May 2015 03:41:29 GMT

Your workspace is set as a folder inside of a file geodatabase,

Your output layer is specifying an output shapefile.

The data type is incompatible

Try

arcpy.env.workspace = "C:/Data/ArcGIS/Default.gdb/"

Replace

outLayer = "OutDisolve"

Susan

Re: Setting Script Tool Parameters - Python in ModelBuilder

WesMiller — Tue, 26 May 2015 01:17:11 GMT

Have you checked the "id" field to ensure there are multiple matching values in that field?

Re: Setting Script Tool Parameters - Python in ModelBuilder

SepheFox — Tue, 26 May 2015 02:14:57 GMT

The first thing I noticed is that your workspace is set to a feature class inside a gdb, as Susan is saying. The workspace should be either a GDB or a folder.

Re: Setting Script Tool Parameters - Python in ModelBuilder

curtvprice — Tue, 26 May 2015 16:06:38 GMT

Just to make sure it's clear for the good of the thread:

A workspace can be a folder, a geodatabase, or a feature dataset (within a geodatabase).

Re: Setting Script Tool Parameters - Python in ModelBuilder

SepheFox — Tue, 26 May 2015 16:18:00 GMT

Actually, I didn't know it could be a dataset, so thanks for that info, but what Nick's trying to use is not clear, since his script tool dialog says the input is a shapefile, so I would think he would want his workspace to be a folder.

Re: Setting Script Tool Parameters - Python in ModelBuilder

curtvprice — Tue, 26 May 2015 16:31:53 GMT

It should work as the current workspace does not come into play when complete paths are provided. In fact I don't see a reason to set the workspace at all in his model. (It is a simplified model he kindly provided, so there is probably more going on we don't know about.

I would avoid setting workspaces to be feature datasets unless there was a reason (ie making the code easier to read when processing data within a feature dataset. I could imagine there may be some bugs he may run into.

Re: Setting Script Tool Parameters - Python in ModelBuilder

DarrenWiens2 — Sat, 11 Dec 2021 06:29:05 GMT

Just a demo of Curtis' point. The workspace environment is only used when it hasn't been overridden by a full path:

>>> arcpy.env.workspace = r'C:\junk\File_GDB.gdb'
>>> out_shape = r'C:\junk\out_shape.shp'
>>> in_shape = r'C:\junk\points.shp'
>>> arcpy.Buffer_analysis(in_shape,out_shape,"50 METERS")
<Result 'C:\\junk\\out_shape.shp'>
>>> arcpy.Buffer_analysis(in_shape,'buffer',"50 METERS")
<Result 'C:\\junk\\FILE_GDB.gdb\\buffer'>