topic Re: Migrate tool/script from ArcMap to ArcGIS Pro in Python Questions

Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Mon, 11 Mar 2024 18:03:17 GMT

I have a tool/script that performed exceptionally well in ArcMap both as a tool/script and as an Add-in. However, I've been attempting to convert it to ArcGIS Pro without success. This tool/script in ArcMap allowed users to calculate the distance between two points with just two clicks, essentially creating a polyline that conveyed the length for further calculations. It also generated a point and updated a field based on this calculation. Although I've attempted to replicate the parameters from ArcMap in Pro, the tool fails to function as expected. It doesn't allow me to click on the map or initiate any actions. How can I go about ensuring this script works in ArcGIS Pro?

The noticeable difference that I see in the parameters section is that script in pro doesn't have Schema.

ArcMap parameters:

Input - Feature Set-

Type - Required

Direction - Input

MultiValue - no

Schema - points to the Point layer

Script,

import arcpy from arcpy import env import pythonaddins import os fc = "Points" arcpy.env.workspace = r"C:\Temp\PointsTest.mdb" pointLayer = arcpy.env.workspace + os.sep + "Points" #target point feature class if arcpy.Exists ("line_test"): arcpy.Delete_management ("line_test") # Start an edit session. Must provide the worksapce. edit = arcpy.da.Editor(arcpy.env.workspace) # Edit session is started without an undo/redo stack for versioned data # (for second argument, use False for unversioned data) edit.startEditing(True) # Start an edit operation edit.startOperation() input = arcpy.GetParameterAsText(0) Range = float(arcpy.GetParameterAsText(1)) # Create empty Point and Array objects point = arcpy.Point() array = arcpy.Array() # A list that will hold each the Polyline object featureList = [] rows = arcpy.SearchCursor(input) for row in rows: geom = row.Shape point.X = geom.centroid.X point.Y = geom.centroid.Y # Add each point to the array array.add(point) # Create the polyline polyline = arcpy.Polyline(array) # Clear the array for future use array.removeAll() featureList.append(polyline) del row, rows # Copy the polyline to file geodatabase to create a Shape_Length field arcpy.CopyFeatures_management(featureList, "line_test") with arcpy.da.SearchCursor("line_test", ["SHAPE@","SHAPE@LENGTH"]) as cursor: for row in cursor: X = row[0].lastPoint.X Y = row[0].lastPoint.Y length = row[1] / 5.28 print("Length:", length) row_value = (length, (X, Y)) cursor = arcpy.da.InsertCursor(pointLayer, ("SiteNum", "SHAPE@XY")) cursor.insertRow(row_value)

Add-in,

import arcpy import pythonaddins class PointTool(object): """Implementation for Point_addin.PointTool (Tool)""" def __init__(self): self.enabled = True self.cursor=3 self.shape = "Line" # Can set to "Line", "Circle" or "Rectangle" for interactive shape drawing and to activate the onLine/Polygon/Circle event sinks. def onLine(self, line_geometry): fc = "Points" arcpy.env.workspace = r"C:\Temp\PointsTest.mdb" pointLayer = arcpy.env.workspace + os.sep + "Points" #target point feature class if arcpy.Exists ("line_test"): arcpy.Delete_management ("line_test") # Start an edit session. Must provide the worksapce. edit = arcpy.da.Editor(arcpy.env.workspace) # Edit session is started without an undo/redo stack for versioned data # (for second argument, use False for unversioned data) edit.startEditing(True) # Start an edit operation edit.startOperation() input = arcpy.GetParameterAsText(0) Range = float(arcpy.GetParameterAsText(1)) # Create empty Point and Array objects point = arcpy.Point() array = arcpy.Array() # A list that will hold each the Polyline object featureList = [] rows = arcpy.SearchCursor(input) for row in rows: geom = row.Shape point.X = geom.centroid.X point.Y = geom.centroid.Y # Add each point to the array array.add(point) # Create the polyline polyline = arcpy.Polyline(array) # Clear the array for future use array.removeAll() featureList.append(polyline) del row, rows # Copy the polyline to file geodatabase to create a Shape_Length field arcpy.CopyFeatures_management(featureList, "line_test") with arcpy.da.SearchCursor("line_test", ["SHAPE@","SHAPE@LENGTH"]) as cursor: for row in cursor: X = row[0].lastPoint.X Y = row[0].lastPoint.Y length = row[1] / 5.28 print("Length:", length) row_value = (length, (X, Y)) cursor = arcpy.da.InsertCursor(pointLayer, ("SiteNum", "SHAPE@XY")) cursor.insertRow(row_value)

Re: Migrate tool/script from ArcMap to ArcGIS Pro

MErikReedAugusta — Mon, 11 Mar 2024 22:12:52 GMT

Full disclosure, I'm not sure any of the below points are the issue, except maybe #2 (Line 49). That said, a few things that jump out at me in no particular order:

Script, Line 32
1. It's generally best practice to use the cursors via a with statement to ensure they get closed properly.
2. The DA cursors are generally more efficient than the standard cursors. Why use a standard one here?
3. Compare this to line 50, where you avoid both of these issues.
Script, Line 49
1. I could be dead-wrong here, but are you sure you want CopyFeatures? Shouldn't it be CreateFeatureclass?
2. Reviewing the specs for CopyFeatures, it looks like it requires a Feature Class as input. I admit I haven't used it much from Python; can it take a list of Polylines?
Script, Line 50
1. Why call both SHAPE@ and SHAPE@LENGTH? You can just call one of them. length is an attribute of that geometry object, just like lastPoint is; see line 5, below:
2. Not important, but Python 3 has added a new way of inserting variables into strings that can be a bit more user-friendly and with better control. Personally, I've found it generally more pleasant to use than the older string.format(), %s, and print command concatenation methods. See line 6, below:

with arcpy.da.SearchCursor('line_test', 'SHAPE@') as cursor: for row in cursor: x = row[0].lastPoint.X y = row[0].lastPoint.Y length = row[0].length / 5.28 print(f'Length: {length}')

Script, Line 59
1. See my comments about Line 32, above.
Add-in, Lines 11-66
1. I'm assuming this is a copy-paste issue, but you seem to have an indentation error.

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Tue, 12 Mar 2024 10:43:43 GMT

Hi @TonyAlmeida,

You could use something like below to create the line feature class:

import os import arcpy # Variables input = arcpy.GetParameterAsText(0) gdb = r"C:\temp\python\test.gdb" wkid = 2272 # Environment Variables arcpy.env.overwriteOutput = True arcpy.env.outputCoordinateSystem = arcpy.SpatialReference(2272) arcpy.env.workspace = gdb array = arcpy.Array() with arcpy.da.SearchCursor(input, ["SHAPE@X", "SHAPE@Y"]) as cursor: for row in cursor: pt = arcpy.Point(row[0], row[1]) array.add(pt) del cursor polyline = arcpy.Polyline(array) arcpy.CopyFeatures_management(polyline, "line_test")

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Tue, 12 Mar 2024 15:36:43 GMT

My bad, I had different variations going on.

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Tue, 12 Mar 2024 15:57:26 GMT

Is there a tool in Pro that I need to use to initiate me to allow me to click on the map? It currently doesn't allow me to do that with the following parameters.

Currently using legacy toolbox script.

I have set up the parameters, like so.

Input:

Label - Input

Name - Input

Data type - Feature Set

Type - Required

Direction - Input

Default - points to .lyr file

Rang:

Label - Input

Name - Input

Data Type - Double

Type - Required

Direction - Input

Current code,

import arcpy import os # Set up your environment fc = "Points" arcpy.env.workspace = r"C:\Temp\PointsTest.gdb" pointLayer = os.path.join(arcpy.env.workspace, "Points") # target point feature class # Check if "line_test" exists and delete it if it does if arcpy.Exists("line_test"): arcpy.Delete_management("line_test") # Start an edit session. Must provide the workspace. edit = arcpy.da.Editor(arcpy.env.workspace) # Edit session is started without an undo/redo stack for versioned data # (for the second argument, use False for unversioned data) edit.startEditing(True) # Variables input = arcpy.GetParameterAsText(0) gdb = r"C:\Temp\PointsTest.gdb" wkid = 2272 # Set environment variables arcpy.env.overwriteOutput = True arcpy.env.outputCoordinateSystem = arcpy.SpatialReference(2272) arcpy.env.workspace = gdb array = arcpy.Array() # Iterate over the features in the input and create a polyline with arcpy.da.SearchCursor(input, ["SHAPE@X", "SHAPE@Y"]) as cursor: for row in cursor: pt = arcpy.Point(row[0], row[1]) array.add(pt) # Create a polyline from the array polyline = arcpy.Polyline(array) # Save the polyline to "line_test" feature class arcpy.CopyFeatures_management(polyline, "line_test") # Retrieve the last point of the polyline and calculate its attributes with arcpy.da.SearchCursor("line_test", "SHAPE@") as cursor: for row in cursor: X = row[0].lastPoint.X Y = row[0].lastPoint.Y length = row[0].length / 5.28 print("Length:", length) # Prepare the row value tuple row_value = (length, (X, Y)) # Use arcpy.da.InsertCursor with a context manager to insert rows into the point layer with arcpy.da.InsertCursor(fc, ["SiteNum", "SHAPE@XY"]) as cursor: cursor.insertRow(row_value)

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Tue, 12 Mar 2024 16:02:43 GMT

Click pencil next to the folder to select the geometry type, and then you should be able to create features

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Tue, 12 Mar 2024 17:28:36 GMT

In the input parameters dependency I had it pointing to a .lyr file and gave me totally something different. After removing that .lyr and starting a edit session I am able to see what you see. After clicking on points, it appears that a point layer is created based on the name of the script, for mine it was PointTestScript input(Points), temp layer?, I get options to use point or point at the end of line, I've tried both. The point doesn't do anything other then just create points in the temp layer? If I use the point at the end of line I get error, line 45, in <module>
X = row[0].lastPoint.X
AttributeError: 'NoneType' object has no attribute 'lastPoint'

Inside the database there is layers being created that correspond with the temp point layers, "Points_1", "Points_2", etc. with field names Name, Text, IntegerValue, DoubleValue and DateTime, but they are empty.

Also, I appreciate your help and patience.

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Wed, 13 Mar 2024 12:45:35 GMT

@TonyAlmeida,

Can you post the updated code your using?

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Wed, 13 Mar 2024 15:27:40 GMT

Of course.

From what I can tell, the "polyline" doesn't get created inside the database, which is why I am getting the error. I just see "points" with the fields I mention before.

import arcpy import os # Set the workspace and target point feature class workspace = r"C:\Temp\PointsTest.gdb" arcpy.env.workspace = workspace fc = "Points" pointLayer = os.path.join(workspace, "CCAP") # Corrected quotation marks here # Variables input = arcpy.GetParameterAsText(0) # Changed variable name to follow Python conventions Range = float(arcpy.GetParameterAsText(1)) wkid = 26770 # Corrected wkid to match the spatial reference # Environment Variables arcpy.env.overwriteOutput = True arcpy.env.outputCoordinateSystem = arcpy.SpatialReference(wkid) # Corrected the spatial reference wkid # Delete line_test if exists if arcpy.Exists("line_test"): arcpy.Delete_management("line_test") # Create an array to hold the point geometries array = arcpy.Array() # Iterate through the input features to create the polyline with arcpy.da.SearchCursor(input, ["SHAPE@X", "SHAPE@Y"]) as cursor: for row in cursor: pt = arcpy.Point(row[0], row[1]) array.add(pt) del cursor # Create the polyline from the array of points polyline = arcpy.Polyline(array) # Save the polyline to a file arcpy.CopyFeatures_management(polyline, "line_test") # Retrieve the last point's coordinates and calculate length with arcpy.da.SearchCursor("line_test", "SHAPE@") as cursor: for row in cursor: last_point = row[0].lastPoint X = last_point.X Y = last_point.Y length = row[0].length / 5.28 print("Length:", length) # Prepare values to insert into the point layer row_value = (length, (X, Y)) # Use arcpy.da.InsertCursor with a context manager to insert rows into the point layer with arcpy.da.InsertCursor(pointLayer, ["SiteNum", "SHAPE@XY"]) as cursor: cursor.insertRow(row_value)

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Wed, 13 Mar 2024 15:36:53 GMT

@TonyAlmeida ,

Make sure your map is in coordinate system (26770), then try the following:

import os import arcpy # Variables input = arcpy.GetParameterAsText(0) gdb = r"C:\temp\PointsTest.gdb" wkid = 26770 # Environment Variables arcpy.env.overwriteOutput = True arcpy.env.outputCoordinateSystem = arcpy.SpatialReference(wkid) arcpy.env.workspace = gdb array = arcpy.Array() with arcpy.da.SearchCursor(input, ["SHAPE@X", "SHAPE@Y"]) as cursor: for row in cursor: pt = arcpy.Point(row[0], row[1]) array.add(pt) del cursor polyline = arcpy.Polyline(array) arcpy.AddMessage("Copying line features") arcpy.CopyFeatures_management(polyline, "line_test") # Retrieve the last point's coordinates and calculate length with arcpy.da.SearchCursor("line_test", "SHAPE@") as cursor: for row in cursor: last_point = row[0].lastPoint X = last_point.X Y = last_point.Y length = row[0].length / 5.28 arcpy.AddMessage(f"Length: {length}") # Prepare values to insert into the point layer row_value = (length, (X, Y)) # Use arcpy.da.InsertCursor with a context manager to insert rows into the point layer arcpy.AddMessage("Inserting values into point layer") with arcpy.da.InsertCursor("CCAP", ["SiteNum", "SHAPE@XY"]) as cursor: cursor.insertRow(row_value) del cursor

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Thu, 14 Mar 2024 15:49:07 GMT

I did have to add, Range = float(arcpy.GetParameterAsText(1)) and included it in, length = row[0].length / 5.28 + Range.

I am not getting a different error, a lock error.

line 48, in <module>
cursor.insertRow(row_value)
RuntimeError: Cannot acquire a lock.

I am using "Point at end of Line" from the drop down and with"Points" in the input drop down window.

I click on the drawing tool to the right, then click points, and click on "selecting point at end of line", it automatically populates with "Scrip Input(points)" in the TOC, I change it to "Points". Is this correct?

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Thu, 14 Mar 2024 19:03:18 GMT

Try the attached tool. First, update the gdb variable by right-clicking on the toolbox > Properties > Execution:

Next, double-click the Script tool. Click the dropdown next the pencil and select Points. Create two points and execute the tool.

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Mon, 18 Mar 2024 14:27:01 GMT

I am still getting the error, Cannot acquire a lock.

I have attached an image.

Would you like me to upload some test data samples?

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Tue, 19 Mar 2024 10:47:57 GMT

Remove the CCAP feature class from your map and try executing the tool again. I think this is placing a lock on the feature class, which is causing this error.

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Thu, 21 Mar 2024 20:39:04 GMT

Removing the layer would not ideal because I need that layer on the map.

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Fri, 22 Mar 2024 10:05:43 GMT

I can't reproduce this. I'm working with Pro 3.2.2 and a File Geodatabase.

(view in My Videos)

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Tue, 26 Mar 2024 14:35:24 GMT

I will try it on a new project and report back.

Again, thank you so much for your help!

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Mon, 01 Apr 2024 21:23:06 GMT

Sorry for the delay. I did test it and it does work but for only the first time. If I need to run the script tool again I get the error - line 35, in <module>
RuntimeError: Cannot acquire a lock.

Are you able to run the script tool multiple times?

Re: Migrate tool/script from ArcMap to ArcGIS Pro

JakeSkinner — Tue, 02 Apr 2024 10:18:34 GMT

@TonyAlmeida, yes, I can execute the tool multiple times. Try adding del cursor below the SearchCursor:

Re: Migrate tool/script from ArcMap to ArcGIS Pro

TonyAlmeida — Thu, 04 Apr 2024 17:46:57 GMT

It's working now, thank you for the help!