topic Re: Setting expression and code block as a script tool parameter when calculating field in Python Questions

Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Thu, 05 Oct 2023 04:45:52 GMT

Hello

I am having trouble is my script tool to set the parameters for the expressions and the code block. Is this something that is possible? If it is, to check Im adding the paramters correctly what do I need to specify? (ie data type, direction) Thank you so much for your help!

import arcpy POAlayer = arcpy.GetParameterAsText(0) POAexpression = arcpy.GetParameterAsText(1) POAcode = arcpy.GetParameterAsText(2) # Calculate field arcpy.management.CalculateField(POAlayer, "POA", POAexpression, "PYTHON3", POAcode)

Re: Setting expression and code block as a script tool parameter when calculating field

BlakeTerhune — Thu, 05 Oct 2023 15:07:12 GMT

I don't see why it wouldn't work. Seems easy enough to test as-is though. Can you clarify what you're having trouble with?

Re: Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Fri, 06 Oct 2023 02:37:10 GMT

Thanks for your help. Im having troubles to try to define the parameters in the tool to make it work right.

I couldnt find the data type option that made it work.

thank you !

Re: Setting expression and code block as a script tool parameter when calculating field

BlakeTerhune — Fri, 06 Oct 2023 14:04:48 GMT

Does it work if you define POAexpression and POAcode as String?

Re: Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Thu, 26 Oct 2023 05:34:13 GMT

Hi ,

I am trying another way to do this using update cursor and field calculator unsuccessfully. I am wanting to change the null values of selected fields in feature class and multiply these fields and subtract them from 1 with the results in a new field. Thank you for you help

Re: Setting expression and code block as a script tool parameter when calculating field

BlakeTerhune — Fri, 20 Oct 2023 15:40:15 GMT

Please fix the indentation in this code.

Re: Setting expression and code block as a script tool parameter when calculating field

AlfredBaldenweck — Fri, 20 Oct 2023 15:44:28 GMT

To your original post, I'd suggest

POAlayer = arcpy.GetParameter(0)

to return a layer object instead of a string, and see if that fixes it.

Re: Setting expression and code block as a script tool parameter when calculating field

Shauna-RaeBrown — Wed, 25 Oct 2023 22:24:53 GMT

#JasmineSpring, one thing you need to do after using any cursor, is you need to del the cursor. Your code should look something like this...

(see line 15).

Re: Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Thu, 26 Oct 2023 05:32:17 GMT

I used the parameter for the input layer as a layer. Thank you !

Re: Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Thu, 26 Oct 2023 05:51:11 GMT

Thank you for your reply

I altered as above and the tool runs but the field doesnt calculate the product_poa field. Maybe the error is in the expression? I would like the field in the list to multiply and then be subtracted from 1.

eg . 1 - (field *field*field)

The fields being taken from the list.

Thank you very much

Re: Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Thu, 26 Oct 2023 05:52:43 GMT

sorry. Is that ok now? thanks for your help

Re: Setting expression and code block as a script tool parameter when calculating field

BlakeTerhune — Thu, 26 Oct 2023 16:06:03 GMT

For the calculate field to multiply all the fields together, try this. I'm assuming you're using ArcGIS Pro. This won't work in ArcMap.

# Use the Field Calculator to calculate the product poa_fields_expr = ",".join([f"!{f.name}!" for f in poa_fields]) expr = f"my_calc_func({poa_fields_expr})" # *args allows any number of arguments to be passed into the function. code = '''def my_calc_func(*args): result = 1 for poa_value in args: result = result * poa_value return 1 - result ''' arcpy.management.CalculateField( in_table=layer, field="Product_poa", expression=expr, expression_type="PYTHON3", code_block=code )

As for the other part of your code sample wehre you are setting the first field to 1, I recommend using calculate field because it will be consistent with using calculate field for multiplying the fields and you can explicitly name the field you're calculating rather than implicitly expecting the first field to be the one you want to calc.

# Set the default value for "the field name here" arcpy.management.CalculateField( in_table=layer, field="the field name here", expression="1" )

Which brings me to a final point: I see you are setting that field to a string "1" instead of an integer 1. If your other poa fields are strings, you will need to convert them to a number in your code. Here is a final code (untested) that also forces the field values to be a number.

import arcpy # Get the selected layer layer = arcpy.GetParameterAsText(0) # Set the default value for "the field name here" arcpy.management.CalculateField( in_table=layer, field="the field name here", expression="1" ) # Format the list of fields for calculate field. poa_fields_expr = [f"!{f.name}!" for f in arcpy.ListFields(layer, wild_card="poa*")] # Build expression and code block to calculate the Product_poa field. expr = f"my_calc_func({poa_fields_expr})" # *args allows any number of arguments to be passed into the function. code = '''def my_calc_func(*args): result = 1 for poa_value in args: result = result * float(poa_value) return 1 - result ''' arcpy.management.CalculateField( in_table=layer, field="Product_poa", expression=expr, expression_type="PYTHON3", code_block=code )

Re: Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Fri, 27 Oct 2023 01:44:46 GMT

Thank you so much ! I am trying to test the calculation with the null values already = 1 as below. I get the error NameError: name 'poa_fields_expr ' is not defined

import arcpy # Get the selected layer layer = arcpy.GetParameterAsText(0) # Create a list of field names starting with "poa" poa_fields = [field.name for field in arcpy.ListFields(layer) if field.name.startswith("poa")] # Use the Field Calculator to calculate the product expression = " * ".join([f"!{field}!" for field in poa_fields]) expr = f"my_calc_func({poa_fields_expr})" # *args allows any number of arguments to be passed into the function. code = '''def my_calc_func(*args): result = 1 for poa_value in args: result = result * poa_value return 1 - result ''' arcpy.management.CalculateField(layer,"Product_poa",expr,"PYTHON3",code)

Re: Setting expression and code block as a script tool parameter when calculating field

BlakeTerhune — Fri, 27 Oct 2023 14:18:02 GMT

@JasmineSpring wrote:
Thank you so much ! I am trying to test the calculation with the null values already = 1 as below. I get the error NameError: name 'poa_fields_expr ' is not defined

The variable on line 11 needs to be renamed.

import arcpy # Get the selected layer layer = arcpy.GetParameterAsText(0) # Create a list of field names starting with "poa" poa_fields = [field.name for field in arcpy.ListFields(layer) if field.name.startswith("poa")] # Use the Field Calculator to calculate the product poa_fields_expr = " * ".join([f"!{field}!" for field in poa_fields]) expr = f"my_calc_func({poa_fields_expr})" # *args allows any number of arguments to be passed into the function. code = '''def my_calc_func(*args): result = 1 for poa_value in args: result = result * poa_value return 1 - result ''' arcpy.management.CalculateField(layer,"Product_poa",expr,"PYTHON3",code)

Re: Setting expression and code block as a script tool parameter when calculating field

JasmineSpring — Tue, 31 Oct 2023 00:58:12 GMT

Thank you Blake ! Very much appreciated. That works perfectly. Below is the final solution

import arcpy # Get the selected layer layer = arcpy.GetParameterAsText(0) # Create a list of field names starting with "poa" poa_fields = [field.name for field in arcpy.ListFields(layer) if field.name.startswith("poa")] for field in poa_fields: with arcpy.da.UpdateCursor(layer, poa_fields) as cursor: for row in cursor: row = tuple([1 if v is None else v for v in row]) cursor.updateRow(row) # Use the Field Calculator to calculate the product poa_fields_expr = " * ".join([f"!{field}!" for field in poa_fields]) expr = f"my_calc_func({poa_fields_expr})" # *args allows any number of arguments to be passed into the function. code = '''def my_calc_func(*args): result = 1 for poa_value in args: result = result * poa_value return 1 - result ''' arcpy.management.CalculateField( in_table=layer, field="Product_poa", expression=expr, expression_type="PYTHON3", code_block=code )