topic Re: Iterate though folder and add lyrx to a map in Python Questions

Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 09:21:59 GMT

I am working with a notebook in ArcGIS Pro and I want to add all .lyrx files within a local folder to a map.

I have set the workspace and created a list with:

arcpy.env.workspace = "path to my data"

list_layers = arcpy.ListFiles("*.lyrx")

which works fine. I have tried to create a for loop to iterate though the list and add the layers to the map in my current project without success.

I realise this is probably easy to do but I can't work it out. Any help would be greatly appreciated!

Re: Iterate though folder and add lyrx to a map

mattkramer — Tue, 02 Aug 2022 11:07:50 GMT

Hey MH84, I can give this a shot. What you are going to need to do is crate a Map object to add the layers to. That can be done through something like this:

aprx = arcpy.mp.ArcGISProject(r"C:\Projects\YosemiteNP\Yosemite.aprx")
m = aprx.listMaps("Yosemite National Park")[0]

once you have a map object ("m" in this case), you should be able to loop through those layers and add them to the map with an addLayer call. That would look something like this:

m.addLayer(inLayer)

I grabbed the first code block from ESRI's docs, the link is below (I also highly recommend checking out other pages on that site, they can be really helpful):

Map—ArcGIS Pro | Documentation

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 12:53:08 GMT

Hey @ mattkramer

So I already have a map object as I've added a single feature from AGOL in the previous part of the program. Adding individual layers/feature etc is ok I just can't get the loop right in this instance. I ran the following:

aprx = arcpy.mp.ArcGISProject("CURRENT")
aprxMap = aprx.listMaps("Map")[0]

arcpy.env.workspace = "Path to my data"

list_layers = arcpy.ListFiles("*.lyrx")

for layer in list_layers:
m.addLayer(list_layers)

and receive the following error

ValueError Traceback (most recent call last)
In [43]:
Line 8: m.addLayer(list_layers)

File C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\utils.py, in fn_:
Line 191: return fn(*args, **kw)

File C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\_mp.py, in addLayer:
Line 1843: return convertArcObjectToPythonObject(self._arc_object.addLayer(*gp_fixargs((add_layer_or_layerfile, add_position), True)))

ValueError: ['OS_AnnoPoint.lyrx', 'OS_Area_Buildings.lyrx', 'OS_Area_FeatureCode.lyrx', 'OS_Area_Landform.lyrx', 'OS_Area_NatEnv.lyrx', 'OS_Bnd.lyrx', 'OS_Line.lyrx', 'OS_Line_Landform.lyrx', 'OS_Pnt.lyrx', 'OS_Sym.lyrx']

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 13:01:58 GMT

This works for one .lyrx

OS_Anno = (r"path to my data")
aprx = arcpy.mp.ArcGISProject("CURRENT")
aprxMap = aprx.listMaps("Map")[0]
aprxMap.addDataFromPath(OS_Anno)

but I want to loop over all layers in the folder and add them

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 13:09:44 GMT

I've also tried this with the associated error

arcpy.env.workspace = "Path to my data"

list_layers = arcpy.ListFiles("*.lyrx")

for layer in list_layers:
m.addLayer(layer)

ValueError Traceback (most recent call last)
In [50]:
Line 8: m.addLayer(layer)

File C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\utils.py, in fn_:
Line 191: return fn(*args, **kw)

ValueError: OS_AnnoPoint.lyrx

Re: Iterate though folder and add lyrx to a map

mattkramer — Tue, 02 Aug 2022 13:13:27 GMT

Make sure that the "m.addLayer(layer)" is indented.

Try updating it to look like this:

for layer in list_layers:
m.addLayer(layer)

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 13:21:46 GMT

It was and it's still throwing a value error.

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 13:25:54 GMT

this works

import glob

directory = "path to my data"

for filename in glob.iglob(f'{directory}/*'):
aprxMap.addDataFromPath(filename)

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 13:33:34 GMT

Try using the full path with the addDataFromPath() method by concatenating the workspace path and layer name:

import os ... for layer in list_layers: m.addDataFromPath(os.path.join(arcpy.env.workspace, layer))

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 13:47:53 GMT

So I tried this and received a RuntimeError. I think you need to iterate over the file itself to add it to a map rather than a list object if I've understood this correctly

Re: Iterate though folder and add lyrx to a map

mattkramer — Tue, 02 Aug 2022 13:51:14 GMT

Correct. In my opinion, the arcpy.listLayers function should probably be used on objects already in an ESRI environment. Since you are adding data from a file path, you should dynamically build the layer source from the data locations (hard coded folder path and loop through layer names).

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:07:28 GMT

arcpy.ListFIles() returns a list of strings, for your case: ['OS_AnnoPoint.lyrx', 'OS_Area_Buildings.lyrx', 'OS_Area_FeatureCode.lyrx', 'OS_Area_Landform.lyrx', 'OS_Area_NatEnv.lyrx', 'OS_Bnd.lyrx', 'OS_Line.lyrx', 'OS_Line_Landform.lyrx', 'OS_Pnt.lyrx', 'OS_Sym.lyrx'] . Concatenating like above should give you the full path for each layer.

Path to my data\OS_AnnoPoint.lyrx

Path to my data\OS_Area_Buildings.lyrx

...

What did the Runtime error say?

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:11:19 GMT

RuntimeError Traceback (most recent call last)
In [82]:
Line 4: m.addDataFromPath(os.path.join(arcpy.env.workspace, layer))

File C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\_mp.py, in addDataFromPath:
Line 1971: return convertArcObjectToPythonObject(self._arc_object.addDataFromPath(*gp_fixargs((data_path,), True)))

RuntimeError:

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:25:40 GMT

It's probably that the m. needs to be aprxMap. ?

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:30:05 GMT

RuntimeError Traceback (most recent call last)
In [86]:
Line 3: aprxMap.addDataFromPath(os.path.join(arcpy.env.workspace, layer))

File C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\_mp.py, in addDataFromPath:
Line 1971: return convertArcObjectToPythonObject(self._arc_object.addDataFromPath(*gp_fixargs((data_path,), True)))

RuntimeError:

Re: Iterate though folder and add lyrx to a map

RhettZufelt — Tue, 02 Aug 2022 14:36:48 GMT

You are iterating through the list of layers, but, then you try to add the entire list instead of the layer(s):

aprx = arcpy.mp.ArcGISProject("CURRENT") aprxMap = aprx.listMaps("Map")[0] arcpy.env.workspace = "Path to my data" list_layers = arcpy.ListFiles("*.lyrx") for layer in list_layers: m.addLayer(layer)

Does it work if you add the individual layers you are iterating through instead of m.addLayer(list_layers)?

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:38:55 GMT

ValueError Traceback (most recent call last)
In [89]:
Line 9: m.addLayer(layer)

File C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\utils.py, in fn_:
Line 191: return fn(*args, **kw)

ValueError: OS_AnnoPoint.lyrx

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:40:48 GMT

odd, because its essentially doing the same thing as your solution using glob. Without seeing the full code and we're now just looking at another way, I'd say keep using the glob version.

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:47:02 GMT

It's not my really solution I found it on GIT hub and modified it slightly but it does work. Correct me if I'm wrong (probably!) but I think the difference is the glob solution iterates over the directory rather than creating a list first then iterating over that?

Re: Iterate though folder and add lyrx to a map

Anonymous User — Tue, 02 Aug 2022 14:57:26 GMT

That is right in the concept. The glob.iglob (iterator glob) creates a generator/ yield object, so instead of populating a complete list first like the arcpy.ListFIles, it lets you iterate over a list without storing it.

Same principle, you are still iterating over a list but a difference is speed.