topic Re: Detecting Corrupt MXDs in Python in Python Questions

Detecting Corrupt MXDs in Python

JanetRogers — Tue, 10 Apr 2012 03:36:00 GMT

I have a python script that loops through all the MXDs in folder and subfolders and writes details of the layers to a text file. The script works quite well, unless an MXD is corrupt at which point it fails (which I can completely understand!). The corrupt MXD caused ArcGIS to crash when I tried to open the document in ArcMap and also when I attempted to preview it in ArcCatalog. I am not sure if it can be done, however can anyone suggest a way to check the MXD before making an attempt to process it by the script.

Re: Detecting Corrupt MXDs in Python

AndrewChapkowski — Sun, 12 Dec 2021 08:18:57 GMT

Have you tried putting a try/except in your code to catch the map documents that are causing you issues?

.... in loop
[INDENT]try:
    mxd = mapping.MapDocument(mxdPath)
    #.... do something
except:
    #write to file which map documents are incorrect[/INDENT]

The try/except pattern should allow you to ignore the errors and output the failing paths to a text file or something else. You can then take that file and run the mxd doctor on them.

Re: Detecting Corrupt MXDs in Python

JanetRogers — Wed, 11 Apr 2012 00:08:40 GMT

Thanks for your suggestion. I am already using Try... Except, however the whole thing crashes before it gets to the exception handler. I don't think it is possible to get around this - just wondered if there was some way of looking at a whole MXD to see if it is corrupt without actually going into it. Sort of like some Excel functions such as ISNA.

Re: Detecting Corrupt MXDs in Python

AndrewChapkowski — Wed, 11 Apr 2012 09:07:36 GMT

Do you know where it's crashing? Are you sure it's related to arcpy/a bad map document?

Can you post a sample of your code and a good and bad map document?

Re: Detecting Corrupt MXDs in Python

JanetRogers — Fri, 27 Apr 2012 02:11:33 GMT

I apologise for taking so long to reply. Been so busy I haven't been able to get back to this script. I deleted the MXD that caused the problem, as it couldn't be opened either so I can't get post it here. When I get a moment free I will see if I can replicate the problem somewhere else.

I'll attach the code so far. (Realised I need to check for broken data sources before I write out the layer details, so coding is still not complete).

Re: Detecting Corrupt MXDs in Python

MichaelVolz — Fri, 27 Apr 2012 17:10:13 GMT

Janet:

I have had to perform this task in older versions of ArcMap as well where python did not have its current capabilities so VBA was used. In each case, whether it be in python or VBA, a corrupt mxd always crashed the script even with error handling such as try...except was used. I have spoken with ESRI Technical representatives and they have confirmed that there is no way around a corrupt mxd in VBA or python scripting except to exclude it all together from your loop.

In my case, I had a script that would take an inventory of all mxds and various connections such as SDE. This was a read-only step where information was saved to an output text file. When the script would crash on a corrupt mxd, it would be noted and added to the code for the other script, that modified paths to data, so that script would just bypass these corrupt files and hopefully never crash.

I hope this information helps you to come up with a solution.

Re: Detecting Corrupt MXDs in Python

JanetRogers — Tue, 01 May 2012 03:49:33 GMT

Thanks mvolz47. I haven't solved this problems (as you said, I don't think this is possible) however it has enabled me to add some extra logging of the MXD names right at the beginning of the loop. If the code fails, I now know which document is causing the problem and can eliminate it from the folder.

Janet

Re: Detecting Corrupt MXDs in Python

David_JAnderson — Sun, 12 Dec 2021 08:19:00 GMT

Janet:

I have had to perform this task in older versions of ArcMap as well where python did not have its current capabilities so VBA was used. In each case, whether it be in python or VBA, a corrupt mxd always crashed the script even with error handling such as try...except was used. I have spoken with ESRI Technical representatives and they have confirmed that there is no way around a corrupt mxd in VBA or python scripting except to exclude it all together from your loop.

In my case, I had a script that would take an inventory of all mxds and various connections such as SDE. This was a read-only step where information was saved to an output text file. When the script would crash on a corrupt mxd, it would be noted and added to the code for the other script, that modified paths to data, so that script would just bypass these corrupt files and hopefully never crash.

I hope this information helps you to come up with a solution.

While doing the same type of mxd listing work I have found that arcpy has no problems in dealing with corrupt mxds when run from an ArcCatalog/ArcMap python command line. However the same command run from a regular python window, IDLE or Pythonwin will cause python to crash.

map_doc = arcpy.mapping.MapDocument('path_to_mxd')
data_frames = arcpy.mapping.ListDataFrames(map_doc)

For a corrupt mxd, this code crashes in stand alone python but runs in the ArcCatalog/Map python window.

Re: Detecting Corrupt MXDs in Python

JanetRogers — Thu, 17 Oct 2013 06:28:48 GMT

Thanks, that is very useful information.

Janet

Re: Detecting Corrupt MXDs in Python

KariBuckvold — Wed, 15 Oct 2014 00:23:00 GMT

Michael,

Can you share how you noted when an mxd was corrupt? I'm also working on a program that walks through mxds in a folder to determine if a particular layer is used or not and writes it to a csv file but the script crashes when it encounters a corrupt mxd. But it crashes before the list is written to the csv file so I never know which one it is.

Any guidance would be great

Re: Detecting Corrupt MXDs in Python

AndrewQuee — Wed, 15 Oct 2014 01:32:51 GMT

We had a similar issue (and needed what sounds like the same script) relating to ArcGIS suddenly not liking shapefiles/rasters on a network drive, with the MXD/layers file crashing ArcMap/ArcCatalog instantly as soon as you tried to open them. This happened across multiple installations and versions, all on the one day, and has actually occurred twice now. It seemed as though ArcMap was corrupting something as it was writing to the document; possibly as a result of some network issue.

Crazily enough, the document was recoverable, by disconnecting the network adaptor or data source drive, then re-saving it - the new document worked absolutely fine, didn't even need to repair data connections. Disabling the data source also allowed the following script to work:

#-------------------------------------------------------------------------------

# Name: ExportMXDLayers.py

# Purpose: List the layers of a specified mxd and attempt to save layer

# files from the layers in that mxd

# Author: Peter von Minden and Julian Ward

# Edited: Andrew Quee

# Created: 22/08/2013

# Edited: 16/12/2013

#-------------------------------------------------------------------------------

import arcpy

errSummary = ""

succSummary = ""

# Must have a valid path to to the mxd in question using double backslashes "\\"

mxd = arcpy.mapping.MapDocument("D:\\Temp\\Export.mxd")

print "\nLAYER_NAME,DATA_SOURCE"

for lyr in arcpy.mapping.ListLayers(mxd):

if lyr.supports("DATASOURCE"):

print lyr.name + "," + lyr.dataSource

try:

# Must have a valid folder to dump the .lyr files using double

# backslashes "\\"

arcpy.SaveToLayerFile_management(lyr, "D:\\Temp\\" + lyr.name + ".lyr", "ABSOLUTE")

succSummary += "Sucessfully Created " + lyr.name + ".lyr\n"

except:

errSummary += "Failed Creating " + lyr.name + ".lyr\n"

print "\n****SUMMARY FOR LAYER FILE CREATION****\n\n****SUCCESFUL****\n\n" + succSummary + "\n****ERRORS****\n\n" + errSummary

wait = raw_input("Press ENTER to continue")

(Sorry if it's a bit rough, it was literally hacked together in a few minutes while users were screaming about 'nothing working' to recreate their broken MXDs)

Coming back to the question, I'm not sure this is possible, David's tip aside. In our experience, as soon as any Esri application touches a corrupted MXD, bang "ArcGIS Desktop has encountered a serious application error and is unable to continue." This also applies to ArcPy, as you've found.

Re: Detecting Corrupt MXDs in Python

MichaelVolz — Wed, 15 Oct 2014 12:34:07 GMT

Kari:

Although this adds another step to your process, I would run through the files that you plan to process without actually resourcing your data and log the files that you have read through. If the script crashes, you know it is the next file in the directory so you can exclude that file by name (or delete it entirely if you find it totally corrupted). I would perform this process by subfolders of your main folder so if the script crashes on a corrupt mxd you don't need to go through as many files in your next run. This was an important step in resourcing my organization's mxds and lyr files which numbered in the 10s of thousands and had 100s of thousands of data connections that needed to be resourced. I hope this information helps you through this tedious but important process to your endusers.

Re: Detecting Corrupt MXDs in Python

AndrewQuee — Mon, 20 Oct 2014 00:22:14 GMT

Good point Michael. Michael Volz

As we've had a couple of issues like this as well, we tend to use this method a lot now for each operation:

with open(path + 'Log_' + Date + '.log', 'a') as output: #open log file in append mode.
        output.write(logentry)
output.close()

Although this slows down the process quite a bit, it's better to know exactly what happened and at what point rather than the script simply crashing and not flushing the output cache to file.

Edit: Added code format style to snippet, for some reason it wouldn't let me choose this when wrote my reply.

Re: Detecting Corrupt MXDs in Python

KariannBuckvold — Mon, 20 Oct 2014 19:25:55 GMT

"append" was the key I was missing! Thanks, it's always the little things!