topic Re: "If" Statement and Loop - ArcPy for ArcGIS Pro in Python Questions

"If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Sun, 12 Dec 2021 00:53:20 GMT

I have this code that performs a Summarize Within on all company stores for every month of the year. However, not all the stores were open in some of the early months so I need to write some code that will identify that the "USER_PatientVisits" is equal to zero and then skip that store and move on to the next. I'm thinking this can be accomplished using an "If" statement and probably a loop; however, I'm not sure what exactly to write and how to bring it all together.

Here is the top portion of my code for January and February; the full code continues on through December:

import arcpy
import sys
import os
import datetime

#now = datetime.datetime.now()

arcpy.env.overwriteOutput = True

#Set the workspace
from arcpy import env
env.workspace = r"C:\arcGIS_Shared\Python\CenterHeatMaps.gdb"

#Declare variables
fc = 'Open_Store_Centers'
fields = ['USER_market_id','USER_Store_ID','USER_Store_Center_Name']
fieldname = 'USER_market_id'

#Define WHERE clause statement
whereclause = """{} = 2000""".format(arcpy.AddFieldDelimiters(fc, fieldname))

#Cursor to create list of centers to loop through
cursor = arcpy.da.SearchCursor(in_table = fc, field_names = fields, where_clause=whereclause, sql_clause=(None, 'ORDER BY USER_market_id, USER_Store_ID'))

#Loop to run SummarizeWithin by center
for row in (cursor):
    #  Set variables for SummarizeWithin
    #  Specify type of summarization, either Blocks or ZIPS, as part of the polys argument
    polys = "Market{0}".format(row[0])+"Blocks"
    points = "Jan_NWPatientVisits{0}".format(row[0])+"{0}".format(row[2])
    outFeatureClass = "Jan_NWSumWithin{0}".format(row[0])+"{0}".format(row[2])
    keepAll = 'ONLY_INTERSECTING'
    sumFields = [['USER_VisitCount', 'Sum']]
    addShapeSum = 'ADD_SHAPE_SUM'

    arcpy.SummarizeWithin_analysis(polys, points, outFeatureClass, keepAll, sumFields, addShapeSum, '')
    
    #Print Results
    print(row[2])
#    print("SumWithin Elapsed Time:" + SumWithinruntime)
#    count = arcpy.GetMessageCount()
#    print (arcpy.GetMessage(count-2))
    print (arcpy.GetMessages())
    
    
    #Declare variables
fc = 'Open_Store_Centers'
fields = ['USER_market_id','USER_Store_ID','USER_Store_Center_Name']
fieldname = 'USER_market_id'

#Define WHERE clause statement
whereclause = """{} = 2000""".format(arcpy.AddFieldDelimiters(fc, fieldname))

#Cursor to create list of centers to loop through
cursor = arcpy.da.SearchCursor(in_table = fc, field_names = fields, where_clause=whereclause, sql_clause=(None, 'ORDER BY USER_market_id, USER_Store_ID'))

#Loop to run SummarizeWithin by center
for row in (cursor):
    #  Set variables for SummarizeWithin
    #  Specify type of summarization, either Blocks or ZIPS, as part of the polys argument
    polys = "Market{0}".format(row[0])+"Blocks"
    points = "Feb_NWPatientVisits{0}".format(row[0])+"{0}".format(row[2])
    outFeatureClass = "Feb_NWSumWithin{0}".format(row[0])+"{0}".format(row[2])
    keepAll = 'ONLY_INTERSECTING'
    sumFields = [['USER_VisitCount', 'Sum']]
    addShapeSum = 'ADD_SHAPE_SUM'

    arcpy.SummarizeWithin_analysis(polys, points, outFeatureClass, keepAll, sumFields, addShapeSum, '')
    
    #Print Results
    print(row[2])
#    print("SumWithin Elapsed Time:" + SumWithinruntime)
#    count = arcpy.GetMessageCount()
#    print (arcpy.GetMessage(count-2))
    print (arcpy.GetMessages())‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Thu, 18 Jan 2018 19:30:02 GMT

Code formatting please it is unreadable in its current state. Try not to edit code once it is pasted in either, that seems to be what happened. Edit in the source, then paste

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Thu, 18 Jan 2018 19:39:21 GMT

Sorry about that. I don't know why it was in that format

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Sun, 12 Dec 2021 00:53:22 GMT

Use the Python option within the syntax highlighter to get line numbers.

After this line

points = "Feb_NWPatientVisits{0}".format(row[0])+"{0}".format(row[2])

if points > 0:
    # then indent all your other lines
    # to continue the processing
    # just guessing since there are no line numbers 
    # and portions of the code seem to be duplicated‍‍‍‍‍

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

XanderBakker — Sun, 12 Dec 2021 00:53:25 GMT

Also when you feel that you are repeating code (like you now have a big block for Jan and another for Feb) it is time to use a loop. For instance have a list of the month prefixes that you want to use like months = ['Jan', 'Feb', ..., 'Dec'] and loop through the months. Something like this (ignoring any other changes that might be required in the code):

import arcpy
import sys
import os
import datetime

#now = datetime.datetime.now()
arcpy.env.overwriteOutput = True

#Set the workspace
from arcpy import env
env.workspace = r"C:\arcGIS_Shared\Python\CenterHeatMaps.gdb"

#Declare variables
fc = 'Open_Store_Centers'
fields = ['USER_market_id','USER_Store_ID','USER_Store_Center_Name']
fieldname = 'USER_market_id'

#Define WHERE clause statement
whereclause = "{0} = 2000".format(arcpy.AddFieldDelimiters(fc, fieldname))
sqlclause = (None, 'ORDER BY USER_market_id, USER_Store_ID')

# loop through months
months = ['Jan', 'Feb', 'Mar'] # add all the months
for month in months:
    #Cursor to create list of centers to loop through
    with arcpy.da.SearchCursor(in_table=fc, field_names=fields,
                               where_clause=whereclause, sql_clause=sqlclause) as cursor:

        #Loop to run SummarizeWithin by center
        for row in cursor:
            #  Set variables for SummarizeWithin
            #  Specify type of summarization, either Blocks or ZIPS, as part of the polys argument
            polys = "Market{0}".format(row[0])+"Blocks"
            points = "{2}_NWPatientVisits{0}{1}".format(row[0], row[2], month)
            outFeatureClass = "{2}_NWSumWithin{0}{1}".format(row[0], row[2], month)
            keepAll = 'ONLY_INTERSECTING'
            sumFields = [['USER_VisitCount', 'Sum']]
            addShapeSum = 'ADD_SHAPE_SUM'

            arcpy.SummarizeWithin_analysis(polys, points, outFeatureClass, keepAll, sumFields, addShapeSum, '')

            #Print Results
            print(row[2])
        #    print("SumWithin Elapsed Time:" + SumWithinruntime)
        #    count = arcpy.GetMessageCount()
        #    print (arcpy.GetMessage(count-2))
            print (arcpy.GetMessages())
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Thu, 18 Jan 2018 20:21:00 GMT

Yes the code is duplicated for each month. Unfortunately, "if points > 0:" gives me the following error.

TypeError: unorderable types: str() > int()‍

I then tried adding " " around the zero to change it from an integer to a string, which allowed it to run, but it did not exclude the stores with zero visits

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Thu, 18 Jan 2018 20:22:20 GMT

if points is a string then you need

if int(points) > 0:

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Thu, 18 Jan 2018 20:26:07 GMT

and did you indent the code as well?

xander_bakker‌ could you try the indentation suggestion on your code to save a copy paste to show what I mean

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Thu, 18 Jan 2018 20:32:19 GMT

Ok I think we are close. I'm now getting the following error.

ValueError: invalid literal for int() with base 10: 'Apr_CTPatientVisits4000Avon'‍

I think this is because technically the attribute table for 'Apr_CTPatientVisits4000Avon' is blank and does not contain zero.

Should it be "Null" instead?

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Sun, 12 Dec 2021 00:53:28 GMT

Here is a little excerpt

polys = "Market{0}".format(row[0])+"Blocks"
    points = "May2_CTPatientVisits{0}".format(row[0])+"{0}".format(row[2])
    if int(points) > 0:
        outFeatureClass = "May_CTSumWithin{0}".format(row[0])+"{0}".format(row[2])
        keepAll = 'ONLY_INTERSECTING'
        sumFields = [['USER_VisitCount', 'Sum']]
        addShapeSum = 'ADD_SHAPE_SUM'‍‍‍‍‍‍‍

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Thu, 18 Jan 2018 20:41:01 GMT

a blank? ooooo, here we go with null, none and nothingness again.

if points is not None:

#then do stuff

if points <> "":

#then do stuff

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

JoeBorgione — Thu, 18 Jan 2018 20:48:51 GMT

Nope.... I'm not gonna take the bait......

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

JoeBorgione — Sun, 12 Dec 2021 00:53:31 GMT

In a project that I've been tasked with, I have moved from several if, elif, else blocks to try:/except: blocks . Not sure if that approach is applicable here, but may be worth a try. Here I examine a size of on a numpy array, and if it has size I work with with it; if it isn't even created (which indicates it didn't need to be) I don't sweat it...

          try:
            name6
            if name6.size <> 0:
                hitList6 = _flatten(name6[0])
                del name6
            else:
                pass
          except NameError:
            pass‍‍‍‍‍‍‍‍‍

Dan Patterson‌, notice the call to _flatten() ?

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Thu, 18 Jan 2018 21:01:45 GMT

Why! that looks like a brilliant function! cool

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Fri, 19 Jan 2018 13:35:23 GMT

This looks promising. Do you know where I would insert that function into Xander Bakker's looping example above?

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Fri, 19 Jan 2018 13:46:59 GMT

did neither of my suggestions work? ie checking for None, or an empty string?

If they didn't, could you report the error so that we can figure out what is in the records that is causing the problem

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Sun, 12 Dec 2021 00:53:34 GMT

I was not sure what to set "points" is not equal (<>) to (""), and what to put after it.

Here is what I have so far

for row in (cursor):
    #  Set variables for SummarizeWithin
    #  Specify type of summarization, either Blocks or ZIPS, as part of the polys argument
    polys = "Market{0}".format(row[0])+"Blocks"
    points = "May_CTPatientVisits{0}".format(row[0])+"{0}".format(row[2])
    if points is not None:
        outFeatureClass = "May2_CTSumWithin{0}".format(row[0])+"{0}".format(row[2])
        keepAll = 'ONLY_INTERSECTING'
        sumFields = [['USER_VisitCount', 'Sum']]
        addShapeSum = 'ADD_SHAPE_SUM'

        arcpy.SummarizeWithin_analysis(polys, points, outFeatureClass, keepAll, sumFields, addShapeSum, '')
    
    #Print Results
        print(row[2])
#    print("SumWithin Elapsed Time:" + SumWithinruntime)
#    count = arcpy.GetMessageCount()
#    print (arcpy.GetMessage(count-2))
        print (arcpy.GetMessages())‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

DanPatterson_Retired — Sun, 12 Dec 2021 00:53:37 GMT

yes... posting code as it changes helps.

# ---- Current layout
for row in (cursor):
    #  Set variables for SummarizeWithin
    #  Specify type of summarization, either Blocks or ZIPS, as part of the polys argument
    polys = "Market{0}".format(row[0])+"Blocks"
    points = "May_CTPatientVisits{0}".format(row[0])+"{0}".format(row[2])
    if points is not None:

# ---- proposed to check so see if row[0] has a value or is <null> or "" and empty string

for row in (cursor):
    if points is not None:
        #  Set variables for SummarizeWithin
        #  Specify type of summarization, either Blocks or ZIPS, as part of the polys argument
        polys = "Market{0}".format(row[0])+"Blocks"
        points = "May_CTPatientVisits{0}".format(row[0])+"{0}".format(row[2])

# ---- in otherwords, you don't want to do anything if the row[0] doesn't have a count‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

XanderBakker — Sun, 12 Dec 2021 00:53:39 GMT

I'm confused... how is points ever going to be None when it will always have text in it?

points = "May_CTPatientVisits{0}".format(row[0])+"{0}".format(row[2])
‍‍‍

What do you want to validate? Maybe using different variable name would avoid confusion. Using "points" for a text is not part of best practices.

Also, try no to combine "+" and ".format()" to create a string. Just use format to make it more readable (like I suggested before in the code I posted) and make the month variable in order to avoid repeating blocks of code:

my_text_not_points = "{0}_CTPatientVisits{1}{2}".format(month, row[0], row[2])‍‍

Re: "If" Statement and Loop - ArcPy for ArcGIS Pro

Business_IntelligenceSoftware — Sun, 12 Dec 2021 00:53:42 GMT

I tried this, but it says "points is undefined", so then I tried copying points = "May2_CTSumWithin{0}" and pasting it above "if points is not None:" which allows it to run, but still doesn't exclude the Stores with no data

for row in (cursor):
    #  Set variables for SummarizeWithin
    #  Specify type of summarization, either Blocks or ZIPS, as part of the polys argument
    if points is not None:
        polys = "Market{0}".format(row[0])+"Blocks"
        points = "May_CTPatientVisits{0}".format(row[0])+"{0}".format(row[2])
        outFeatureClass = "May2_CTSumWithin{0}".format(row[0])+"{0}".format(row[2])
        keepAll = 'ONLY_INTERSECTING'
        sumFields = [['USER_VisitCount', 'Sum']]
        addShapeSum = 'ADD_SHAPE_SUM'

        arcpy.SummarizeWithin_analysis(polys, points, outFeatureClass, keepAll, sumFields, addShapeSum, '')
    
    #Print Results
        print(row[2])
#    print("SumWithin Elapsed Time:" + SumWithinruntime)
#    count = arcpy.GetMessageCount()
#    print (arcpy.GetMessage(count-2))
        print (arcpy.GetMessages())‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍