topic Re: Python script if/for/while in Python Questions

Python script if/for/while

CoyPotts1 — Fri, 10 Dec 2021 22:01:23 GMT

*UPDATE*

For samples of the correct code, see posts below.

I'll start off by apologizing for not having any sort of sample of my code, but I am really just unsure on how to begin the code, so all I have is notes of what I need.

I have a feature class that has a number of fields that are duplicated for 5 different customers. The fields that I need to focus on in this exercise are the Cust1Name, Cust1NodeID, Cust1HomeID, and 10 Cust1CircuitID fields. I'm using "Cust1", "Cust2", etc only as examples in place of their actual names...just stating that to eliminate your efforts in trying to add the customer number in a potential for/while loop. Essentially the fields look as they do below:

Cust1Name

Cust1NodeID

Cust1HomeID

Cust1CircuitID1

...

Cust1CirctuitID10

Cust2Name

Cust2NodeID

Cust2HomeID

Cust2CircuitID1

...

Cust2CircuitID10

etc...

My feature class has fields for all 5 customers, but not all 5 will be populated. I've used the Cust#NodeID field as my reference for whether calculations will run or not because that field determines if they are needed or not. Populated means run the calculation, while Null means do nothing.

if Cust1NodeID != None:
     return # insert calculation here
else:
     return None

I also need to get a users input to know the amount of circuit ID's needed. The number varies from 1 to 10 circuit ID's.

numberIDs = arcpy.GetParameterAsText(0)

With this information I need the script to go through each Cust#NodeID field to check and see if it's null or not. If it's null, keep moving...if it has data, calculate the amount of circuit ID fields needed based on the input.

Again, sorry for having nothing to start with. I'm just confused on which route to take (for loop, while loop, if/if...), and I can't figure out any of them either way. I'm just not sure how to add so many arguments together.

*EDIT*

I'll also note that the circuit ID calculation itself is just a concatenation of the given fields, as shown below:

Cust1CircuitID1 = (Cust1Name) - (Cust1NodeID) - (Cust1HomeID) - (01)

Cust1CircuitID2 = (Cust1Name) - (Cust1NodeID) - (Cust1HomeID) - (02)

etc...

Re: Python script if/for/while

DarrenWiens2 — Thu, 09 Jul 2015 17:05:52 GMT

Until you've got more, it's hard to help. You almost certainly need to use a SearchCursor (to read) or UpdateCursor (to read/write) to loop through your records. Is that the missing piece?

Re: Python script if/for/while

DanPatterson_Retired — Thu, 09 Jul 2015 17:36:03 GMT

It would be useful if you recorded your workflow. Specifically, do you use tools in ArcToolbox...like calculating values for fields, or doing selections... or are you doing things through their menu/tool/button equivalent in ArcMap. It is much easier to produce a script if you can replicate your workflow through arctoolbox tools and examine/copy the documentation from the Results Window (customize menu) to begin structuring your work (several options are documentated on my blog)

Re: Python script if/for/while

CoyPotts1 — Fri, 10 Dec 2021 22:01:26 GMT

The UpdateCursor method works wonders, but I can't seem to get the string portion of the return calculation to work properly. It keeps returning a literal string. I tried single quotes, and I tried ' """ + var + "" ' both with an without the space in between, and I just kept getting a literal string.

import arcpy

numIDs = arcpy.GetParameterAsText(0) # I equaled this to 1 in my testing to see if it would ignore CircuitID2 and it did
fc = r'my node feature class'
fields = ('Cust1NodeID', 'Cust1HomeID', 'Cust1Name', 'Cust1CircuitID1', 'Cust1CircuitID2', 'Cust1CircuitID3', 'Cust1CircuitID4', Cust1CircuitID5', 'Cust1CircuitID6', 'Cust1CircuitID7', 'Cust1CircuitID8', 'Cust1CircuitID9', 'Cust1CircuitID10')

with arcpy.da.UpdateCursor(fc, fields) as cursor:

     for row in cursor:
          if row[0] != None:
               row[3] = "(" + Cust1Name + ") - (" + Cust1NodeID + ") - (" + Cust1HomeID + ") - (01)"
          elif (row[0] != None and numIDs >= 2):
               row[4] = "(" + Cust1Name + ") - (" + Cust1NodeID + ") - (" + Cust1HomeID + ") - (02)"

This runs through and only updates Cust1CircuitID1, but I just need to get over the whole literal string hand up. I only wrote it out to calculate the first two CircuitID fields, but as my script note above states, I set the variable to 1 so that it would only calculate the first one.

I've seen the UpdateCursor function in other code samples, and I've seen reference to it, but I haven't tried it yet. Glad your suggestion led me to do a little research and learn it a little better . I'll likely be going back and updating some other code that I've created using this method.

Re: Python script if/for/while

CoyPotts1 — Thu, 09 Jul 2015 19:48:32 GMT

I use a script that calculates a lot of fields and runs a lot of summary statistics before exporting the results to Excel tables (a lot of the work that you have helped me with in other posts over the previous weeks). That script is ran from an ArcToolbox within ArcMap. This script is ran after we have created the data and made sure that all of the manually populated fields are populated, and then this script populates the rest and exports for us.

Essentially the circuit ID fields have either gone unpopulated or done manually by the users, and I've been trying find the time to go through and figure out a way to automate the process of their creation.

I could technically just do individual calculations for every single CircuitID field, but there are 10 per customer, and 5 total customers, so I would prefer not to rewrite the code for all 50 fields. Darren Wiens's suggestion above seems to be a good solution, and I think I have it nearly worked out, with the exception of the string issue.

Re: Python script if/for/while

DarrenWiens2 — Thu, 09 Jul 2015 20:00:14 GMT

The values in the cursor are accessed according to their position in the fields list:

fields = ('Cust1NodeID', 'Cust1HomeID', 'Cust1Name', 'Cust1CircuitID1', 'Cust1CircuitID2', 'Cust1CircuitID3', 'Cust1CircuitID4', Cust1CircuitID5', 'Cust1CircuitID6', 'Cust1CircuitID7', 'Cust1CircuitID8', 'Cust1CircuitID9', 'Cust1CircuitID10')

...corresponds to indexed values:

row[0], row[1], row[2], ..., row[12]

So, to access the value in the Cust1Name position, you would use the value:

row[2]

... rather than Cust1Name.

Re: Python script if/for/while

DanPatterson_Retired — Thu, 09 Jul 2015 20:23:28 GMT

or as Xander has suggested on a few occasions..before the

Cust1NodeID = row[0]

Cust1HomeID = row[1]

...

for row in rows:

then you can use their names

or you could also unwrap the args

Cust1NodeID, Cust1HomeID = row # or fields

but I haven't got a file to check

Re: Python script if/for/while

CoyPotts1 — Thu, 09 Jul 2015 20:24:49 GMT

Yeah, I noticed how the row corresponded with each position in the variable list, but I didn't realize that I would use the actual "row" nomenclature for the variable in the concatenation. That did the trick!

Thanks once again, dkwiens! I'm very thankful for people like you and Dan_Patterson!

Re: Python script if/for/while

CoyPotts1 — Fri, 10 Dec 2021 22:01:29 GMT

Does the code have the ability to step through each row and update them accordingly? In my example above the first line simply checks to see if the NodeID field is populated, and then if so it updates the CircuitID1 field. However, the second line checks whether the NodeID field is populated AND if the input variable is > or = to 2, and if so it updates the CircuitID2 field.

In the example above I used an input value of 1 just to see if it would stop there and not calculate the 2nd, and it seemed to work, but I believe it did for unwanted reasons. When I change the input variable to 2, the second line still doesn't calculate. If I remove the first line altogether and just run the second line, it populates the CircuitID2 field correctly.

Ideally the code should step through each if statement, check the parameters, and conditionally update the corresponding field below it, right?

if NodeID != None:
     calculate CircuitID1
elif NodeID != None and input variable >= 2:
     calculate CircuitID2
elif NodeID != None and input variable >= 3:
     calculate CircuitID3

etc...

So if I input 4, it'll update CircuitID1, 2, 3, and 4. However, if I only put 1, it'll update just CircuitID1. Is that not the way it should work?

Re: Python script if/for/while

CoyPotts1 — Fri, 10 Dec 2021 22:01:31 GMT

The actual code that I used that doesn't update both the if and elif is below:

import arcpy

numIDs = 2
fc = r'my node feature class'
fields = ('NodeID', 'HomeID', 'CustName', 'CircuitID1', 'CircuitID2')

with arcpy.da.UpdateCursor(fc, fields) as cursor:
     for row in cursor:
          if row[0] != None:
               row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)" # this works fine
          elif row[0] != None and numIDs >= 2):
               row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)" # this one won't run
          cursor.updateRow(row)

If I take the elif statement exactly as it is and put it in the if portion, it works, so I know the syntax is there for it to work, but something isn't allowing it to work in tandem with the other in an if/elif/elif/elif/elif format. When I run it just as it it typed above, it just runs through and updated the first if, and ignores the second. Any ideas why?

Re: Python script if/for/while

DanPatterson_Retired — Fri, 10 Dec 2021 22:01:34 GMT

The if, elif, statement will only get past into the if section

if row[0] != None:

it will never see the elif section unless you provide a condition for the condition where numIDs < 2 ... like

if (row[0] != None) & (numIDs < 2):

do stuff

elif blah

blah

cursor.updateRow

However this logic is also flawed potentially. Do you want the cursor to be updated if row[0] is = None???

perhaps your logic should be

if  (row[0] != None):
    if numIDs < 2:
        row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)" # this works fine 
    else
        row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)" # this one won't run  
    cursor.updateRow(row)

Re: Python script if/for/while

CoyPotts1 — Fri, 10 Dec 2021 22:01:36 GMT

If row[0] has a null value, then I want the script to return nothing. Basically if there is no node name, then we don't need a circuit ID for that node.

I ran the following samples and got different errors with each:

for row in cursor:
     if (row[0] != None):
          if (numIDs == 1):
               row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
          elif (numIDs == 2)
               row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
               row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)"
          cursor.updateRow(row)

This returns the error message:

"Parsing error SyntaxError: EOL while scanning string literal (line 16)"

for row in cursor:
     if (row[0] != None) & (numIDs < 2):
          row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
     elif (row[0] != None) & (numIDs < 3):
          row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
          row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)"
     cursor.updateRow(row)

This returns the error message:

"Runtime error

Traceback (most recent call last):

File "<string>", line 16, in <module>

TypeError: coercing to Unicode: need string or buffer, NoneType found"

Re: Python script if/for/while

DarrenWiens2 — Fri, 10 Jul 2015 18:36:16 GMT

First error: you need a colon after the elif statement.

elif (numIds == 2):

Second error: I don't believe '&' is a valid Python operator. Use 'and' instead at both places.

if (row[0] != None) and (numIDs < 2):

Re: Python script if/for/while

DanPatterson_Retired — Fri, 10 Jul 2015 18:57:41 GMT

too much NumPy ... you are right

Re: Python script if/for/while

CoyPotts1 — Fri, 10 Jul 2015 18:59:17 GMT

The colon was missing only in entry error...I manually typed out the code because whenever I try to paste into the syntax highlighter it ends up cutting off pieces. (I just tested and realized that you could paste the code first and then apply the syntax highlighting...doh! Nothing like a simple mistake to make you feel dumb)

I only used "&" because that's what Dan used in his examples. I substituted "and" in the same sample that was using "&", and I get the same error message:

"Runtime error

Traceback (most recent call last):

File "<string>", line 16, in <module>

TypeError: coercing to Unicode: need string or buffer, NoneType found"

Re: Python script if/for/while

DarrenWiens2 — Fri, 10 Dec 2021 22:01:39 GMT

I suspect the problem is trying to write null values, but haven't tested it.

for row in cursor:  
    if (row[0] != None) and (numIDs < 2):  
          row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"  
    elif (row[0] != None) and (numIDs < 3):  
          row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"  
          row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)" 
    else:
       pass # do nothing and move to next row

    cursor.updateRow(row)

Re: Python script if/for/while

DanPatterson_Retired — Fri, 10 Dec 2021 22:01:42 GMT

None null, none, nadda can be trapped by a truth test rather than a comparison test:

>>> vals = [None,1,2,3]
>>> for val in vals:
...  if val:
...   print "val is"
...  else:
...   print "val isn't"
...   
val isn't
val is
val is
val is
>>>

So perhaps you should be looking at getting rid of your ...if row[0] != None: stuff and just using if row[0]:

Re: Python script if/for/while

CoyPotts1 — Fri, 10 Dec 2021 22:01:45 GMT

I used your suggestion on all previous versions of the code and none worked.

(param1 and param2)

for row in cursor:
        if (row[0] and numIDs < 2):
            row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
        elif (row[0] and numIDs < 3):
            row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
            row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)"
        cursor.updateRow(row)

Returns this errors:

"Runtime error

Traceback (most recent call last):

File "<string>", line 16, in <module>

TypeError: coercing to Unicode: need string or buffer, NoneType found"

(param1) and (param2)

for row in cursor:
        if (row[0]) and (numIDs < 2):
            row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
        elif (row[0]) and (numIDs < 3):
            row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
            row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)"
        cursor.updateRow(row)

Returns the same error to the letter.

And Lastly:

if param1

if param2

for row in cursor:
        if row[0]:
            if numIDs < 2:
                row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
        elif row[0]:
            if numIDs < 3:
                row[3] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (01)"
                row[4] = "(" + row[2] + ") - (" + row[0] + ") - (" + row[1] + ") - (02)"
        cursor.updateRow(row)

This one doesn't seem to do anything. I'm not even sure if it runs. It doesn't kick back an error, but it also doesn't update the fields.

Re: Python script if/for/while

CoyPotts1 — Fri, 10 Jul 2015 20:59:44 GMT

I tried your suggestion with the same three scenarios as shown in my response to Dan (below), and I got the following results in order from top example to bottom:

Example 1:

"Runtime error

Traceback (most recent call last):

File "<string>", line 17, in <module>

TypeError: coercing to Unicode: need string or buffer, NoneType found"

Example 2:

"Runtime error

Traceback (most recent call last):

File "<string>", line 16, in <module>

TypeError: coercing to Unicode: need string or buffer, NoneType found"

Example 3:

Same as explained in my response to Dan where it seems like nothing really happens.

Re: Python script if/for/while

DarrenWiens2 — Fri, 10 Jul 2015 21:07:18 GMT

You can't concatenate strings and numbers. To convert numbers to strings, use str():

row[3] = "(" + str(row[2]) + ") - (" + str(row[0]) + ") - (" + str(row[1]) + ") - (01)"