topic Re: script does not work in Python Questions

script does not work

GerniceMuhamed — Fri, 30 Dec 2011 12:06:15 GMT

Hi can some please assist me in reprojecting shapefiles. I want to reproject it in Geographic Coordinate System WGS 1984 and then into the Projected Coordinate System ???World_Cylindrical_Equal_Area..My script does not work..keeps telling me that there is an invalid syntax..When it reaches the resFC i get that invalid syntax at the line

This is what i have

if sr.Name == "Unknown":
# skip
     continue
else:
# Determine the new output feature class path and name
    outFeatureClass = os.path.join(outWorkspace, infc.strip(".shp")
# Set output coordinate system
resFc = outFeatureClass + "," + ("<install directory>/Coordinate Systems/Projected Coordinate Systems/WGS 1984.prj/Cylindrical Equal Area (world).prj")
                arcpy.Project_management(infc, outFeatureClass, outCS)
                arcpy.AddMessage("The shapefiiles have been reprojected")
                print "Get Area Info...."

Re: script does not work

JakeSkinner — Fri, 30 Dec 2011 13:46:34 GMT

Can you post the entire script? Be sure to enclose it with

tags (the # symbol) to preserve indentation.

Re: script does not work

GerniceMuhamed — Sat, 11 Dec 2021 19:56:18 GMT

# Import system modules
import arcpy
from arcpy import env
import os, glob
# Set environment settings
arcpy.env.workspace = ("G:/Animals")

# Set local variables
outWorkspace = ("G:/Animals/Reproject_Out.gdb")

# Use ListFeatureClasses to generate a list of shapefiles in the
#  workspace shown above.
fcList = arcpy.ListFeatureClasses()
print fcList

# Set coordinate system only for those inputs which have a defined spatial reference
for infc in fcList:
# Determine if the input has a defined coordinate system
 desc = arcpy.Describe(Animals)
 sr = desc.spatialReference

if sr.Name == "Unknown":
# skip
     continue
else:
# Determine the new output feature class path and name
    outFeatureClass = os.path.join(outWorkspace, infc.strip(".shp")
# Set output coordinate system
    resFc = outFeatureClass + "," + ("<install directory>/Coordinate Systems/Projected Coordinate Systems/WGS 1984.prj/Cylindrical Equal Area (world).prj")
    arcpy.Project_management(infc, outFeatureClass, outCS)
    arcpy.AddMessage("The shapefiiles have been reprojected")
    print "Get Area Info...."
                                   
# Print message to say the two fields are being added
    arcpy.AddMessage("Adding fields F_AREA and C_AREA, calculating field values...")

# Execute AddField twice for two new fields  
    arcpy.AddField_management(Animals, F_AREA, "LONG", "", fieldLength)
    arcpy.AddField_management(Animals, C_AREA, "LONG", "", fieldLength)
try:
# Set the current workspace (to avoid having to specify the full path to the feature classes each time)
    arcpy.env.workspace = outCS

# Process: Calculate Areas...
    arcpy.CalculateAreas_stats(outCS, outCS_output_area)
except:
# If an error occurred when running the tool, print out the error message.
    print arcpy.GetMessages()
import math

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 14:41:38 GMT

This is what I have so far...I have other script to write but need to get this working first.. So JSkinn3 can you please let me know what you see is wrong...I have tried to use the wrap around the code hope its is better...

Re: script does not work

JakeSkinner — Fri, 30 Dec 2011 14:54:28 GMT

When you are projecting the shapefile, I don't see where you assigned a coordinate system to the 'outCS' variable.

arcpy.Project_management(infc, outFeatureClass, outCS)

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 15:00:03 GMT

The shapefiles i have dont have any projection its unknown... i am setting it to 2 different projections wgs84 first then Cylindrical Equal Area. i am not sure how to do it but thought this below would reproject it...

Set output coordinate system
resFc = outFeatureClass + "," + ("<install directory>/Coordinate Systems/Projected Coordinate Systems/WGS 1984.prj/Cylindrical Equal Area (world).prj")
arcpy.Project_management(infc, outFeatureClass, outCS)

Re: script does not work

EokNgo — Fri, 30 Dec 2011 15:50:38 GMT

You'll probably need to define the projection first using arcpy.DefineProjection_management
http://help.arcgis.com/en/arcgisdesktop/10.0/help/index.html#//001700000077000000

Then re-project the data as you have now using the arcpy.Project_management tool.

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 16:02:09 GMT

So I dont have to use a script to project the data into WGS84?????? Do I remove the resFc....... part of the script and just have arcpy.Project_management tool?

Re: script does not work

JakeSkinner — Sat, 11 Dec 2021 19:56:21 GMT

You will need to first define the projection of the shapefile that has an Unknown coordinate system, and then reproject the shapefile to your desired coordinate system. I highlighted in bold the areas I changed:

# Import system modules
import arcpy
from arcpy import env
import os, glob
# Set environment settings
arcpy.env.workspace = ("G:/Animals")

# Set local variables
outWorkspace = ("G:/Animals/Reproject_Out.gdb")

# Use ListFeatureClasses to generate a list of shapefiles in the
#  workspace shown above.
fcList = arcpy.ListFeatureClasses()
print fcList

# Set coordinate system only for those inputs which have a defined spatial reference
for infc in fcList:
# Determine if the input has a defined coordinate system
 desc = arcpy.Describe("Animals.shp")
 sr = desc.spatialReference

if sr.name == "Unknown":
# Determine the new output feature class path and name
    outFeatureClass = os.path.join(outWorkspace, infc.strip(".shp"))
# Set output coordinate system
    outCS = "Coordinate Systems\Geographic Coordinate Systems\World\WGS 1984.prj"
    outCS2 = "Coordinate Systems\Projected Coordinate Systems\World\Cylindrical Equal Area (world).prj"
    arcpy.DefineProjection_management(infc, outCS)
    arcpy.Project_management(infc, outFeatureClass, outCS2)
    arcpy.AddMessage("The shapefiiles have been reprojected")

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 16:07:03 GMT

ok thanx I will try it now

Re: script does not work

JakeSkinner — Fri, 30 Dec 2011 16:11:19 GMT

One other change you should make. Change the following line:

desc = arcpy.Describe("Animals.shp")

desc = arcpy.Describe(infc)

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 16:15:58 GMT

Now its telling me continue is not properly looped

Re: script does not work

JakeSkinner — Fri, 30 Dec 2011 16:21:51 GMT

You will not have to use 'continue'. You should have your functions under the 'if' statement (since you want to project all shapefiles with an Unknown coordinate system), and 'pass' under your 'else' statement. Pass will skip the shapefiles that have a coordinate system defined:

if sr.name == "Unknown":
# Determine the new output feature class path and name
    outFeatureClass = os.path.join(outWorkspace, infc.strip(".shp"))
# Set output coordinate system
    outCS = "Coordinate Systems\Geographic Coordinate Systems\World\WGS 1984.prj"
    outCS2 = "Coordinate Systems\Projected Coordinate Systems\World\Cylindrical Equal Area (world).prj"
    arcpy.DefineProjection_management(infc, outCS)
    arcpy.Project_management(infc, outFeatureClass, outCS2)
    arcpy.AddMessage("The shapefiiles have been reprojected")
    print "Get Area Info...."
else:
    pass

Re: script does not work

JakeSkinner — Sat, 11 Dec 2021 19:56:23 GMT

You will not need to use 'continue'.

if sr.name == "Unknown":
# Determine the new output feature class path and name
    outFeatureClass = os.path.join(outWorkspace, infc.strip(".shp"))
# Set output coordinate system
    outCS = "Coordinate Systems\Geographic Coordinate Systems\World\WGS 1984.prj"
    outCS2 = "Coordinate Systems\Projected Coordinate Systems\World\Cylindrical Equal Area (world).prj"
    arcpy.DefineProjection_management(infc, outCS)
    arcpy.Project_management(infc, outFeatureClass, outCS2)
    arcpy.AddMessage("The shapefiiles have been reprojected")
    print "Get Area Info...."

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 16:29:07 GMT

I got another problem...got this error if sr.Name == "Unknown":
NameError: name 'sr' is not defined...sr = desc.spatialReference...Doesn't this define it...

Re: script does not work

JakeSkinner — Fri, 30 Dec 2011 16:33:28 GMT

The arcpy module is case-sensitive. You will need to change it to sr.name. If you copy and paste the code I uploaded into Pythonwin, it should run successfully. I don't believe I changed any of the paths.

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 16:41:47 GMT

I copied it and still got an invalid syntax error at outCS...I guess i am bad lucky..cause i get an error every time i correct something

Re: script does not work

JakeSkinner — Fri, 30 Dec 2011 17:16:43 GMT

Not sure why the copy/paste did not work. You were receiving your initial error because you were missing a parentheses at the end of the following line:

outFeatureClass = os.path.join(outWorkspace, infc.strip(".shp")

Should be:

outFeatureClass = os.path.join(outWorkspace, infc.strip(".shp"))

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 17:18:48 GMT

I got it to not give an error..thanx much JSkinn3...Much appreciated

Re: script does not work

GerniceMuhamed — Fri, 30 Dec 2011 17:22:54 GMT

This is what my script did...[]...Did you get this?