topic Re: outFeatureClass/arcpy.CopyFeatures_management in Python Questions

outFeatureClass/arcpy.CopyFeatures_management

CliveSwan — Sat, 11 Dec 2021 18:30:48 GMT

I need to automate a shapefile to feature class update. The problem is that the shapefile name and output (feature class) are not the same.

So I need to hard code the shp & features.

I have a loop that works, printing out the shapefile names.

The code fails when I try to use the arcpy.CopyFeatures_management function.

Can anyone see what is causing the arcpy.CopyFeatures_management function to fail??

Would appreciate a suggestion to resolve the issue.

import arcpy
import glob
import os
import sys
import csv
import time
import smtplib
import shutil
import ftplib


sdeConnection = arcpy.env.workspace = r"C:\database_connections\GIST.sde"
outWorkspace =sdeConnection

datadir = arcpy.env.workspace = r"\\server1\ER Shares\Highway_Layer_Update" ## URL works

try:
    #check file exists here
    fcList = arcpy.ListFeatureClasses()

    ## Feature classes are hard coded
    ## Feature classes are hard coded
    for i in fcList:
        if i == "Bus Stops.shp":
            #outFeatureClass = os.path.join(outWorkspace, shapefile.strip(".shp"))
            #arcpy.CopyFeatures_management(shapefile, outFeatureClass)
            print i  ## NO shp
            fcnew = "GISADMIN.KCC_BUSSTOPS_NEW"
            outFeatureClass = os.path.join(outWorkspace, fcnew )
            arcpy.CopyFeatures_management(i,  outFeatureClass)
            arcpy.DeleteFeatures_management(i)
        elif i == "Cluster_sites_2014.shp":
            print i            ## Prints shp
            fcnew = "GISADMIN.KCC_KHS_CLUSTERS_2014_NEW"
            outFeatureClass = os.path.join(outWorkspace, fcnew )  ## Fails
            printoutFeatureClass
            arcpy.CopyFeatures_management(i, outFeatureClass)
            arcpy.DeleteFeatures_management(i)
        else:
            print "No file"
except:
    print ("No File found program terminated")  ## This is printed out

Message was edited by: Dan Patterson I formatted your code to make it easier to read... use the syntax highlighting ... >> ... and select Python

Re: outFeatureClass/arcpy.CopyFeatures_management

DanPatterson_Retired — Tue, 29 Dec 2015 13:44:58 GMT

What's up with line 36? printoutFeatureClass perhaps print outFeatureClass

So you are saying that it failed. Did you get an error message? and if so, what was it.

Re: outFeatureClass/arcpy.CopyFeatures_management

JamesCrandall — Sat, 11 Dec 2021 18:30:50 GMT

I'd try to uncover what the actual error is first. You can either simply remove the try/except block and it should print the traceback, or just update your except to print the actual error rather than "No File found program termintated" (you will need to add another import statement with the code below...

import traceback

  try:
     'do stuff


  except:
      exc_traceback = sys.exc_info()
      print traceback.print_exc()

Re: outFeatureClass/arcpy.CopyFeatures_management

CliveSwan — Tue, 29 Dec 2015 13:58:06 GMT

A typo,

I just printed out the except block message, not helpful.

Thanks.

Re: outFeatureClass/arcpy.CopyFeatures_management

DanPatterson_Retired — Tue, 29 Dec 2015 14:11:03 GMT

I agree with James. People spend more time trying to debug try-except blocks...or worse interpreting them. Having the listfeatureclasses within the try except block is an example. If you had that line outside, followed by a print statement, you would at least know it got that far. Also, a judicious use of print statements will allow you to see at each step whether a block succeeded.

Re: outFeatureClass/arcpy.CopyFeatures_management

CliveSwan — Tue, 29 Dec 2015 14:19:14 GMT

Hi James,

That provides a far more useful error message.

Thanks

Clive

Re: outFeatureClass/arcpy.CopyFeatures_management

JamesCrandall — Tue, 29 Dec 2015 14:27:02 GMT

As Dan mentioned, the try/except block can be a double-edge sword sometimes, especially at design-time.

I personally don't really employ them until I'm ready to build a test deployment version because I just want to see the tracebacks when they hit the Interactive Window (PythonWin). Even then, the print or arcpy.AddMessage methods don't help much for much of my deployed implementations and I will typically use these try/catch blocks for writing out log events.

Re: outFeatureClass/arcpy.CopyFeatures_management

DanPatterson_Retired — Sat, 11 Dec 2021 18:30:53 GMT

As an example...consider the variants of the simple script...

Header 1	Header 2
# version 1 print(something)	Traceback (most recent call last): File "C:\Python34\Lib\site-packages\pythonwin\pywin\framework\scriptutils.py", line 326, in RunScript exec(codeObject, __main__.__dict__) File "F:\B_Python_3_\Python_1_to_edit\try_except_demo.py", line 1, in <module> print(something) NameError: name 'something' is not defined
# version 2 try: print(something) except: print("ooops")	>>> ooops
# version 3 import sys import traceback try: print(something) except: exc_traceback = sys.exc_info() print(traceback.print_exc())	>>> Traceback (most recent call last): File "F:\B_Python_3_\Python_1_to_edit\try_except_demo.py", line 5, in <module> print(something) NameError: name 'something' is not defined None

Header 1

Header 2

# version 1
print(something)

Traceback (most recent call last):

File "C:\Python34\Lib\site-packages\pythonwin\pywin\framework\scriptutils.py", line 326, in RunScript

exec(codeObject, __main__.__dict__)

File "F:\B_Python_3_\Python_1_to_edit\try_except_demo.py", line 1, in <module>

print(something)

NameError: name 'something' is not defined

# version 2
try:
    print(something)
except:
    print("ooops")

>>> ooops

# version 3
import sys
import traceback
try:
    print(something)
except:
    exc_traceback = sys.exc_info()
    print(traceback.print_exc())

>>> Traceback (most recent call last):

File "F:\B_Python_3_\Python_1_to_edit\try_except_demo.py", line 5, in <module>

print(something)

NameError: name 'something' is not defined

None

Now...when developing scripts, I will leave it to the user to decide which is quicker in finding errors (dumb or otherwise) and which is the more informative

Re: outFeatureClass/arcpy.CopyFeatures_management

JamesCrandall — Tue, 29 Dec 2015 14:56:53 GMT

Great illustration.

I just started using the exc_traceback to simplify the error as I rarely need (or understand!) the error and line references to the actual modules/packages. But most of the time I don't even have try/catch during development!

Re: outFeatureClass/arcpy.CopyFeatures_management

DanPatterson_Retired — Sat, 11 Dec 2021 18:30:55 GMT

True... and since we have hijacked the thread, no one else cares and since you use pythonwin... the barebones error from the scriptutils.py script

("C:\Python34\Lib\site-packages\pythonwin\pywin\framework\scriptutils.py")

tries to execute line 326. Which I found was the line where...when everything else fails...pythonwin, finally tries to execute the script code using the variable from the dictionary

...

exec(codeObject, __main__.__dict__)

...

and of course, there is nothing in...

>>> locals().keys()
dict_keys(['__builtins__', '__loader__', '__doc__', 'pywin', '__name__', '__spec__', '__package__'])
>>>

called 'something'

Re: outFeatureClass/arcpy.CopyFeatures_management

RebeccaStrauch__GISP — Tue, 29 Dec 2015 16:28:58 GMT

back to your original question....first, I would recommend commenting out the

arcpy.DeleteFeatures_management(i)

line until you have it running.

Have you tried it without including the GISADMIN owner in the name? I know different ArcGIS versions have switched back and forth as to whether it wants it or it doesn't. I've had script that ran perfectly in one version, only to have to modify it to allow for the opposite situation in a different version. Running it manually once, then copying the python snippet from the results tab might help you see the format it wants in your version.

Also, I'm assuming you have many than just these two? If not, I would just do it manually and be done with it. If you have many, rather than having a whole string of If == statements, maybe make an array with the old and new names [[old1, new1], [old2, new2], []...] and loop thru that, or if you are just trying to remove the spaces in the name, you can do some string manipulation on the .shp name from your listfeatures to automate the new name.

Just some ideas.

Re: outFeatureClass/arcpy.CopyFeatures_management

CliveSwan — Tue, 29 Dec 2015 19:15:01 GMT

I amended the code, the error message indicated there was an existing Feature class.

The arcpy.copymanagement works, the arcpy.deletemanagement still fails??

sdeConnection = arcpy.env.workspace = r"C:\database_connections\GIST.sde"

outWorkspace =sdeConnection

datadir = arcpy.env.workspace = r"\\server1\\GISData\Highway_Layer_Update"

##print datadir

try:

##check file exists here

fcList = arcpy.ListFeatureClasses()

for i in fcList:

if i == "Bus Stops.shp": ### no file

#outFeatureClass = os.path.join(outWorkspace, shapefile.strip(".shp"))

#arcpy.CopyFeatures_management(shapefile, outFeatureClass)

print i

fcnewbus = "GISADMIN.BUSSTOPS_NEW"

outbus = os.path.join(outWorkspace, fcnewbus )

arcpy.CopyFeatures_management(i, outbus)

arcpy.DeleteFeatures_management(r"\\server1\\GISData\Highway_Layer_Update\Bus Stops.shp")

## #arcpy.DeleteFeatures_management(datadir + "\Bus Stops.shp")

elif i == "Cluster_sites.shp": ## file exsists

print i

fcnewcluster = "GISADMIN.CLUSTERS_NEW"

outcluster = os.path.join(outWorkspace, fcnewcluster)

arcpy.CopyFeatures_management(i, outcluster) ## WORKS!!!

arcpy.DeleteFeatures_management(r"r"\\server1\\GISData\Highway_Layer_Update\Cluster_sites.shp")

## DELETE FAILS

##arcpy.DeleteFeatures_management(datadir + "\Cluster_sites_2014.shp")

Error message existing connexion forcibly closed????

Message	File Name	Line	Position
Traceback
__call__	C:\Program Files (x86)\PyScripter\Lib\rpyc.zip\rpyc\core\netref.py	196
syncreq	C:\Program Files (x86)\PyScripter\Lib\rpyc.zip\rpyc\core\netref.py	71
sync_request	C:\Program Files (x86)\PyScripter\Lib\rpyc.zip\rpyc\core\protocol.py	431
serve	C:\Program Files (x86)\PyScripter\Lib\rpyc.zip\rpyc\core\protocol.py	379
_recv	C:\Program Files (x86)\PyScripter\Lib\rpyc.zip\rpyc\core\protocol.py	337
recv	C:\Program Files (x86)\PyScripter\Lib\rpyc.zip\rpyc\core\channel.py	50
read	C:\Program Files (x86)\PyScripter\Lib\rpyc.zip\rpyc\core\stream.py	166
exceptions.EOFError: [Errno 10054] An existing connection was forcibly closed by the remote host

Re: outFeatureClass/arcpy.CopyFeatures_management

DanPatterson_Retired — Tue, 29 Dec 2015 19:19:28 GMT

SDE stuff... sorry, check your script logic on a local file if you can before you try to debug scripts loading from other connections.

Re: outFeatureClass/arcpy.CopyFeatures_management

RebeccaStrauch__GISP — Sat, 11 Dec 2021 18:30:58 GMT

you may want to use the "Advanced Editor" in the upper right corner to edit your last reply (must have it open in a new Tab...not in the geonet inbox).

It's have to tell is

##	#arcpy.DeleteFeatures_management(datadir + "\Bus Stops.shp")

is an indentation error or not. But my copy/paste was weird, so maybe might be the issue.

I would use

filetodelete = arcpy.os.path.join(datadir, "Bus Stops.shp")
arcpy.DeleteFeatures_Management(filetodelete)

arcpy.DeleteFeatures_management(datadir + "\\Bus Stops.shp")

...notice double \\

... also, you have a double r"r" in

arcpy.DeleteFeatures_management(r"r"\\server1\\GISData\Highway_Layer_Update\Cluster_sites.shp")