topic Re: Python Tool - User input then Select by Attribute in Python Questions

Python Tool - User input then Select by Attribute

DevinUnderwood2 — Sat, 11 Dec 2021 12:49:22 GMT

Any ideas why I am having problems by trying to have user input a string value for a feature, then have the feature selected.

#Import Modules
import os,arcpy
mxd = arcpy.mapping.MapDocument ('CURRENT')
df = arcpy.mapping.ListDataFrames(mxd,"Layers")[0]
#os.chdir(r'C:\Users\dunderwood\Documents\MY_TEMPLATES\WASTEWATER_EDIT_TEMPLATE')
# Set the parameters
InputFeatureClass = arcpy.GetParameterAsText(0)
InputField = arcpy.GetParameterAsText(1)
InputValue = arcpy.GetParameterAsText(2)

whereClause = FACILITYID == InputValue"
arcpy.SelectLayerByAttribute_management(InputFeatureClass, "NEW_SELECTION", whereClause)
df.zoomToSelectedFeatures()
arcpy.RefreshActiveView()‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: Python Tool - User input then Select by Attribute

DarrenWiens2 — Mon, 06 Feb 2017 21:26:11 GMT

The problem is your where clause. See here for how to specify a query in Python, especially the last example: Specifying a query in Python—ArcPy Get Started | ArcGIS Desktop

e.g.

whereclause = """{} = 2""".format(arcpy.AddFieldDelimiters(fc, fieldname))‍

Re: Python Tool - User input then Select by Attribute

DanPatterson_Retired — Mon, 06 Feb 2017 21:26:59 GMT

Select analysis has a code snippet and links to formulating sql queries that will work. Your query lacks the proper quotation sequence

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Mon, 06 Feb 2017 21:39:23 GMT

Thank you for the quick responses.

I will work on this, at first glance, I need brackets and/or add field delimiter, etc. I am taking away from this that my sql clause needs work.

Re: Python Tool - User input then Select by Attribute

DarrenWiens2 — Mon, 06 Feb 2017 22:02:53 GMT

I believe you can just use this for your case:

whereClause = """{} = {}""".format(arcpy.AddFieldDelimiters(InputFeatureClass, 'FACILITYID'),InputValue)‍‍

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Mon, 06 Feb 2017 23:22:17 GMT

Does it need 'FACILITYID' since it is referenced in InputValue ?

I tried this line and still having difficulty.

Re: Python Tool - User input then Select by Attribute

DarrenWiens2 — Mon, 06 Feb 2017 23:25:23 GMT

Oh, right. It should be like below so that all three input variables are dynamic.

whereClause = """{} = {}""".format(arcpy.AddFieldDelimiters(InputFeatureClass, InputField),InputValue)‍

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Sat, 11 Dec 2021 12:49:24 GMT

I get the following message, don't know what is wrong.

Executing: QueryMxdFeatureClass "SWR Layers\Manholes" FACILITYID 5564

Start Time: Mon Feb 06 15:41:32 2017

Running script QueryMxdFeatureClass...

Failed script QueryMxdFeatureClass...

SyntaxError: invalid syntax (QueryMxdFeatureClass.py, line 19)

Failed to execute (QueryMxdFeatureClass).

Failed at Mon Feb 06 15:41:33 2017 (Elapsed Time: 0.67 seconds)

Here is my updated syntax

#Import Modules
import os,arcpy
mxd = arcpy.mapping.MapDocument ('CURRENT')
df = arcpy.mapping.ListDataFrames(mxd,"Layers")[0]

# Set the parameters
InputFeatureClass = arcpy.GetParameterAsText(0)
InputField = arcpy.GetParameterAsText(1)
InputValue = arcpy.GetParameterAsText(2)

whereclause = """{} = {}""".format(arcpy.AddFieldDelimiters(InputFeatureClass,InputField,InputValue)

arcpy.SelectLayerByAttribute_management(InputFeatureClass, "NEW_SELECTION", whereclause)
df.zoomToSelectedFeatures()
arcpy.RefreshActiveView()‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: Python Tool - User input then Select by Attribute

DanPatterson_Retired — Mon, 06 Feb 2017 23:52:56 GMT

Can you put in some print statements so that the exact format can be examined. If the input value is a number there is one format, if the input value there is another... plus Darren updated his where clause with a syntax different thatn you provided on line 10

Re: Python Tool - User input then Select by Attribute

DarrenWiens2 — Mon, 06 Feb 2017 23:56:08 GMT

Your where clause is ever-so-slightly different from mine - missing a ')' after InputField.

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Tue, 07 Feb 2017 00:03:02 GMT

Oh didn't catch that. I changed it. I am unable to use print statements to test it out since I am running it as a tool which doesn't return print statements.

whereclause = """{} = {}""".format(arcpy.AddFieldDelimiters(InputFeatureClass,InputField),InputValue)‍

Re: Python Tool - User input then Select by Attribute

DanPatterson_Retired — Tue, 07 Feb 2017 00:56:00 GMT

arcpy.AddMessage("Same as print when running tools") # for print equivalent in arctoolbox

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Tue, 07 Feb 2017 15:27:38 GMT

Thanks. What messages would I want to troubleshoot my syntax ?

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Sat, 11 Dec 2021 12:49:27 GMT

I have the following yet it is not working. Something still wrong with the expression.

Does it matter whether it is a .sde feature class .or file geodatabase feature ?

#Import Modules
import os,arcpy
#Set to current mxd and dataframe
mxd = arcpy.mapping.MapDocument ('CURRENT')
df = arcpy.mapping.ListDataFrames(mxd,"Layers")[0]

# Set the tool parameters
InputFeatureClass = arcpy.GetParameterAsText(0)
InputField = arcpy.GetParameterAsText(1)
InputValue = arcpy.GetParameterAsText(2)
# SQL expression used in selecting a feature
whereclause = """{} = {}""".format(arcpy.AddFieldDelimiters(InputFeatureClass,InputField),InputValue)
#Select feature by facilityid (InputValue)
arcpy.SelectLayerByAttribute_management(InputFeatureClass, "NEW_SELECTION", whereclause)
df.zoomToSelectedFeatures()
arcpy.RefreshActiveView()‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: Python Tool - User input then Select by Attribute

DarrenWiens2 — Tue, 07 Feb 2017 16:50:24 GMT

Try passing the full path to your feature class for InputFeatureClass. Otherwise, what's the exact error message?

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Tue, 07 Feb 2017 17:10:52 GMT

I placed the full path and still no luck. Here is the following error message.

Traceback (most recent call last):

File "C:\Users\...Scripts\QueryMxdFeatureClass.py", line 18, in <module>

arcpy.SelectLayerByAttribute_management(InputFeatureClass, "NEW_SELECTION", whereclause)

File "c:\program files (x86)\arcgis\desktop10.2\arcpy\arcpy\management.py", line 6688, in SelectLayerByAttribute

raise e

ExecuteError: ERROR 000358: Invalid expression

Failed to execute (SelectLayerByAttribute).

Failed to execute (QueryMxdFeatureClass).

Failed at Tue Feb 07 09:06:24 2017 (Elapsed Time: 0.47 seconds)

Re: Python Tool - User input then Select by Attribute

DarrenWiens2 — Tue, 07 Feb 2017 17:17:51 GMT

What do you get when you print the whereclause?

arcpy.AddMessage(whereclause)‍

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Tue, 07 Feb 2017 17:24:37 GMT

Interesting, I used arcpy.AddMessage(whereclause) and get the following results.

I am assuming that it successfully received the Inputvalue., but can't select the feature.

Executing: QueryMxdFeatureClass "SWR Layers\Manholes" FACILITYID 5564

Start Time: Tue Feb 07 09:19:10 2017

Running script QueryMxdFeatureClass...

"FACILITYID" = 5564

Failed script QueryMxdFeatureClass...

Re: Python Tool - User input then Select by Attribute

DarrenWiens2 — Tue, 07 Feb 2017 17:33:22 GMT

Can you try moving the "Manholes" layer outside of the "SWR Layers" group and try it just as "Manholes"?

Re: Python Tool - User input then Select by Attribute

DevinUnderwood2 — Tue, 07 Feb 2017 17:40:17 GMT

I removed it from the group and same error.