topic Re: Python script read coordinate system, drag and drop in Python Questions

Python script read coordinate system, drag and drop

ZackBartlett — Mon, 18 Jun 2012 19:02:18 GMT

I have a python script that accepts a project shapefile, asks for a few parameters, and does the following:
1. Projects to a new coordinate system (as defined by the user)
2. Calculates new X and Y values
3. Saves as a layer file
4. Saves as a KMZ file.

The script, fortunately, works as intended, but I'm trying to make it run nicer and be more user-friendly. I want to do the following things:

1. When the original shapefile is loaded, I would like the tool to read it's coordinate system and enter that information in a box in the tool (similar to what happens in the "Project" tool when a shapefile is added). It would just be there for reference and would not be editable. I understand this may need to be done through the Tool Validator class, but I do not have much experience with this.

2. The tool does not currently allow me to drag-and-drop a shapefile into the tools input from the TOC. How do I enable this functionality?

Here is the code I have so far, for reference:

# Author: Zachary Bartlett
# Date: June 14, 2012
# 1. Input .shp
# 2. Read coordinate system
# 3. Input: New coordinate system
# 4. Project: to new MTM coordinate system
# 5. Output: new shapefile projected to MTM
# 5. Input: New X and Y field names
# 6. Add X and Y coordinates
# 7. Output: .lyr with custom name
# 8. Output: .kmz with custom name

import arcpy, os, glob

# INPUT SHAPEFILE

input_shp = arcpy.GetParameterAsText(0)
arcpy.AddMessage("Input shapefile: " + str(input_shp))

work_folder_pos = input_shp.rfind("\\")
work_folder = input_shp[0:int(work_folder_pos)]
arcpy.AddMessage("Workspace: " + str(work_folder))

# READ COORDINATE SYSTEM

coordinatesystem_ORIG = arcpy.Describe(input_shp).spatialReference
arcpy.AddMessage("Input Coordinate System: " + str(coordinatesystem_ORIG.name))

# PROJECT input_shp TO NEW COORDINATE SYSTEM AND SAVE AS NEW SHP

MTM_shp = arcpy.GetParameterAsText(1)
coordinatesystem_NEW = arcpy.GetParameterAsText(2)
arcpy.AddMessage("Output shapefile: " + str(MTM_shp))
arcpy.AddMessage("Output Coordinate System: " + str(coordinatesystem_NEW))
arcpy.Project_management(input_shp, MTM_shp, coordinatesystem_NEW) 

# ADD X AND Y COORDINATES TO MTM_shp AS POINT_X AND POINT_Y

arcpy.AddXY_management(MTM_shp)
#arcpy.AddMessage("Input shapefile coordinate system: ") + coordinatesystem_ORIG

# INPUT X AND Y FIELD NAMES

X_MTM_fieldname = arcpy.GetParameterAsText(3)
Y_MTM_fieldname = arcpy.GetParameterAsText(4)
arcpy.AddField_management(MTM_shp, X_MTM_fieldname, "double", "15", "3", "", "", "NON_NULLABLE", "REQUIRED")
arcpy.AddField_management(MTM_shp, Y_MTM_fieldname, "double", "15", "3", "", "", "NON_NULLABLE", "REQUIRED")

# COPY POINT_X AND POINT_Y to X_MTM_fieldname and Y_MTM_fieldname

arcpy.CalculateField_management(MTM_shp, X_MTM_fieldname, '!POINT_X!', "PYTHON")
arcpy.CalculateField_management(MTM_shp, Y_MTM_fieldname, '!POINT_Y!', "PYTHON")

#DELETE POINT_X AND POINT_Y COLUMNS

arcpy.DeleteField_management(MTM_shp, ["POINT_X", "POINT_Y"])

# CREATE TEMPORARY FEATURE LAYER

fl_temp = work_folder + "\MTM_lf_temp"
arcpy.MakeFeatureLayer_management(MTM_shp, fl_temp)

#OUTPUT LYR WITH CUSTOM NAME

output_lyr = arcpy.GetParameterAsText(5)
#output_lyr = arcpy.AddMessage("Output Layer File: ")
arcpy.SaveToLayerFile_management(fl_temp, output_lyr)

# OUTPUT DBF WITH CUSTOM NAME

##output_dbf = arcpy.GetParameterAsText(6)
##arcpy.TableToDBASE_conversion(MTM_shp, output_dbf)

#OUTPUT KMZ WITH CUTOM NAME

output_kmz = arcpy.GetParameterAsText(6)
#output_kmz = arcpy.AddMessage("Output KMZ File: ")
arcpy.LayerToKML_conversion(output_lyr, output_kmz, 10000)

Any help would be greatly appreciated.

Thanks!

-Zack

Re: Python script read coordinate system, drag and drop

JakeSkinner — Fri, 10 Dec 2021 21:04:01 GMT

Hi Zack,

1. You will need to update the updateParameters function within the ToolValidator class with the following:

def updateParameters(self):
  if self.params[0].value:
    sr = arcpy.Describe(self.params[0].value).spatialReference
    self.params[7].value = sr.name
  self.params[7].enabled = 0
  return

The index value for self.params[7] may be different depending on where you want the input coordinate system to be shown within the tool.

2. Change the parameter's Data Type to 'Feature Layer'. This will allow you to drag and drop, and also provide a dropdown listing the feature classes within ArcMap.

Re: Python script read coordinate system, drag and drop

ZackBartlett — Tue, 19 Jun 2012 17:17:19 GMT

What sort of modifications do I need to make to my script code?

Thanks

-Zack

Re: Python script read coordinate system, drag and drop

JakeSkinner — Tue, 19 Jun 2012 17:23:57 GMT

You won't have to make any to your python script.

Re: Python script read coordinate system, drag and drop

ZackBartlett — Tue, 19 Jun 2012 17:46:18 GMT

When I add your text to the tool validator, my "Output .shp" (GetParameterAsText[1]) field is greyed out. And the "Output .kmz" (GetParameterAsText[6]) is now missing.

I tried adding another Parameter to house the Coordinate System, but the field doesn't populate when I add a shapefile, and I get the following error my "Input .shp" (GetParameterAsText[0]):

ERROR
updateParameters Execution Error: Runtime error : ParameterObject: Invalid input value for Value property

Re: Python script read coordinate system, drag and drop

JakeSkinner — Wed, 20 Jun 2012 10:09:06 GMT

Can you send a screen shot of your Properties tab within the script properties? Depending on where you have the parameter set up for the coordinate system you will have to change index values for the 'arcpy.GetParameterAsText' function, and the self.params within the ToolValidator.

Re: Python script read coordinate system, drag and drop

ZackBartlett — Thu, 21 Jun 2012 12:12:17 GMT

Here's a screenshot of the Parameters tab:

[ATTACH=CONFIG]15389[/ATTACH]

Re: Python script read coordinate system, drag and drop

JakeSkinner — Fri, 10 Dec 2021 21:04:04 GMT

Hi Zack,

It looks like you set the Input Coordinate system as the second parameter, so this will have an index of 1. Therefore, you will need to increase all of your index values for arcpy.GetParameterAsText (excluding arcpy.GetParameterAsText(0)) by 1 within your code.

The ToolValidator should appear as below:

def updateParameters(self):
    if self.params[0].value:
      sr = arcpy.Describe(self.params[0].value).spatialReference
      self.params[1].value = sr.name
      self.params[1].enabled = 0
    return

Re: Python script read coordinate system, drag and drop

JakeSkinner — Fri, 10 Dec 2021 21:04:07 GMT

Also, I noticed in your original code, you have the output dbf and kmz file as the same index for the arcpy.GetParameterAsText:

# OUTPUT DBF WITH CUSTOM NAME  ##output_dbf = arcpy.GetParameterAsText(6) ##arcpy.TableToDBASE_conversion(MTM_shp, output_dbf)  #OUTPUT KMZ WITH CUTOM NAME  output_kmz = arcpy.GetParameterAsText(6) #output_kmz = arcpy.AddMessage("Output KMZ File: ") arcpy.LayerToKML_conversion(output_lyr, output_kmz, 10000)

Change the OUTPUT KMZ to:

output_kmz = arcpy.GetParameterAsText(7)

Re: Python script read coordinate system, drag and drop

AdamCox1 — Thu, 20 Dec 2012 12:53:29 GMT

Hello, this thread was hugely helpful to me, as I was trying to do the exact same things as Zack. I was having the same problem after following this advice and found that the issue was that I still had the spatial reference parameter input type set to Spatial Reference, when I needed to have it set to String because that's what I was trying to put into it...

However, I have a question about the other suggestion for dragging and dropping. Changing the parameter input type to "Feature Layer" does allow me to drag and drop from the TOC, which is great, but if I try to drag and drop from an INACTIVE dataframe, ArcMap encounters a serious error and crashes. Is this a known problem? Am I missing a piece of the puzzle?

Thanks for your help,
Adam

Re: Python script read coordinate system, drag and drop

ChrisFox3 — Thu, 20 Dec 2012 22:41:31 GMT

Adam, which version and sp are you at? I can't reproduce the crash at 10.1 sp1, but I will say drag/drop or referencing a layer from an inactive data frame has never been supported. You can see this if you click the drop-down in the parameter it will only show you the layers from the active data frame. You should get an error on the parameter saying the input dataset doesn't exist. However, it still shouldn't crash and if we can reproduce it I would like to log a bug.

Re: Python script read coordinate system, drag and drop

AdamCox1 — Fri, 21 Dec 2012 21:08:46 GMT

Hello Chris, I'm running ArcGIS 10.0 without any service pack.

I've been retrying this a number of times, and it crashes pretty reliably, but not every single time. One time gave me the error message you mentioned after I correctly input a layer and then tried to drag one from an inactive dataframe, but now that doesn't work and it crashes everytime... I'm using a script that I created, and it's one of my first attempts at any meaningful programming, so I could have something wrong that I'm unaware of. I can give you more details on the script if you need.

Thanks!!

Re: Python script read coordinate system, drag and drop

ChrisFox3 — Fri, 21 Dec 2012 21:20:42 GMT

To narrow it down, could you try drag/drop into a system tool like copy features? Does it still crash. This would tell us if it is specific to your tool or not.

Re: Python script read coordinate system, drag and drop

AdamCox1 — Fri, 10 Dec 2021 21:04:09 GMT

Yes, I tried that right away and it doesn't crash, I just get the "does not exist/not supported" message.

Ok, it only happens when I drag/drop into the parameter that has been modified in the ToolValidator with the code described above. Here is the code that I have in ToolValidator:

([1] is the input fc parameter set to feature layer, and [2] is the string parameter that just shows the coordinate system of [1]):

def updateParameters(self):
    self.params[2].enabled = 0
    if self.params[1].value:
      self.params[2].enabled = 1
      SR = arcpy.Describe(self.params[1].value).spatialReference
      self.params[2].value = SR.name
      self.params[2].enabled = 0
    return

When I comment out this code, the parameter drag/drop operation functions as it should.

Re: Python script read coordinate system, drag and drop

JakeSkinner — Wed, 26 Dec 2012 10:43:09 GMT

Hi Adam,

Can you send a screen shot of your Parameters tab within the Script properties?

Re: Python script read coordinate system, drag and drop

AdamCox1 — Wed, 02 Jan 2013 13:38:27 GMT

Hi Jake, Happy New Year!

Here's a screen shot. Let me know if you wanted a different parameter highlighted.

Thanks!
Adam

Re: Python script read coordinate system, drag and drop

JakeSkinner — Wed, 02 Jan 2013 14:48:17 GMT

Try upgrading to Service Pack 5 and see if you are still able to reproduce the crash.

Re: Python script read coordinate system, drag and drop

AdamCox1 — Wed, 02 Jan 2013 15:06:30 GMT

Service Pack 5 seems to have done the trick, no crashing, just the expected error message. Thanks!