topic Re: Remove Layers in Python Questions

Remove Layers

Yaron_YosefCohen — Sat, 11 Dec 2021 12:26:21 GMT

Hi everyone,

i have mxd with 85 layers and i try to remove layers (with arcpy) that don't exist in the current data frame. i using this code:

import arcpy,os,sys,string
import arcpy.mapping
from arcpy import env

env.workspace = r"C:\Project"
for mxdname in arcpy.ListFiles('*.mxd'):
     print mxdname
     mxd = arcpy.mapping.MapDocument(r"C:\Project\\" + mxdname)
     df = arcpy.mapping.ListDataFrames(mxd, "Layers")[0]
     for lyr in arcpy.mapping.ListLayers(mxd,"",df):
          if lyr in df.extent == False:
               arcpy.mapping.RemoveLayer(df, lyr)
               print 'RemoveLayer'     
     mxd.save()
del  mxd

but i get en error:

>>> 
Project.mxd

Traceback (most recent call last):
  File "C:/yaron/shonot/software/gis/tools/YARON_SCRIPTS/aaaaaaaaaaaaaa.py", line 15, in <module>
    if lyr in df.extent == False:
TypeError: argument of type 'Extent' is not iterable
>>>

i don't know why my code doesn't work.

Thanks for any help.

Re: Remove Layers

DanPatterson_Retired — Sun, 12 Apr 2015 10:08:55 GMT

extent is definitely not iterable... you should read up on the class objects before attempting them, there are functions in there that you can use to decide whether two geometries intersect and/or one contains the other etc. In your case, I suspect that you need the extent of the lyr, then you need to decide which of the options that you wish to use and of course, whether the files is in the same projection as the other extent object. Have a think, then propose your options before assessing code options.

Re: Remove Layers

Luke_Pinner — Sun, 12 Apr 2015 10:14:00 GMT

Extent objects support a 'overlaps' method

Try something like:

if not df.extent.overlaps(lyr.getExtent()) :

etc...

Sorry about the lack of formatting and links, the GeoNet mobile site is terrible.

Re: Remove Layers

Yaron_YosefCohen — Sun, 12 Apr 2015 11:12:08 GMT

i try this:

import arcpy,os,sys,string

import arcpy.mapping

from arcpy import env

env.workspace = r"C:\Project"

for mxdname in arcpy.ListFiles('*.mxd'):

print mxdname

mxd = arcpy.mapping.MapDocument(r"C:\Project\\" + mxdname)

df = arcpy.mapping.ListDataFrames(mxd, "Layers")[0]

for lyr in arcpy.mapping.ListLayers(mxd, "" ,df):

if not df.extent.overlaps(lyr.getExtent()):

arcpy.mapping.RemoveLayer(df, lyr)

print lyr

mxd.save()

del mxd

but actually arcpy remove also layers that have been halfly in the data frame

Re: Remove Layers

DanPatterson_Retired — Sun, 12 Apr 2015 12:09:58 GMT

look at some of the other options in the link I sent you...surely you can figure out one that works or send the files to Luke for testing

Re: Remove Layers

Yaron_YosefCohen — Sun, 12 Apr 2015 12:52:30 GMT

i ask a question because i new in all that python stuff, if you noticed that. If you think that my questions are not clever enough please don't answered them. your last answer are very sarcastic and I was very offended from you.

Re: Remove Layers

DanPatterson_Retired — Sun, 12 Apr 2015 14:04:31 GMT

Then next time it would be best to try and articulate what you have tried. All the information for testing is contained in the first link...you chose to grab a code snippet and hope it worked...that is not how you garner help, you have to make some effort. I apologize if I offended you, but your questions and responses often don't show any attempt at research but seem to be geared to getting an immediate solution.

So did you try

contains
crosses
overlaps
within
touches
equals
disjoint

in place of Luke's suggestion...you are the only one that can answer that

Re: Remove Layers

XanderBakker — Sun, 12 Apr 2015 19:32:31 GMT

Checking intersects or overlaps of extents does no guarantee that a layer has features within the current data frame extent.

I am wondering why you want to remove these layers? It because they are showing up in the legend or so?

Re: Remove Layers

Luke_Pinner — Sat, 11 Dec 2021 12:26:23 GMT

The 'overlaps' method must return False if the dataframe extent is completely within/completely contains the layer extent. Try the 'disjoint' method instead. See the documentation - http://resources.arcgis.com/en/help/main/10.2/index.html#//018z00000072000000

Something like:

    for mxdname in arcpy.ListFiles('*.mxd'):

        print mxdname
        mxd = arcpy.mapping.MapDocument(os.path.join(env.workspace, mxdname))
        df = arcpy.mapping.ListDataFrames(mxd, "Layers")[0]
        for lyr in arcpy.mapping.ListLayers(mxd, "" ,df):
              if df.extent.disjoint(lyr.getExtent()):
                  arcpy.mapping.RemoveLayer(df, lyr)
                  print lyr

        mxd.save()

    del  mxd

Re: Remove Layers

Yaron_YosefCohen — Mon, 13 Apr 2015 05:27:31 GMT

no, i want to remove them automatically because they located out of the data frame. i mean the layers has coordinate system like the data frame but in specific area in there several layers and not all the the layers. so instead remove the unseen layers i try to build code that will do it.

Re: Remove Layers

Yaron_YosefCohen — Mon, 13 Apr 2015 05:31:36 GMT

i do read it ,but didn't understand - that the reason i join this forum.

Re: Remove Layers

Yaron_YosefCohen — Mon, 13 Apr 2015 05:53:49 GMT

thanks Luke !! it works!!

Re: Remove Layers

Yaron_YosefCohen — Mon, 13 Apr 2015 06:16:46 GMT

the code don't work with shape file - just with layer file

Re: Remove Layers

Luke_Pinner — Mon, 13 Apr 2015 06:24:04 GMT

Correct. A feature class does not have a "getExtent()" method like a layer does. You need the arcpy.Describe method and the extent property - i.e. arcpy.Describe(shapefile).extent

Re: Remove Layers

GeorgeReece_Jr_ — Mon, 13 Apr 2015 13:46:00 GMT

I think Luke has the correct answer to this problem.

Re: Remove Layers

Yaron_YosefCohen — Tue, 14 Apr 2015 06:47:50 GMT

you think maybe geonet help community would be more compatible to my question?

Re: Remove Layers

DanPatterson_Retired — Tue, 14 Apr 2015 07:28:31 GMT

Cross-posted arcpy - How to remove layers that are not in visible df extent - Geographic Information Systems Stack Exchange

for completeness