topic Re: arcpy visible not working in Python Questions

arcpy visible not working

ZackBartlett — Tue, 04 Feb 2014 13:09:37 GMT

I have a script that adds .lyr files to an MXD.

A loop then iterates through the layers in the MXD and turns them all OFF, using the lyr.visible = False function. This part of my code works.

I then want to iterate through the list again, turn on the first layer, export the map as a PDF, turn off the layer, then move onto the next layer. This is the part that doesn't work. The layers do not turn on again. The PDFs export, but they are all blank.

I've seen this question asked before, but the solutions listed don't seem to be working for me.

I've posted the code below.

LYR_list_MXD = arcpy.mapping.ListLayers(MXD,"*_env*",DF)  for LYR in LYR_list_MXD:         LYR.visible = False  MXD.save()  # Turn on each layer individually and export map as new PDF  for LYR in LYR_list_MXD:         LYR.visible = True         output_PDF = OutputPDFFolder + "\\" + str(LYR) + ".pdf"         arcpy.mapping.ExportToPDF(MXD, output_PDF)         LYR.visible = False         MXD.save()

Any suggestions would be greatly appreciated.

Thanks

-Zack

Re: arcpy visible not working

MichaelVolz — Tue, 04 Feb 2014 13:17:45 GMT

Zack:

Might you need to re-populate LYR_list_MXD by running the line:

LYR_list_MXD = arcpy.mapping.ListLayers(MXD,"*_env*",DF)

again, after you saved the file.

Re: arcpy visible not working

ZackBartlett — Tue, 04 Feb 2014 13:34:07 GMT

Thanks Michael, but that didn't do the trick either. Still getting blank PDFs.

Re: arcpy visible not working

MichaelVolz — Tue, 04 Feb 2014 14:00:09 GMT

Can you try printing out the lyr name in the list to make sure it is getting populated correctly in your second loop?

Re: arcpy visible not working

JoshuaChisholm — Tue, 04 Feb 2014 14:06:01 GMT

Hello Zack,

I have a few quick questions/suggestions.
1) Are all the layers in the same extent? Or should you be zooming to the layers before exporting? (see here)
2) Do you have multiple dataframes? If so, make sure the right one is active. (you can use this: mxd.activeView = df.name)
3) Sometimes an active refresh helps (arcpy.RefreshActiveView())

Good luck!
~Josh

Re: arcpy visible not working

ZackBartlett — Tue, 04 Feb 2014 14:13:08 GMT

Can you try printing out the lyr name in the list to make sure it is getting populated correctly in your second loop?

I tried adding a print LYR command. It works as it should.

Re: arcpy visible not working

ZackBartlett — Tue, 04 Feb 2014 14:16:17 GMT

Hello Zack,

I have a few quick questions/suggestions.
1) Are all the layers in the same extent? Or should you be zooming to the layers before exporting? (see here)
2) Do you have multiple dataframes? If so, make sure the right one is active. (you can use this: mxd.activeView = df.name)
3) Sometimes an active refresh helps (arcpy.RefreshActiveView())

Good luck!
~Josh

Josh,

Thanks for your suggestions.

1. The layers cover close to the same extent. It isn't a matter of my data frame being in the wrong place. In fact, I have a simple base layer turned on in the MXD, and that exports fine.

2. The MXD contains only one dataframe.

3. The RefreshActiveView didn't make a difference.

Re: arcpy visible not working

ZackBartlett — Sun, 12 Dec 2021 16:12:13 GMT

I made a few additions to the script based on some of your suggestions to see if things were working properly. It only served to confuse me more. See below.

LYR_list_MXD = arcpy.mapping.ListLayers(MXD,"*_env*",DF)

for LYR in LYR_list_MXD:
        LYR.visible = False

MXD.save()

# Turn on each layer individualy and export map as new PDF

for LYR in LYR_list_MXD:
        print "1." + str(LYR)
        print "2." + str(LYR.visible)
        LYR.visible = True
        print "3." + str(LYR.visible)
        MXD.save()
        arcpy.RefreshActiveView()
        output_PDF = OutputPDFFolder + "\\" + str(LYR) + ".pdf"
        arcpy.mapping.ExportToPDF(MXD, output_PDF)
        print "4." + str(LYR.visible)
        LYR.visible = False
        print "5." + str(LYR.visible)
        arcpy.RefreshActiveView()
        MXD.save()

As you can see, I have a few print functions in my second for loop. My output is as follows:

1.merge_tdiss_final_buff_env.lyr
2.False
3.True
4.True
5.False

This, of course, repeats for every item in LYR_list_MXD, but I just copied a single one.

- It prints the layer name correctly.
- It prints that the layer isn't visible (as I turned them all off in my first for loop).
- I then turn the layer on and print to make sure it is visible, and it is.
- I then save, refresh, export the map
- print to see if it's still visible
- Turn the layer off, refresh, and save.

But my PDFs are still blank.

Re: arcpy visible not working

JoshuaChisholm — Tue, 04 Feb 2014 15:13:52 GMT

If it's any consolation, your script is working well on my machine (produces the correct non-blank PDFs).

Have you triple checked your mxd to make sure the extent is in right spot (in layout view)?

Re: arcpy visible not working

MichaelVolz — Tue, 04 Feb 2014 15:19:56 GMT

What version of ArcMap is installed on the machine where it is working correctly?

What version of ArcMap is installed on the machine where it is not working correctly?

Re: arcpy visible not working

ZackBartlett — Tue, 04 Feb 2014 15:29:14 GMT

What version of ArcMap is installed on the machine where it is working correctly?

What version of ArcMap is installed on the machine where it is not working correctly?

Non-working machine: 10.1, with SP1.

Re: arcpy visible not working

JoshuaChisholm — Tue, 04 Feb 2014 16:23:26 GMT

Working machine: 10.1, with SP0.

Note: I did remove the MXD.save() lines, but that shouldn't make a difference.

Re: arcpy visible not working

ZackBartlett — Sat, 11 Dec 2021 10:45:13 GMT

UPDATE:

I opened my MXD and ran the code below in the python window.

>>> import arcpy
>>> MXD = arcpy.mapping.MapDocument("CURRENT")
>>> DF = arcpy.mapping.ListDataFrames(MXD, "Layers")[0]
>>> LYR_list = arcpy.mapping.ListLayers(MXD, "*_env*",DF)
>>> for lyr in LYR_list:
...     lyr.visible = True
...     output_PDF = r"T:\JOBS\123110494\gis_data\spatial_data\project_discipline\modeling\scripts\ZB\PDF\\" + str(lyr) + ".pdf"
...     arcpy.mapping.ExportToPDF(MXD, output_PDF)
...     lyr.visible = False
...     MXD.save()
...

This time it worked fine. All my PDFs were exported showing the correct layer.

Re: arcpy visible not working

ZackBartlett — Tue, 04 Feb 2014 16:37:22 GMT

Working machine: 10.1, with SP0.

Note: I did remove the MXD.save() lines, but that shouldn't make a difference.

Joshua,

Turns out it does make a difference!!

I tried running the script with only a single MXD.save() in my code, right at the end, outside of all for loops, and it worked!

I have no idea why, but if you or anyone else out there knows why this would happen, I'd love to know the answer.

Thanks, Joshua, you solved this one without even knowing it!

-Zack

Re: arcpy visible not working

JoshuaChisholm — Tue, 04 Feb 2014 16:45:49 GMT

Geez, sorry. I should have mentioned that to start with.

I'd also be very interested to know why that made a difference.

I'm happy it worked out for you!

Re: arcpy visible not working

BradPosthumus — Sat, 11 Dec 2021 10:45:16 GMT

Joshua,

I tried running the script with only a single MXD.save() in my code, right at the end, outside of all for loops, and it worked!

-Zack

Wow, I wouldn't have expected that! But now that you mention it, it seems like every time you use MXD.save() the changes to the MXD get lost in limbo until you delete the MXD object. But that means you need to re-open the MXD again, which isn't ideal and your code would then look something like this:

MXD = arcpy.mapping.MapDocument(MXD_file)
DF = arcpy.mapping.ListDataFrames(MXD)[0]
LYR_list_MXD = arcpy.mapping.ListLayers(MXD,"*_env*",DF)
LYR_count = len(LYR_list_MXD)
for LYR in LYR_list_MXD:
    LYR.visible = False

MXD.save()
del MXD

# Turn on each layer individually and export map as new PDF

for i in range(LYR_count):
    # now you need to reopen the MXD...
    MXD = arcpy.mapping.MapDocument(MXD_file)
    DF = arcpy.mapping.ListDataFrames(MXD)[0]
    LYR = arcpy.mapping.ListLayers(MXD,"*_env*",DF)
    LYR.visible = True
    output_PDF = OutputPDFFolder + "\\" + str(LYR) + ".pdf"
    arcpy.mapping.ExportToPDF(MXD, output_PDF)
    LYR.visible = False
    MXD.save()
    del MXD

Note I've only tested this when running a script outside of ArcMap and not using "CURRENT" as your map document.