topic Re: Is there something wrong with lyr.replaceDataSource ? in Python Questions

Is there something wrong with lyr.replaceDataSource ?

AnnaBuchheit — Mon, 12 Mar 2018 20:47:58 GMT

I have been racking my brain trying to figure out why I can't get this simple code to execute properly. I am trying to replace Datasources for numerous layers in numerous mxd's. I really don't want to do this manually! Essentially, a new file gdb has been created in a new folder with renamed feature classes. Feature class names were changed to simplify other geoprocessing scripts. Now I need to re-link the datasources to the new datasets.

I have a working code: it walks through a directory, it lists mxd's by file name, it finds layers and prints their names and finally saves the mxd. there are no bugs; however, when I open the mxd, the datasource has not changed. The script runs through the lyr.replaceDataSource but does not actually replace the datasource. I have used the validate {FALSE} parameter and still no luck! I am not a whiz when it comes to python, but I thought this was a pretty straight forward script.

Does anyone see what I am doing wrong? What am I overlooking?

Re: Is there something wrong with lyr.replaceDataSource ?

RebeccaStrauch__GISP — Mon, 12 Mar 2018 21:00:54 GMT

do you have a

mxd.save()

anywhere in your script?

Edit: never mind...just saw it. But I thik it needs to be indented. Looks like you would only be saving the last mxd changed. But haven't looked closely at your code (short on time).

I have an addin if you are interested in using, or just reviewing the code.

/blogs/myAlaskaGIS/2015/08/31/python-addin-for-data-inventory-and-broken-link-repair?sr=search&searchId=3771fb19-dc97-4e17-b98f-adf107ab692b&searchIndex=2‌

Re: Is there something wrong with lyr.replaceDataSource ?

AnnaBuchheit — Tue, 13 Mar 2018 18:51:01 GMT

Thank you for the reply,

I have tested the code using only one mxd and still nothing changes. I'm stumped!

Re: Is there something wrong with lyr.replaceDataSource ?

MichaelVolz — Tue, 13 Mar 2018 18:58:06 GMT

I think you might need a mxd.SaveACopy and then use file manipulation to rename the newly created mxd to the original mxd name.

Re: Is there something wrong with lyr.replaceDataSource ?

DanPatterson_Retired — Tue, 13 Mar 2018 19:01:26 GMT

Anna

From the help....http://desktop.arcgis.com/en/arcmap/latest/analyze/arcpy-mapping/updatingandfixingdatasources.htm

This seems to be used... worth a whirl

mxd.saveACopy(r"C:\Project\Project2.mxd")

del mxd

In the future, actual pop the code in using syntax highlighting instead of an image, it might help if people want to actually

try it without retyping

Code Formatting... the Basics ++

Re: Is there something wrong with lyr.replaceDataSource ?

AnnaBuchheit — Wed, 14 Mar 2018 00:06:20 GMT

Thanks for the tip Re: inserting code... this is my first post

Re: Is there something wrong with lyr.replaceDataSource ?

AnnaBuchheit — Wed, 14 Mar 2018 00:06:45 GMT

thanks, I'll give it a try

Re: Is there something wrong with lyr.replaceDataSource ?

RandyBurton — Wed, 14 Mar 2018 02:22:23 GMT

Wondering about line 12 in your script:

for lyr in arcpy.mapping.List(mxd):‍

Should it be (ListLayers):

for lyr in arcpy.mapping.ListLayers(mxd):‍

Re: Is there something wrong with lyr.replaceDataSource ?

MichaelVolz — Wed, 14 Mar 2018 13:38:51 GMT

If you have multiple dataframes in your mxd, you will need to loop through them as well, as I believe the current code will only resource layers in the active dataframe. Not sure this applies to you, but something to consider.

Re: Is there something wrong with lyr.replaceDataSource ?

AnnaBuchheit — Sat, 11 Dec 2021 10:37:05 GMT

Thanks for the suggestions, now that I know how to insert code I'll show what I've tested out.

first of all using the {False} parameter has shown some progress! the code works....sort of. So far it is changing the folder location, the FGDB name, and the feature class name but not the feature dataset name.

here is the test code:

for lyr in arcpy.mapping.ListLayers(mxd):
     if lyr.supports("DATASOURCE"):
          if lyr.dataSource == r"L:\Data\CFX_2016_160214\GDB\CFX_2016.gdb\CFX_IFS_Working_16\AA_Points":
              lyr.replaceDataSource(r"L:\Data\CFX_2018_180214\gdb\CFX_2018.gdb\IFS_Working","FILEGDB_WORKSPACE","BB_Points", False)
              lyr.name = "BB_Points"
                    print lyr.dataSource
               ‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

and this is the output:

L:\Data\CFX_2018_180214\gdb\CFX_2018.gdb\CFX_IFS_Working_16\BB_Points‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Is this something that the lyr.replaceDataSource() can't do?

if I use the {True} parameter, I don't get past line 4 and I think that is due to the fact that I have included the dataset name in the path. How do I navigate into feature datasets?

thanks again!

Re: Is there something wrong with lyr.replaceDataSource ?

AnnaBuchheit — Thu, 15 Mar 2018 21:03:38 GMT

thanks,

no I only have one dataframe, but I do have multiple Feature Datasets

...I have added to my thread below...

Re: Is there something wrong with lyr.replaceDataSource ?

RandyBurton — Sat, 11 Dec 2021 10:37:08 GMT

With version 10.5, I was having some luck using something like:

lyr.replaceDataSource(r"L:\Data\CFX_2018_180214\gdb\CFX_2018.gdb","FILEGDB_WORKSPACE","BB_Points", True)

# omitting 'IFS_Working' from the path
# L:\Data\CFX_2018_180214\gdb\CFX_2018.gdb\IFS_Working\BB_Points‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

It seems strange that the feature class name would be omitted from the path or layer name. This could cause problem if other feature classes in the file geodatabase contain an identical feature name. Could it be a bug?

Replacing the data source did not change the layer name, so that had to be set. Also, the old symbology was retained, so that may also need to be corrected.

Also, I was working inside ArcMap's Python window and would use arcpy.RefreshActiveView to update the map.

Re: Is there something wrong with lyr.replaceDataSource ?

AnnaBuchheit — Fri, 16 Mar 2018 20:22:51 GMT

thank you,

I used your suggestions for removing the "IFS_Working" from the path, as well as adding "NONE" as the workspace (as it does not change).

Now the code automatically sources it to the correct dataset!

most of my trouble came from thinking too much (haha!), and mapping the path too far.

Thanks to everyone for the guidance I am but a greenhorn teaching myself...