topic Re: arcpy.da.InsertCursor help please in Python Questions

arcpy.da.InsertCursor help please

TonyAlmeida — Mon, 10 Feb 2014 21:08:43 GMT

I am trying to create a script that will create a new point feature to a point feature class, but also add the x, y coordinets to "X_Coord" and "Y_Coord" fields. The following code sort of works but only populates the "X_Coord" field. I can't seem to get it to populate the "Y_Coord" field.

works but only populates the "X_Coord" field.

import arcpy import pythonaddins import os from arcpy import env  class Add_points(object):     """Implementation for AddPoints_addin.Add_points (Tool)"""     def __init__(self):         self.enabled = True         self.cursor = 3 # Can set to "Line", "Circle" or "Rectangle" for interactive shape drawing and to activate the onLine/Polygon/Circle event sinks.     def onMouseDownMap(self, x, y, button, shift):         fc = "points"         workspace = r"C:\Temp\test.mdb"         arcpy.env.overwriteOutput = True          # Start an edit session. Must provide the worksapce.         edit = arcpy.da.Editor(workspace)          # Edit session is started without an undo/redo stack for versioned data         #  (for second argument, use False for unversioned data)         edit.startEditing(True)          # Start an edit operation         edit.startOperation()                  mxd = arcpy.mapping.MapDocument("Current")         df = arcpy.mapping.ListDataFrames(mxd, "Layers")[0]         lyr = arcpy.mapping.ListLayers(mxd, "points")[0]          #message = "Your mouse clicked:" + str(x) + ", " + str(y)         #pythonaddins.MessageBox(message, "My Coordinates")                           point = arcpy.Point(x, y)         pointGeometry = arcpy.PointGeometry(point)         row_value = ((x, y))         cursor = arcpy.da.InsertCursor(fc, ("X_Coord", "SHAPE@XY"))         cursor.insertRow(row_value)         """ Create a copy of the PointGeometry objects, by using pointGeometry  """         """  as input to the CopyFeatures tool. """         arcpy.CopyFeatures_management(pointGeometry, r"C:\Temp\test.mdb")          # Stop the edit operation.         edit.stopOperation()          # Stop the edit session and save the changes         edit.stopEditing(True)           arcpy.RefreshActiveView()         pass

I have tried the following but nothing happens, no point feature is created and the "X_Coord" and "Y_Coord" fields are not populated.

import arcpy import pythonaddins import os from arcpy import env  class Add_points(object):     """Implementation for AddPoints_addin.Add_points (Tool)"""     def __init__(self):         self.enabled = True         self.cursor = 3 # Can set to "Line", "Circle" or "Rectangle" for interactive shape drawing and to activate the onLine/Polygon/Circle event sinks.     def onMouseDownMap(self, x, y, button, shift):         fc = "points"         workspace = r"C:\Temp\test.mdb"         arcpy.env.overwriteOutput = True          # Start an edit session. Must provide the worksapce.         edit = arcpy.da.Editor(workspace)          # Edit session is started without an undo/redo stack for versioned data         #  (for second argument, use False for unversioned data)         edit.startEditing(True)          # Start an edit operation         edit.startOperation()                  mxd = arcpy.mapping.MapDocument("Current")         df = arcpy.mapping.ListDataFrames(mxd, "Layers")[0]         lyr = arcpy.mapping.ListLayers(mxd, "points")[0]          #message = "Your mouse clicked:" + str(x) + ", " + str(y)         #pythonaddins.MessageBox(message, "My Coordinates")          Fields = ["X_Coord", "Y_Coord", "SHAPE@XY"]                          point = arcpy.Point(x, y)         pointGeometry = arcpy.PointGeometry(point)         row_value = ((x, y))         cursor = arcpy.da.InsertCursor(fc, (Fields))         cursor.insertRow(row_value)         """ Create a copy of the PointGeometry objects, by using pointGeometry  """         """  as input to the CopyFeatures tool. """         arcpy.CopyFeatures_management(pointGeometry, r"C:\Temp\test.mdb")          # Stop the edit operation.         edit.stopOperation()          # Stop the edit session and save the changes         edit.stopEditing(True)           arcpy.RefreshActiveView()         pass

and if possible i would like it to populate an auto sequential number based on the last highest number. The field i need the sequential number is a field called the Address_ID field.

Re: arcpy.da.InsertCursor help please

JakeSkinner — Sat, 11 Dec 2021 09:14:56 GMT

Hi Tony,

Since you are working with a Personal Geodatabase, you will not need to start an edit session. Try the following:

def onMouseDownMap(self, x, y, button, shift):
        arcpy.env.workspace = r"C:\temp\test.mdb"
        fc = "Point"

        list = []
        with arcpy.da.SearchCursor(fc, ["Address_ID"]) as cursor:
            for row in cursor:
                list.append(row[0])

        del cursor
        
        list.sort()
        Address_ID = list[-1] + 1

        row_values = [(x, y, (x, y), Address_ID)]
        cursor = arcpy.da.InsertCursor(fc, ["X_Coord", "Y_Coord", "SHAPE@XY", "ADDRESS_ID"])

        for row in row_values:
            cursor.insertRow(row)

        del cursor

        arcpy.RefreshActiveView()

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Sat, 11 Dec 2021 09:14:59 GMT

JSkinns3, Thanks for your repose.

I have tried the following with out any success...
No point was created an X & Y field were not updated and AddressID was not populated.
I noticed that there was no arcpy.pointgeometry, Don't i need this to create a point feature?
On the Address ID field i need the auto sequential to start with CC and be 5 numberic numbers,
example: CC02336

def onMouseDownMap(self, x, y, button, shift):
        
        arcpy.env.overwriteOutput = True

        # Start an edit session. Must provide the worksapce.
        edit = arcpy.da.Editor(workspace)

        # Edit session is started without an undo/redo stack for versioned data
        #  (for second argument, use False for unversioned data)
        edit.startEditing(True)

        # Start an edit operation
        edit.startOperation()
        
        fc = "points"
        arcpy.env.workspace = r"C:\Temp\test.mdb"

        list = []
        with arcpy.da.SearchCursor(fc, ["Address_ID"]) as cursor:
            for row in cursor:
                list.append(row[0])

        del cursor
        
        list.sort()
        Address_ID = list[-1] + 1

        row_values = [(x, y, (x, y), Address_ID)]
        cursor = arcpy.da.InsertCursor(fc, ["X_Coord", "Y_Coord", "SHAPE@XY", "ADDRESS_ID"])

        for row in row_values:
            cursor.insertRow(row)

        del cursor

        arcpy.RefreshActiveView()
              
        # Stop the edit operation.
        edit.stopOperation()

        # Stop the edit session and save the changes
        edit.stopEditing(True)
        pass

Re: arcpy.da.InsertCursor help please

JakeSkinner — Tue, 11 Feb 2014 15:50:24 GMT

Open up the Python window in ArcMap and then execute the tool. Any errors reported?

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Sat, 11 Dec 2021 09:15:01 GMT

duh that would help wouldn't...my bad.
I get this error.

Traceback (most recent call last):
  File "C:\Users\talmeida\AppData\Local\ESRI\Desktop10.1\AssemblyCache\{BB229966-100D-4482-A3FE-B298BD262597}\AddPoints_addin.py", line 30, in onMouseDownMap
    for row in cursor:
RuntimeError: Too few parameters. Expected 1.

with this code

import arcpy
import pythonaddins
import os
from arcpy import env

class Add_points(object):
    """Implementation for AddPoints_addin.Add_points (Tool)"""
    def __init__(self):
        self.enabled = True
        self.cursor = 3 # Can set to "Line", "Circle" or "Rectangle" for interactive shape drawing and to activate the onLine/Polygon/Circle event sinks.
    def onMouseDownMap(self, x, y, button, shift):
        
        arcpy.env.overwriteOutput = True

        # Start an edit session. Must provide the worksapce.
        edit = arcpy.da.Editor(env.workspace)

        # Edit session is started without an undo/redo stack for versioned data
        #  (for second argument, use False for unversioned data)
        edit.startEditing(True)

        # Start an edit operation
        edit.startOperation()

        fc = "points"
        arcpy.env.workspace = r"C:\Temp\test.mdb"
        
        list = []
        with arcpy.da.SearchCursor(fc, ["Address_ID"]) as cursor:
            for row in cursor:
                list.append(row[0])

        del cursor
        
        list.sort()
        Address_ID = list[-1] + 1

        row_values = [(x, y, (x, y), Address_ID)]
        cursor = arcpy.da.InsertCursor(fc, ["X_Coord", "Y_Coord", "SHAPE@XY", "ADDRESS_ID"])

        for row in row_values:
            cursor.insertRow(row)

        del cursor

              
        # Stop the edit operation.
        edit.stopOperation()

        # Stop the edit session and save the changes
        edit.stopEditing(True)

        arcpy.RefreshActiveView()
        pass

Re: arcpy.da.InsertCursor help please

JakeSkinner — Tue, 11 Feb 2014 17:28:32 GMT

Do you have the field 'Address_ID' in the feature class?

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Sat, 11 Dec 2021 09:15:04 GMT

actually it's AddressID. my bad...

I mad the changes to replace the Address_ID to AddressID and i am getting the following

Traceback (most recent call last):
  File "C:\Users\talmeida\AppData\Local\ESRI\Desktop10.1\AssemblyCache\{BB229966-100D-4482-A3FE-B298BD262597}\AddPoints_addin.py", line 36, in onMouseDownMap
    AddressID = list[-1] + 1
TypeError: coercing to Unicode: need string or buffer, int found

Re: arcpy.da.InsertCursor help please

JakeSkinner — Sat, 11 Dec 2021 09:15:07 GMT

Since AddressID is a text field, you will have to convert it to an int, add 1, then convert it back to a string. Replace:

AddressID = list[-1] + 1

with:

AddressID = int(list[-1].strip('CC0')) + 1
AddressID = 'CC0' + str(AddressID)

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Tue, 11 Feb 2014 20:11:21 GMT

interesting i was going about it the wrong way.

The auto sequential ends at CC09, even after adding more points the rest are CC09.
With the current code the AddressID field is populated like this CC01, CC02.
I need them have leading zeros of five like so. They don't all start at CC00001
CC00001, CC00002, CC00010, CC00123, CC01234, CC56560
Is this possible and if so how?

Thanks again for all your help!

Re: arcpy.da.InsertCursor help please

JakeSkinner — Tue, 11 Feb 2014 20:29:56 GMT

In your case, you need every added point to be greater than the largest AddressID, i.e. CC56560? If that is the case, what is the larget AddressID?

Or, is this tool going to be used for multiple feature classes, and the AddressID varies? i.e. CC00100 is the largest for one feature class, CC032232 is the largest for another feature class

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Tue, 11 Feb 2014 21:31:51 GMT

This tool would only be used for one feature class. yes i need every newly add point to generate a new number based off the last highest number in the AddressID field. The current largest number is CC18417.
I was thinking that some how i would sort the AddressID field to get the highest value, then update the values
from the last highest AddressID.

Re: arcpy.da.InsertCursor help please

JakeSkinner — Sat, 11 Dec 2021 09:15:10 GMT

What you need to do is strip 'CC' from the AddressID and then convert the value to an integer before appending it to the list. You can then sort the list, select the last value, add one and then append 'CC' back to this value. Ex:

def onMouseDownMap(self, x, y, button, shift):   
    arcpy.env.workspace = r"C:\Temp\test.mdb"
    fc = "points"

    list = []
    with arcpy.da.SearchCursor(fc, ["AddressID"]) as cursor:
        for row in cursor:
            list.append(int(row[0].strip("CC")))        
    del cursor

    list.sort()
    AddressID = list[-1] + 1
    AddressID = 'CC' + str(AddressID)

    row_values = [(x, y, (x, y), AddressID)]
    cursor = arcpy.da.InsertCursor(fc, ["X_Coord", "Y_Coord", "SHAPE@XY", "ADDRESSID"])

    for row in row_values:
        cursor.insertRow(row)
    del cursor

    arcpy.RefreshActiveView()

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Sat, 11 Dec 2021 09:15:12 GMT

The only issues with stripping the "CC" from the AddressID field is that there are other alphabetic letters like "NA", "CA" but i don't do anything with those, i am just interested in the attributes with "CC". I should have mentioned that before, my bad. but that's why i was thinking of maybe doing to the cursor twice, first to sort and get the highest AddressID value then to populate the AddressID.
I saw a post a while back that had something similar to what i am talking about but of course i can't find now.

I tested the code you provided and i noticed that this error, i believe it was because i had some points that were NULL in the AddressID field.

Traceback (most recent call last):
  File "C:\Users\talmeida\AppData\Local\ESRI\Desktop10.1\AssemblyCache\{BB229966-100D-4482-A3FE-B298BD262597}\AddPoints_addin.py", line 31, in onMouseDownMap
    list.append(int(row[0].strip("CC")))
ValueError: invalid literal for int() with base 10: ''

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Wed, 12 Feb 2014 17:23:19 GMT

Is there a way to by pass the existing feature with Null in the AddressID?
How do i by pass the features with NA and CC?

Re: arcpy.da.InsertCursor help please

JakeSkinner — Sat, 11 Dec 2021 09:15:15 GMT

You can add an IF statement. Ex:

with arcpy.da.SearchCursor(fc, ["AddressID"]) as cursor:
        for row in cursor:
            if "CC" in row[0]:
                list.append(int(row[0].strip("CC")))        
del cursor

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Sat, 11 Dec 2021 09:15:18 GMT

JSkinns i have applied you code but i am still not able to get passed the Null or empty AddressID feature.
as you can see on the pic i have attached the last point feature didn't have anything in the AddressID field.
I would like it to bypass this and continue populate the AddressID for the next feature.

Current code.

import arcpy
import pythonaddins
import os
from arcpy import env

class Add_points(object):
    """Implementation for AddPoints_addin.Add_points (Tool)"""
    def __init__(self):
        self.enabled = True
        self.cursor = 3 # Can set to "Line", "Circle" or "Rectangle" for interactive shape drawing and to activate the onLine/Polygon/Circle event sinks.
    def onMouseDownMap(self, x, y, button, shift):
        
        arcpy.env.overwriteOutput = True

        # Start an edit session. Must provide the worksapce.
        edit = arcpy.da.Editor(env.workspace)

        # Edit session is started without an undo/redo stack for versioned data
        #  (for second argument, use False for unversioned data)
        edit.startEditing(True)

        # Start an edit operation
        edit.startOperation()

        fc = "points"
        arcpy.env.workspace = r"C:\Temp\test.mdb"

        list = []
        with arcpy.da.SearchCursor(fc, ["AddressID"]) as cursor:
            for row in cursor:
                list.append(int(row[0].strip("CC")))        
        del cursor

        list.sort()
        AddressID = list[-1] + 1
        AddressID = 'CC' + str(AddressID)

        row_values = [(x, y, (x, y), AddressID)]
        cursor = arcpy.da.InsertCursor(fc, ["X_Coord", "Y_Coord", "SHAPE@XY", "ADDRESSID"])

        for row in row_values:
            cursor.insertRow(row)
        del cursor

        arcpy.RefreshActiveView()
        
        # Stop the edit operation.
        edit.stopOperation()

        # Stop the edit session and save the changes
        edit.stopEditing(True)        
        pass

Re: arcpy.da.InsertCursor help please

JakeSkinner — Wed, 12 Feb 2014 19:41:18 GMT

Try the following:

with arcpy.da.SearchCursor(fc, ["AddressID"]) as cursor:     for row in cursor:         try:             if "CC" in row[0]:                 list.append(int(row[0].strip("CC")))         except TypeError:             pass del cursor

Re: arcpy.da.InsertCursor help please

TonyAlmeida — Wed, 12 Feb 2014 21:28:04 GMT

JSkinns that worked perfectly!
Now if i can only get to work with SQL express database.
I posted my problem here but i haven't had a response.
http://forums.arcgis.com/threads/102661-Setting-workspace-Q

thank you so much.