topic Re: ArcPy in Python Questions

ArcPy

RusselKlueg — Wed, 24 Jun 2015 13:45:39 GMT

Hey all,

I've got an arcpy question for you. I'm still new to python as well but I think i have a decent handle on it. But i'm not sure why this script isn't working. It's pretty basic but I keep getting an error. Can someone point out the issue for me? I'd really appreciate it.

import arcpy

mxd = arcpy.mapping.MapDocument(r'C:\Users\JOC-001\Documents\GIS\HSIP\Infrastructure\HSIP_Gold_2015_Infrastructure2.mxd')

layers = arcpy.mapping.ListLayers(mxd)

for lyr in layers:

arcpy.SelectLayerByLocation_management(lyr, "WITHIN_A_DISTANCE", r"C:\Users\JOC-001\Documents\ArcGIS\Default.gdb\Illinois", "50 Miles", "NEW_SELECTION")

arcpy.FeatureClassToFeatureClass_conversion(lyr, r'C:\Users\JOC-001\Documents\GIS\HSIP\IL_Infrastructure2015', lyr+'.shp')

And the error i'm receiving

Traceback (most recent call last):

File "C:\Users\JOC-001\Desktop\ArcGIS.py", line 7, in <module>

arcpy.SelectLayerByLocation_management(lyr, "WITHIN_A_DISTANCE", r"C:\Users\JOC-001\Documents\ArcGIS\Default.gdb\Illinois", "50 Miles", "NEW_SELECTION")

File "C:\Program Files (x86)\ArcGIS\Desktop10.2\arcpy\arcpy\management.py", line 6812, in SelectLayerByLocation

raise e

ExecuteError: Failed to execute. Parameters are not valid.

ERROR 000840: The value is not a Feature Layer.

ERROR 000840: The value is not a Raster Catalog Layer.

ERROR 000840: The value is not a Mosaic Layer.

Failed to execute (SelectLayerByLocation).

Re: ArcPy

DanPatterson_Retired — Wed, 24 Jun 2015 13:51:16 GMT

I would add some print statements since it appears that the full path to the files, either input or output, are not being found. As a suggestion, it is useful to do testing in a path much shorter than the one you are currently using. Is there any reason you have to use r"C:\Users\JOC-001\Documents\ArcGIS\Default.gdb rather than something nicer like r"C:\Test\Test.gdb" it makes code debugging so much easier

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 13:56:21 GMT

I could be mistake but the only thing I'm pulling from the Default GDB is the one shapefile that i'm using to compare files to. Correct me if i'm mistaken? And i am out putting as a test to the file that once I get this script working I'll purge the file and start using the actual MXD that I need this script to process. The current one is just a subset of the data from the original.

Re: ArcPy

XanderBakker — Wed, 24 Jun 2015 13:58:34 GMT

Do you have grouplayers in your mxd? If so this will produce errors since it will also be included in the list of layers.

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 13:58:59 GMT

I also just verified my file paths again. they are correct. Any other suggestions?

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 14:00:37 GMT

I do have group layers. Thats why I scripted it the way I did. Any chance you could advise me on how to successfully iterate though them? I see what you mean though... I did a "for lyr in layers: print lyr and see why it's causing the error.

Re: ArcPy

SepheFox — Wed, 24 Jun 2015 14:01:58 GMT

Are you positive that C:\Users\JOC-001\Documents\ArcGIS\Default.gdb\Illinois exists, is a valid input, and is in the same coordinate system as your input layer?

Re: ArcPy

XanderBakker — Sat, 11 Dec 2021 08:38:32 GMT

A group layer cannot be converted to shapefile. You will have to exclude them.

Maybe this:

import arcpy
mxd = arcpy.mapping.MapDocument(r'C:\Users\JOC-001\Documents\GIS\HSIP\Infrastructure\HSIP_Gold_2015_Infrastructure2.mxd')

layers = arcpy.mapping.ListLayers(mxd)

for lyr in layers:
    if lyr.isFeatureLayer:
        arcpy.SelectLayerByLocation_management(lyr, "WITHIN_A_DISTANCE", r"C:\Users\JOC-001\Documents\ArcGIS\Default.gdb\Illinois", "50 Miles", "NEW_SELECTION")
        arcpy.FeatureClassToFeatureClass_conversion(lyr, r'C:\Users\JOC-001\Documents\GIS\HSIP\IL_Infrastructure2015', lyr+'.shp')

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 14:10:09 GMT

Ok i fixed that but i'm still getting the error due to the files being in groups. I like Xander Bakker pointed out.

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 14:12:24 GMT

Right I knew that I just didn't think about it iterating the actual group too. It was a silly oversight on my part:/

Re: ArcPy

WesMiller — Wed, 24 Jun 2015 14:13:30 GMT

Try using "print lyr.name" under "for lyr in layers:" to see if you are getting any done.

Re: ArcPy

RusselKlueg — Sat, 11 Dec 2021 08:38:35 GMT

So it's close I think. I had to fix the FC2FC a bit more but now i'm getting this error that provides no help at all 😕

Runtime error Traceback (most recent call last): File "<string>", line 9, in <module> File "c:\program files (x86)\arcgis\desktop10.2\arcpy\arcpy\conversion.py", line 1675, in FeatureClassToFeatureClass raise e ExecuteError: ERROR 999999: Error executing function. Failed to execute (FeatureClassToFeatureClass).

import arcpy 
mxd = arcpy.mapping.MapDocument(r'C:\Users\JOC-001\Documents\GIS\HSIP\Infrastructure\HSIP_Gold_2015_Infrastructure2.mxd') 

layers = arcpy.mapping.ListLayers(mxd) 

for lyr in layers: 
    if lyr.isFeatureLayer: 
        arcpy.SelectLayerByLocation_management(lyr, "WITHIN_A_DISTANCE", r"C:\Users\JOC-001\Documents\ArcGIS\Default.gdb\Illinois", "50 Miles", "NEW_SELECTION") 
        arcpy.FeatureClassToFeatureClass_conversion(lyr, r'C:\Users\JOC-001\Documents\GIS\HSIP\IL_Infrastructure2015', str(lyr))

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 14:29:27 GMT

Agriculture\Animal Aquaculture Facilities

Runtime error Traceback (most recent call last): File "<string>", line 10, in <module> File "c:\program files (x86)\arcgis\desktop10.2\arcpy\arcpy\conversion.py", line 1675, in FeatureClassToFeatureClass raise e ExecuteError: ERROR 999999: Error executing function. Failed to execute (FeatureClassToFeatureClass).

This is what printing before the operation gives me. I think it has to do with how the layer A) has the group name attached. I'll need to parse that out. B) has spaces in the name, I'll need to parse that out as well i think.

Re: ArcPy

WesMiller — Sat, 11 Dec 2021 08:38:38 GMT

if lyr.isGroupLayer:
     pass
else:
     print lyr.name

Re: ArcPy

XanderBakker — Sat, 11 Dec 2021 08:38:40 GMT

"Agriculture\Animal Aquaculture Facilities" is not a valid output name. The name combines the grouplayer name and the name of the layer,

You could use this:

import arcpy
import os
mxd = arcpy.mapping.MapDocument(r'C:\Users\JOC-001\Documents\GIS\HSIP\Infrastructure\HSIP_Gold_2015_Infrastructure2.mxd')

layers = arcpy.mapping.ListLayers(mxd)

for lyr in layers:
    if lyr.isFeatureLayer:
        arcpy.SelectLayerByLocation_management(lyr, "WITHIN_A_DISTANCE", r"C:\Users\JOC-001\Documents\ArcGIS\Default.gdb\Illinois", "50 Miles", "NEW_SELECTION")
        out_name = "{0}.shp".format(os.path.split(lyr)[-1])
        print out_name
        arcpy.FeatureClassToFeatureClass_conversion(lyr, r'C:\Users\JOC-001\Documents\GIS\HSIP\IL_Infrastructure2015', out_name)

Most important is to know that the name of the layer might not be valid as a file name.

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 14:51:28 GMT

i had to tweak it just a little for the output to work on mine... but you sir are a wizard

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 14:52:02 GMT

I want to thank everyone who helped me! I really appreciate all of you taking the time to help me solve this!!

Re: ArcPy

RusselKlueg — Wed, 24 Jun 2015 14:53:35 GMT

You and Wes Miller were on the same track. I knew that was the issue after adding the print statement but I didnt know that arcpy had an inherent option for dealing with it! You guys are great! Thank you so much!