topic Re: Python toolbox - check for nested group layers, and 2 more ?'s in Python Questions

Python toolbox - check for nested group layers, and 2 more ?'s

Zeke — Sat, 11 Dec 2021 07:33:59 GMT

I have a python toolbox which crawls directories, or optionally a single mxd, and writes out various properties of the layers in them to a csv file, mostly interested in the data source. This works great, except...,.

I check for group layers to skip those. The tool does skip top level group layers, but not group layers nested in other group layers. How can I skip those?
I originally set a default location and file name for the output csv file, which the user can change. This works if the file doesn't already exist, but if it does, that parameter gets a big red X when the tool is run. The file is set to 'w', so I assumed it would just overwrite the existing file. Is it possible to do what I thought would happen?
In the self.description in the __init__ function, I'd like to break the text on different lines and paragraphs. But no matter how many \n's I add, the tool ignores them when run, and collapses the text into one block. Is there a way to accomplish this?

Thanks, relevant code below.

for mxd_path in mxd_list:
    try:
        mxd = arcpy.mapping.MapDocument(mxd_path)
        dflist = arcpy.mapping.ListDataFrames(mxd)

        for df in dflist:
            for lyr in arcpy.mapping.ListLayers(mxd, '', df):
                if not lyr.isGroupLayer:
                    nm = lyr.name
                    ds = '-- X --'
                    if lyr.supports('dataSource'):
                        ds = lyr.dataSource
                    lyr_attributes = [mxd_path, nm, ds]
                    writer.writerow(lyr_attributes)
                else:
                    if not lyr.isGroupLayer:
                        arcpy.AddMessage('\nLayer {0} does not support the dataSource property'.format(nm))
                        unsupported.append(nm)
                        lngnm = lyr.longName
    except Exception as e:
        arcpy.AddError('EXCEPTION: {0}\t{1}\t{2}'.format(mxd_path, lngnm, e))
        continue
    writer.writerow([''])
    del mxd

Re: Python toolbox - check for nested group layers, and 2 more ?'s

RebeccaStrauch__GISP — Wed, 07 Oct 2015 17:06:10 GMT

Greg, for what it's worth, check out my Python addin for data inventory and “broken-link” repair.

I've had to deal with a lot of the same issues you had with groups, etc. To keep my files unique, I append the name with a datetime. I also write out to a .csv and a report, with an option for a FGDB (but never found a reason for it for my broken-link list).

I had some other tools on this toolbar, but decided to simplify is for sharing.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

Zeke — Wed, 07 Oct 2015 17:34:48 GMT

Thanks Rebecca, will take a look after lunch!

Re: Python toolbox - check for nested group layers, and 2 more ?'s

Zeke — Thu, 08 Oct 2015 20:09:51 GMT

Rebecca,

I'm able to use the tools from the toolbox, but the toolbar doesn't appear properly (image below). The tools themselves don't from there either, so it doesn't seem like links to the icon images being broken is the problem. Any ideas? Thanks

Re: Python toolbox - check for nested group layers, and 2 more ?'s

RebeccaStrauch__GISP — Thu, 08 Oct 2015 20:20:04 GMT

Greg, you didn't attach an image to your last reply.

Are you missing the tool buttons on my addin or on yours?

BTW - I'm working on a new version on my addin that exits cleaner if no mxd's are in the olders/subfolders, has better status checking thru procesing (x of y remaining message), now handles FGDB-standalone-tables, and fixes a flukey isCoverage test for my arctic_circle.shp (false positive with "\arc" as part of the name). Just an fyi.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

Zeke — Fri, 09 Oct 2015 12:40:54 GMT

Thanks Rebecca. The icons are showing up today (??), I'll check them out. When you update the addin, you may want to check the tooltip for 2 - Inventory. There are a couple of typos.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

RebeccaStrauch__GISP — Fri, 09 Oct 2015 15:38:49 GMT

Thanks Greg. It doesn't surprise me that there are typos In the help/tooltips, etc. I throw quick notes in and I'm forget to go back and clean things up. I need to go thru to clean things up and add more details. I'm also kind of a hack (vs a hacker) when it comes to scripts....that is, not always pretty, but I just try to get it to work. However, I do try to include many comments (typos and all ). [note...many Geonet typos by me can be blamed on the iPad trying to second guess me....or just bad typing]

I had another tool the was that allowed a global drive change (e.g. 😧 to F:, or 😧 to a UNC) and then ran the broken link list again, but, although this worked, I decided that was a bit too broad a change and could creat new issues. I decided to only include a more controlled version with the fix links (4) script.

I'm not sure how far along with you script, but I had already been thinking about doing a complete mxd TOC inventor (not just broken links), and don't think it would be hard to change 3a to do this. I thought that would be a good addition to the toolbar. Not sure how detailed you were planning to get with your tool, but I'm hoping to add additional functionality to the addin, so if it something you want to share for that, let me know.

(note for those wondering what the 3a, 4, etc that I refer to....that is part on my script name In my addin...make it convenient for me 1) for me to know the order I usually run, and 2) sorts nice in my file-explorer and Wing projects.)

Re: Python toolbox - check for nested group layers, and 2 more ?'s

Zeke — Fri, 09 Oct 2015 19:02:40 GMT

Sure, I'll share my script. I have two versions, one as a plain script tool, one as a python toolbox. I'm not sure how to post or send it, though, other than as an attachment to a post here.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

RebeccaStrauch__GISP — Fri, 09 Oct 2015 22:34:40 GMT

I followed you, so you can send me a direct message with the attachment if you would like, or post it here.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

Zeke — Mon, 12 Oct 2015 12:34:03 GMT

I don't see a way to upload files, either in this box or thr message box. Only options are images or video. I suppose I could copy and paste the code, might be a little long though.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

RebeccaStrauch__GISP — Mon, 12 Oct 2015 14:12:48 GMT

you need to be outside of the Geonet inbox...just open the message in a new tab. When you reply, in the upper right, there should be a "used advanced editor". Select that, and then there should be an attach icon in lower right corner .

to do a direct message, if we follow each other, then there will be a message option for you if you view my profile. There is a pull down version usually if you hover over my avatar too, but I do t see that right now on my device.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

Zeke — Mon, 12 Oct 2015 15:16:26 GMT

Here you go.Didn't see an Advanced Editor on the direct message box.

Re: Python toolbox - check for nested group layers, and 2 more ?'s

RebeccaStrauch__GISP — Mon, 12 Oct 2015 15:24:44 GMT

Thanks. I'll take a look at it later this week.

Sorry for the confusion in the last message. There isn't an attach on the DM. That was if we needed to take it offline with direct emails. (not enough coffee yet for a Monday morning)

Re: Python toolbox - check for nested group layers, and 2 more ?'s

RebeccaStrauch__GISP — Tue, 20 Oct 2015 21:43:18 GMT

Hi Greg,

Unfortunately, I didn't have much luck with your tools. After I fixed the source tot he python script, I ran it thru the Utilities toolbox and it said it ran successfully, but the .csv was never created.

The PyUtilities tool created the .csv file, but never seemed to finish, so I ended up cancelling it.

So unfortunately, I can't use either tool directly, but I do like some of your streamlined coding. Mine tends to get long, so I'm going to look to see if I can swipe any of your code to merge into mine. Thanks for sharing.