topic Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers in Mapping Questions

findAndReplaceWorkspacePaths crashes when mxd contains image layers

DonMcClimans — Sat, 12 Feb 2011 11:47:49 GMT

I am moving a large number of mxd files, and need to update the data sources for various layer files. I have written a script that uses findAndReplaceWorkspacePaths. The script works fine as long as the mxd does not contain an image service layer. If it does contain such a layer, the script crashes. I am not trying to change the path in the image layer, but other layers in that mxd file.

This looks like bug NIM060315 http://resources.arcgis.com/content/nimbus-bug?bugID=TklNMDYwMzE1, except I am not trying to change the image layer itself.

The bug report lists no workarounds. Is there anything I can do? Doing these by hand will be a big undertaking (and error prone).

Thanks

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

DonMcClimans — Sun, 12 Dec 2021 16:38:06 GMT

I figured out how to work around this. You must temporarily remove the imagery layer from the mxd object. Then apply the findAndReplaceWorkspacePaths function(s). And finally restore the imagery layer you removed.

Here is some sample code that temporarily removes any layer with a name that contains "USGS EROS", changes a path, and adds the imagery layer back in.

import arcpy
import os
rootdir = r"C:Your_Root_Folder"
for subdir, dirs, files in os.walk(rootdir):
    for filename in files:
        fullpath = os.path.join(subdir, filename)
        print filename
        if os.path.isfile(fullpath):
            basename, extension = os.path.splitext(fullpath)
            if extension.lower() == ".mxd":
                mxd = arcpy.mapping.MapDocument(fullpath)
                # Temporarily remove the imagery layer(s)
                for df in arcpy.mapping.ListDataFrames(mxd):
                    ImageLayerList = arcpy.mapping.ListLayers(mxd, "*USGS EROS*", df)
                    for lyr in ImageLayerList:
                        arcpy.mapping.RemoveLayer(df, lyr);
                    # Search-and-replace to fix up data source paths.
                    mxd.findAndReplaceWorkspacePaths(r"oldpath", r"newpath", False)
                    # Add the imagery layers back in
                    for lyr in ImageLayerList:
                        arcpy.mapping.AddLayer(df, lyr, "BOTTOM")
                mxd.save()
del lyr
del df
del mxd

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

JeffBarrette — Fri, 15 Apr 2011 17:10:49 GMT

We reproduced this issue an will hopefully be able to address it in the next service pack. Our fix is to prevent web service and image service layers from supporting Layer.dataSource. You can then test to see if a layer supports the Layer.dataSource property before attempting to modify a data source.

If you want to check its status, it is: NIM067149

Thanks!
Jeff

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

GeorgeRogers — Sun, 12 Dec 2021 00:27:54 GMT

import arcpy
import os
rootdir = r"C:Your_Root_Folder"
for subdir, dirs, files in os.walk(rootdir):
    for filename in files:
        fullpath = os.path.join(subdir, filename)
        print filename
        if os.path.isfile(fullpath):
            basename, extension = os.path.splitext(fullpath)
            if extension.lower() == ".mxd":
                mxd = arcpy.mapping.MapDocument(fullpath)
                # Temporarily remove the imagery layer(s)
                for df in arcpy.mapping.ListDataFrames(mxd):
                    ImageLayerList = arcpy.mapping.ListLayers(mxd, "*USGS EROS*", df)
                    for lyr in ImageLayerList:
                        arcpy.mapping.RemoveLayer(df, lyr);
                    # Search-and-replace to fix up data source paths.
                    mxd.findAndReplaceWorkspacePaths(r"oldpath", r"newpath", False)
                    # Add the imagery layers back in
                    for lyr in ImageLayerList:
                        arcpy.mapping.AddLayer(df, lyr, "BOTTOM")
                mxd.save()
del lyr
del df
del mxd

dmcclimans, this code is very helpful, thanks. A question - as you loop through the df's you call mxd.findAndReplaceWorkspacePaths, but won't that try to update sources for the entire mxd file, not just the current df ? What if you have image layers in other df's ? That may not be an issue for me as this installation may have very few or no mxd files with multiple df's that contain image layers, but I just wanted to clarify.

Also, proposed solution by ESRI implies looking at map document layer by layer, so then each layer source would have be updated with lyr.findAndReplaceWorkspacePath, I've run into other issues using that technique - it returns an exception on annotation layers which I cannot skip over as they need to have source updated as well, so I need to use your technique.

Thanks, George

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

JeffBarrette — Wed, 07 Sep 2011 14:45:19 GMT

This issue will be addressed with SP3.

Jeff

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

RachaelYule — Fri, 21 Oct 2011 19:15:42 GMT

Hi Jeff - I'm new to this issue today after finding my python script threw the same error as @dmcclimans found, i.e. python crashes when using findAndReplaceWorkspacePaths on mxds that contain image service layers.

I've upgraded to SP3 (build 3200) but I still get the same error.

Was this issue definitely fixed with SP3 ?

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

JeffBarrette — Sun, 12 Dec 2021 00:27:56 GMT

I just confirmed this on a 10.0 SP3 machine. Image Server layers no longer show up as layers that support the lyr.support("DATASOURCE") property.

Before attempting to change a data source, check to see if this property is true.

for lyr in arcpy.mapping.ListLayers(mxd):
    if lyr.supports("DATASOURCE"):

If you are still having a problem, please send me a map package so I can test with your data.

Thanks,
Jeff

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

RayKreig — Wed, 11 Apr 2012 03:46:09 GMT

Last post to this thread was October 2009. Jeff, are you still taking up offers to view code for anyone still having this issue? I'm using 10, SP4, and it crashes when using a WMS layer. I am new to python and so far only use the Python script tool within an open instance of ArcMap. Using your suggestion, I believe this to be the code I would use, but it crashes before I can get to the last line.

import arcpy
mxd=arcpy.mapping.MapDocument(r"Temp.mxd")
for lyr in arcpy.mapping.ListLayers(mxd):
    if lyr.supports("DATASOURCE"):
        mxd.findAndReplaceWorkspacePaths(r"oldpath", r"newpath")
mxd.saveACopy(r"Temp2.mxd")

Here is a cut and paste before it crashes.
>>> import arcpy
>>> mxd=arcpy.mapping.MapDocument(r"V:\Land-AK\LOC\ChugachNF\_MXD\Temp.mxd")
>>> for lyr in arcpy.mapping.ListLayers(mxd):
...     if lyr.supports("DATASOURCE"):
...         mxd.findAndReplaceWorkspacePaths(r"V:\Land-AK\FS\CHUG", r"V:\Land-AK\LOC\ChugachNF")
...
Hitting enter again crashes it.

Without the WMS layer, this code works perfectly:

import arcpy
mxd=arcpy.mapping.MapDocument(r"Temp.mxd")
mxd.findAndReplaceWorkspacePaths(r"oldpath", r"newpath")
mxd.saveACopy(r"Temp2.mxd")

Thank you!

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

JeffBarrette — Wed, 11 Apr 2012 15:36:14 GMT

Sure, send me a small zip or map package that includes your simplified script to jbarrette@esri.com

Jeff

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

MitchComstock — Tue, 17 Apr 2012 02:45:21 GMT

Same problem here with findAndReplaceWorkspacePaths. Any solutions forthcoming?

Am running ArcGIS 10 build 3600 with SP3. My script crashes on maps with image service layers, works fine when those layers are removed.

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

deleted-user-9ppwtkjpkhrH — Mon, 07 May 2012 21:42:20 GMT

I'm at SP 2. The following Python script was a successfull work around. Note, I'm not experienced in arcpy so judge accordingly (although, hey, it does work!):

import os, sys, arcpy
import arcpy.mapping as MAP

mxdPath = sys.argv[1]
oldDataSource = r'P:\cby\gisprojects\umpqua\Phase_II'
newDataSource = r'P:\cby\gisprojects\umpqua\Soup_Cr_VRH'

arcpy.overwriteoutput = 1
mxd = MAP.MapDocument(mxdPath)

for lyr in MAP.ListLayers(mxd):
    if lyr.supports("DATASOURCE"): # note, this caught some of the image service layers but let one slip through
        if lyr.supports("SERVICEPROPERTIES"):
            if lyr.serviceProperties['ServiceType'] == "ImageServer": # note, this caught the image service layer that slipped through the first "if" statement
                pass
            else:
                lyr.findAndReplaceWorkspacePath(oldDataSource, newDataSource, False)
        else:
            lyr.findAndReplaceWorkspacePath(oldDataSource, newDataSource, False)
mxd.save()

del mxdPath
del oldDataSource
del newDataSource
del mxd

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

JeffBarrette — Sun, 12 Dec 2021 00:27:59 GMT

This should have been addressed at 10.0 SP3 with NIM067149: Block Web service layers from supporting layer.dataSource. The example in the previous post solves one problem but will introduce another if something.

The correct solution should be:

I just confirmed this on a 10.0 SP3 machine. Image Server layers no longer show up as layers that support the lyr.support("DATASOURCE") property.

Before attempting to change a data source, check to see if this property is true.
for lyr in arcpy.mapping.ListLayers(mxd):
    if lyr.supports("DATASOURCE"): If you are still having a problem, please send me a map package so I can test with your data.

Thanks,
Jeff

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

StephenIrving — Mon, 14 May 2012 19:11:11 GMT

Hello Jeff,

I, too, am having a great deal of trouble with this issue. I am running ArcGIS 10 SP4 and attempting the following:
import arcpy, os
folderPath = r"G:\US_Army_COE_Sac\ERS\Ft_Irwin\_MXDs\Checker"
for filename in os.listdir(folderPath):
    fullpath = os.path.join(folderPath, filename)
    if os.path.isfile(fullpath):
        basename, extension = os.path.splitext(fullpath)
        if extension.lower() == ".mxd":
            print fullpath + "\n...Checking"
            mxd = arcpy.mapping.MapDocument(fullpath)
            for lyr in arcpy.mapping.ListLayers(mxd):
                if lyr.supports("DATASOURCE"):
                    mxd.findAndReplaceWorkspacePaths(r"G:\US_Army_COE_Sac", r"G:\US_Army_COE_Sac\ERS\Ft_Irwin")
            print fullpath + "...Updated"
            mxd.save()
del mxd

I have also tried looping through each layer after the "DATASOURCE" test using layer.findAndReplaceWorkspacePath() with the same result of a full crash. The MXDs each have a Bing streaming imagery layer in the TOC and the script works fine if i remove it.

Thanks in advance for any ideas on why this is still not working....

Steve

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

JeffBarrette — Sun, 12 Dec 2021 00:28:02 GMT

I was able to reproduce using Bing Maps Aerial basemap. The higher level "Basemap" group layer does NOT support "DATASOURCE" but the sub-layer "BingMapsAerial" unfortunately does (the value is an empty string). We'll need to correct this.

In the meantime can you try:

for lyr in arcpy.mapping.ListLayers(mxd):
    if lyr.supports("DATASOURCE") and lyr.supports("DATASETNAME"):

The BingMapsAerial sub-layer does NOT support "DATASETNAME".

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

StephenIrving — Tue, 15 May 2012 21:35:52 GMT

Sweet!

Thank you that works well!

Steve

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

StephenIrving — Tue, 15 May 2012 23:23:39 GMT

Sweet!

Thank you that works well!

Steve

Looks like i spoke a bit too soon. Now it is throwing this error:

Executing: MXDSourceUpdate G:\US_Army_COE_Sac\ERS\Ft_Irwin\_MXDs\_Reports\Workplan G:\US_Army_COE_Sac\ERS G:\US_Army_COE_Sac\ERS\Ft_Irwin
Start Time: Tue May 15 17:00:57 2012
Running script MXDSourceUpdate...
Traceback (most recent call last):
File "D:\TEMP\_Python\mxd_source_update_20120515.py", line 33, in <module>
    lyr.findAndReplaceWorkspacePath(origSource2, newSource2,"FALSE")
File "C:\Program Files\ArcGIS\Desktop10.0\arcpy\arcpy\utils.py", line 181, in fn_
    return fn(*args, **kw)
File "C:\Program Files\ArcGIS\Desktop10.0\arcpy\arcpy\_mapping.py", line 601, in findAndReplaceWorkspacePath
    return convertArcObjectToPythonObject(self._arc_object.findAndReplaceWorkspacePath(*gp_fixargs((find_workspace_path, replace_workspace_path, validate), True)))
ValueError: Layer: Unexpected error
Layer: Unexpected error
Completed script MXDSourceUpdate...
Failed to execute (MXDSourceUpdate).
Failed at Tue May 15 17:01:00 2012 (Elapsed Time: 3.00 seconds)

I am not sure, but is seems like the arcpy module is trying to validate the paths. My understanding was the script would work regardless of whether or not it found a valid path. I tried explicitly setting the validation to "FALSE" which yielded the same result. My MXDs typically have layers referencing many sources, I was hoping this tool would function as a true find and replace. That is, it would ignore any layers in which it did not "find" the search string.

Any ideas?

Here is my code:

import arcpy, os

try:

    #Read input parameters from GP dialog
    folderPath = arcpy.GetParameterAsText(0)
    origSource = arcpy.GetParameterAsText(1)
    newSource = arcpy.GetParameterAsText(2)

    #Loop through each MXD file
    origSource2 = origSource.replace("\\","/")
    newSource2 = newSource.replace("\\","/")
    for filename in os.listdir(folderPath):
        fullpath = os.path.join(folderPath, filename)
        if os.path.isfile(fullpath):
            basename, extension = os.path.splitext(fullpath)
            if extension.lower() == ".mxd":
                mxd = arcpy.mapping.MapDocument(fullpath)
                print fullpath + "\n\n...Checking"
                for lyr in arcpy.mapping.ListLayers(mxd):
                    if lyr.supports("DATASOURCE") and lyr.supports("DATASETNAME"):
                        lyr.findAndReplaceWorkspacePath(origSource2, newSource2,"FALSE")
                print fullpath + "\n\n...Updated"
                mxd.save()
    del mxd

    #Delete variables that reference data on disk
    del folderPath, origSource, newSource, filename, fullpath

except Exception, e:
        import traceback
        map(arcpy.AddError, traceback.format_exc().split("\n"))
        arcpy.AddError(str(e))

BTW it actually still crashes completely if I try to use mxd.findAndReplaceWorkspacePaths() after the layer test. I would prefer this method as it is supposed to update all layers including table layers which are apparently missed by the layer.findAndReplaceWorkspacePath()... but maybe i am just missing something?

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

JeffBarrette — Wed, 16 May 2012 14:00:41 GMT

I'm not sure this logic will work. For example, let us say I have a layer with the following data source:

C:\\temp\\lines

Your code [origSource2 = origSource.replace("\\","/")] is converting the string to:

C:/temp/lines

Then you are trying to perform a find and replace with a "find" string that does NOT exist in any of your sources because you changed it but perhaps that is why you are using validate=False. I don't know enough to assess the error.

Can you send me just your MXD (no data) to jbarrette@esri.com. From that I should be able to determine the data sources.

Jeff

Re: findAndReplaceWorkspacePaths crashes when mxd contains image layers

StephenIrving — Wed, 16 May 2012 22:22:16 GMT

"I may have found the issue. It helps to try real scripts against real MXDs.

Change this line:
lyr.findAndReplaceWorkspacePath(r"G:\US_Army_COE_Sac\ERS\Ft_Irwin", r"G:\US_Army_COE_Sac","FALSE")

To:
lyr.findAndReplaceWorkspacePath(r"G:\US_Army_COE_Sac\ERS\Ft_Irwin", r"G:\US_Army_COE_Sac", False)

The validation parameter is a Python Boolean, not a string. You want to use False with an upper case "F", lower case "alse")

Jeff"

The above worked perfectly! Thanks again!