topic Re: Adding all GIS Layers from a folder in Mapping Questions

Adding all GIS Layers from a folder

Ryan_Galbraith — Thu, 06 Oct 2011 15:17:23 GMT

Anyone know how to create a looping statement that adds all the GIS layers from a folder? Using arcpy.mapping.

Here is what I got:

arcpy.env.workspace = '#whatever the folder is'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
for fc in fclist:
.....#something to add to your feature classes

Re: Adding all GIS Layers from a folder

Anonymous User — Thu, 06 Oct 2011 22:59:29 GMT

Original User: jscheirer

arcpy.MakeFeatureLayer_management(fc, fc)

Re: Adding all GIS Layers from a folder

JeffBarrette — Fri, 07 Oct 2011 13:35:28 GMT

You are on the right track. Check out the samples for MakeFeatureLayer. Also check out arcpy.mapping.AddLayer.

Jeff

Re: Adding all GIS Layers from a folder

Anonymous User — Fri, 07 Oct 2011 14:04:01 GMT

Original User: rdg129

arcpy.MakeFeatureLayer_management(fc, fc)

No, that, didn't work, the two fcs can't be the same.

Re: Adding all GIS Layers from a folder

JasonScheirer — Sat, 11 Dec 2021 16:29:20 GMT

The second one is the name of the layer in the TOC. If that's not working, something like this:

arcpy.env.workspace = '#whatever the folder is'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
for i, fc in enumerate(fclist):
    arcpy.CreateFeatureLayer_management(fc, "layer_%i" % i)

Re: Adding all GIS Layers from a folder

Anonymous User — Fri, 14 Oct 2011 14:41:52 GMT

Original User: rdg129

That doesn't work either. Not sure why not it always brings up an error.

Re: Adding all GIS Layers from a folder

RichardFairhurst — Sat, 11 Dec 2021 16:29:23 GMT

That doesn't work either. Not sure why not it always brings up an error.

Perhaps a dumb question, but what are you actually putting in the first line to specify the workspace folder? If the path is unspecified or invalid (such as incorrect slashes, which is common with path strings), that could be the source of the error.

arcpy.env.workspace = 'C:\\GIS_DATA\\' # or r 'C:\GIS_DATA\'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
for i, fc in enumerate(fclist):
    arcpy.CreateFeatureLayer_management(fc, "layer_%i" % i)

Re: Adding all GIS Layers from a folder

Anonymous User — Wed, 19 Oct 2011 14:55:19 GMT

Original User: rdg129

I am using shapefiles, does that matter?

Re: Adding all GIS Layers from a folder

RichardFairhurst — Sat, 11 Dec 2021 16:29:26 GMT

I am using shapefiles, does that matter?

I think the problem is in the fact that the fc variable is a numeric value and not a feature class because it has been converted to an enumerated value. The CreateFeatureLayer expects fc to be an actual feature class and not a number. Separte the enumeration variable i from the fc variable. Try the code below:

arcpy.env.workspace = 'C:\\GIS_DATA\\' # or r 'C:\GIS_DATA\'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
i = 0
for fc in fclist:
    i += 1
    arcpy.CreateFeatureLayer_management(fc, "layer_%i" % i)

Re: Adding all GIS Layers from a folder

Anonymous User — Thu, 17 Nov 2011 13:18:39 GMT

Original User: rdg129

GRRR. Nothing is working. thanks for all your help though.

Re: Adding all GIS Layers from a folder

BenjaminGale — Sat, 11 Dec 2021 16:29:29 GMT

Think this should work. I tested it on a folder of shp files.

arcpy.env.workspace = "WORKSPACE"
mxd = arcpy.mapping.MapDocument('CURRENT')
fclist = arcpy.ListFeatureClasses()
for fc in fclist:
    name = fc.split(".") #Splits the .shp from the name
    arcpy.MakeFeatureLayer_management(fc,name[0])