topic Re: Calculate Field - VB - Conditional If,elseif statement... not working?! in Geoprocessing Questions

Calculate Field - VB - Conditional If,elseif statement... not working?!

HaileyMonod — Fri, 04 May 2012 14:37:02 GMT

Hi,

Wihtin model builder I have used the field calculator, to try and populate a new empty field (called Water_Classification) based on the contents of another field. However, my VB statement is not working and I am unable to figure out why? If anybody can help, it would be much appreciated 🙂

I would like to put numeric values in a field called [Water_Classification] depending on what the string values are from another field called [CLASSIFICATION_1]

This is what I currently have:

If [CLASSIFICATION_1] = "High" then
   x =5
ElseIf [CLASSIFICATION_1] = "Medium" then
   x =3
ElseIf [CLASSIFICATION_1] = "Low" then
   x =1
ElseIf [CLASSIFICATION_1] = "<null>" then
   x =0
Else
   x = 9999
EndIf

At the end (in the box at the bottom), I have: Water_Classification = x

If anybody has any advice or tips, pelase let me know,
Thanks!

Re: Calculate Field - VB - Conditional If,elseif statement... not working?!

DuncanHornby — Fri, 04 May 2012 14:41:46 GMT

I think you need to add at the top of your code a simple dim statement like:

Dim x

Also not sure this line is correct:

ElseIf [CLASSIFICATION_1] = "<null>"

you may want to try something like (I did not test these):

ElseIf [CLASSIFICATION_1] = ""

or

ElseIf IsNull([CLASSIFICATION_1]) = True

Duncan

Re: Calculate Field - VB - Conditional If,elseif statement... not working?!

HaileyMonod — Fri, 04 May 2012 15:06:25 GMT

Hhmm I have added Dim x at the top and changed that one line to be ElseIf IsNull([CLASSIFICATION_1]) = True then.... However its still not working. But I am getting a new error, which says "Error Executing Funtion. Expected 'Then' Failed to execute".
Thanks for the help! any other ideas?

Re: Calculate Field - VB - Conditional If,elseif statement... not working?!

DuncanHornby — Fri, 04 May 2012 15:45:13 GMT

Can you post up the script, exactly how you entered it?

Re: Calculate Field - VB - Conditional If,elseif statement... not working?!

HaileyMonod — Fri, 04 May 2012 15:55:18 GMT

Dim x
If [CLASSIFICATION_1] = "High" then
   x =5
ElseIf [CLASSIFICATION_1] = "Medium" then
   x =3
ElseIf [CLASSIFICATION_1] = "Low" then
   x =1
ElseIf IsNull [CLASSIFICATION_1] = True then
   x=0
Else
   x = 9999
EndIf

Water_Classification= x

Thanks for your help!

[ATTACH=CONFIG]14100[/ATTACH]

[ATTACH=CONFIG]14101[/ATTACH]

Re: Calculate Field - VB - Conditional If,elseif statement... not working?!

DarrenWiens2 — Fri, 04 May 2012 15:57:27 GMT

"EndIf" needs a space ---------> "end if"

Also, IsNull is a function, and requires ()'s around the field name.

Re: Calculate Field - VB - Conditional If,elseif statement... not working?!

DuncanHornby — Fri, 04 May 2012 15:58:00 GMT

This is going to be painful...

EndIf

should be (note space)

End If

Duncan

Re: Calculate Field - VB - Conditional If,elseif statement... not working?!

HaileyMonod — Fri, 04 May 2012 16:03:43 GMT

You guys are BRILLIANT !!
Both the space was required and the ()'s after IsNull.

Thank you so much!

Hailey