topic Re: Update ID field using another feature class in Data Management Questions

Update ID field using another feature class

SarahHartholt — Wed, 03 Feb 2021 20:54:33 GMT

I am fairly new to Arcade and am trying to update the CoordinatedID field in my WaterMain layer using an attribute rule with the help of some code found here: Attribute rule script expression examples—ArcGIS Pro | Documentation

What I would like to do it grab the CoordinatedID field from my Roads (Centreline_Assets) layer and use it to populate the CoordinatedID field in my WaterMains (WaterMains_Assets) layer. They layers don't line up exactly so I am trying to buffer the road by 10m and populate the Coordinated field based on an intersection between the buffer and the WaterMains layer. Here's what I have so far:

//On Insert or Update populate Coordinate ID var fcRoad=FeatureSetByName($datastore, "Centreline_Assets",["Coordinated_ID"]) var fcWaterMain=FeatureSetByName($datastore,"WaterMain_Assets_SplitLine",["Coordinated_ID"]) Var RoadIntersect = Intersects(Buffer(fcRoad,10,'meter'),fcWaterMain) var AddList = [] var counter = 0 var noCID = Count(RoadIntersect) if (noCID>0){ for (var Road in RoadIntersect){ AddList[counter]={ 'Coordinated_ID':Centreline_Assets.CoordinatedID, 'attributes':{ 'add_CoordinateID':$feature.Coordinated_ID } } counter++ } return { 'result': noCID + ' Coordinated ID found', 'edit': [{ 'className':'Centreline_Assets', 'updates': AddList }] } }else{ return 'No Coordinated ID' }

I keep getting the following error:

Invalid expression. Error on line 4. Geometry type null expected.

Any suggestions?

Re: Update ID field using another feature class

JoeBorgione — Wed, 03 Feb 2021 21:30:04 GMT

Did you mean to spell Centerline this way? Centreline

Re: Update ID field using another feature class

XanderBakker — Wed, 03 Feb 2021 22:32:37 GMT

Hi @SarahHartholt ,

The error is pointing to line 4 and it is because you can't buffer a featureset, you can only buffer and single feature.

Re: Update ID field using another feature class

SarahHartholt — Thu, 04 Feb 2021 00:30:08 GMT

Thanks @XanderBakker . Is there any way for me to run my arcade expressions through a debugger? I've started using the Arcade playground but I haven't figured out a way to bring my features and attributes into it for testing. Please let me know if there are any useful articles that I could read on the topic.

Re: Update ID field using another feature class

XanderBakker — Thu, 04 Feb 2021 13:11:50 GMT

Hi @SarahHartholt ,

I agree that debugging attribute rules is a bit tricky. However, you could use part of the expression in a pop-up to validate the result. You cannot use a return type that writes to a featureclass, but at least you will be able to see if the logic that occurs before returning the result is working.

Using the playground is great to check functions and logic, but you won't have access to your data and the sample data provided is very limited (2 polygon layers).

Related to the specific problem you are trying to tackle, there might be some additional complications since I suppose a waterline could intersect with multiple road buffers.

When you create an attribute rule on your waterlines, you will want to read the current waterline feature and buffer it and intersect the buffer with the road features. Then (maybe) you would have to check the length of the road segments inside the waterline buffer, to see which Coordinated_ID you should take.

Re: Update ID field using another feature class

SarahHartholt — Thu, 04 Feb 2021 13:28:35 GMT

Yes there are some other issues that I need to consider. Like you said, the waterlines will intersect with multiple road buffers (blue lines are waterlines, black lines are roads & 10m buffer is grey):

I was hoping that I could automate some of the processes I want to achieve using Arcade rather than having to run geoprocessing tools when I add data to my layers but I think I'm in over my head on this one.

Re: Update ID field using another feature class

XanderBakker — Thu, 04 Feb 2021 13:41:48 GMT

Hi @SarahHartholt ,

I think this is something that can be done. You can intersect the waterline buffer with the roads and evaluate the length of the road inside the buffer and take the Coordinate_ID of the longest road segment.

I do have a couple of questions:

Do you want to do this as a Batch or as an immediate calculation triggered by an edit?
How will you handle waterlines that are not contained by the roadbuffer in your screenshot? Should these get the Coordinate_ID of the road it crosses or no Coordinate_ID?

Re: Update ID field using another feature class

SarahHartholt — Thu, 04 Feb 2021 14:04:50 GMT

Hi @XanderBakker

I don't think I know arcade well enough to accomplish this myself.

I was hoping I could do this as an immediate calculation. Right now when a road segment is added to my roads layer, I have an update rule that populates the Coordinated_ID field with the Next Sequence Value. Once the road layer is populated, I think I need to split the waterlines at vertices - the idea being that the U shaped segments will be separated into smaller pieces that line up with the roads more closely, making it easier to assign the correct Coordinated_ID. I was hoping that splitting the water lines would trigger the expression to grab the Coordinated_ID from the roads feature.

Waterlines that are not contained in the road buffer will need to be manually inspected and would likely be assigned a separate Coordinated_ID that is not associated with a road segment.

Re: Update ID field using another feature class

XanderBakker — Thu, 04 Feb 2021 14:10:04 GMT

Hi @SarahHartholt ,

Since you are editing the same layer of the feature the return type does not have to be the object including the name of the featureclass. Have a look at the example below (without using NextSequenceValue):

//On Insert or Update populate Coordinate ID var fsRoads = FeatureSetByName($datastore, "Centreline_Assets",["Coordinated_ID"], True); var watermain = $feature; var watermainbuf = Buffer(watermain, 10, 'meter'); var roads = Intersects(fsRoads, watermainbuf); var cnt = Count(RoadIntersect); // check different situations if (cnt == 0) { // there are no roads found return null; } else if (cnt == 1) { // there is a one road, return the Coordinate_ID return First(roads)["Coordinated_ID"]; } else { // there are multiple roads found, find the longest segment var maxsegmentlength = 0; var CoordID = null; for (var road in roads) { var segment = Intersection(road, watermainbuf); var segmentlength = Length(segment, 'meter'); if (segmentlength > maxsegmentlength) { CoordID = road["Coordinated_ID"]; maxsegmentlength = segmentlength; } } return CoordID; }

Re: Update ID field using another feature class

SarahHartholt — Thu, 04 Feb 2021 14:27:11 GMT

Thanks @XanderBakker , looks great and I find the comments very helpful! I am getting an error on line 6 though - object not found roadintersect. When I change the variable to roads I get a general function failure. Not sure what's going on there.

Re: Update ID field using another feature class

XanderBakker — Thu, 04 Feb 2021 14:38:03 GMT

Hi @SarahHartholt ,

Good catch, it should indeed be "roads". I wonder why the general function failure is happening. The general function failure closed your ArcGIS Pro session? What version are you using? Where are the centerlines and water mains stored (they should be in the same $datastore)?

Would it be possible to share a small piece of data to do some testing?

Re: Update ID field using another feature class

SarahHartholt — Thu, 04 Feb 2021 14:48:26 GMT

ArcPro stays open. I get the error when verifying the code in the Expression Builder within the Attribute Rule window. I'm using ArcPro 2.6.2

Both feature classes are stored in the default geodatabase that is automatically created with the ArcPro project.

Re: Update ID field using another feature class

XanderBakker — Thu, 04 Feb 2021 15:23:41 GMT

Hi @SarahHartholt

I would recommend you to create an expression in the pop-up of the waterline layer and test the expression divided into parts. First until determining the count and return that count and then the other parts.

Re: Update ID field using another feature class

SarahHartholt — Thu, 04 Feb 2021 16:10:16 GMT

I closed the document, re opened it and now the expression that you wrote up seems to work. I think all I need to do now is figure out how to assign global id's to my water main features for the expression to be valid

Re: Update ID field using another feature class

XanderBakker — Thu, 04 Feb 2021 16:19:49 GMT

Hi @SarahHartholt ,

Just go to your featureclass in the catalog window, right click, choose Manage and you will see the option Add GlobalID's

Re: Update ID field using another feature class

SarahHartholt — Thu, 04 Feb 2021 16:21:24 GMT

Thank you!

Re: Update ID field using another feature class

XanderBakker — Thu, 04 Feb 2021 16:44:46 GMT

Hi @SarahHartholt ,

You are welcome.

To take it a step further and include the validation to see if the main is contained by a buffer of the roads, have a look at this example:

Function IsContainedByRoads(watermain, roads) { var bufs = []; // create list of selected roads buffer for (var road in roads) { var buf = Buffer(road, 10, 'meter'); bufs[Count(bufs)] = buf; } // union the road buffers var buftot = Union(bufs); // validate if watermain is contained by total buffer return Contains(buftot, watermain); } //On Insert or Update populate Coordinate ID var fsRoads = FeatureSetByName($datastore, "Centreline_Assets", ["Coordinated_ID"], True); var watermain = $feature; var watermainbuf = Buffer(watermain, 10, 'meter'); var roads = Intersects(fsRoads, watermainbuf); var cnt = Count(roads); // check different situations if (cnt == 0) { // there are no roads found return null; } else if (cnt == 1) { // there is a one road, validate if the main is contained by the roads buffer if (IsContainedByRoads(watermain, roads)) { return First(roads)["Coordinated_ID"]; // create the ID using NextSequenceValue } else { // what to return when the main is not contained? return null; } } else { // there are multiple roads found, validate if the main is contained by the roads if (IsContainedByRoads(watermain, roads)) { //find the longest segment var maxsegmentlength = 0; var CoordID = null; for (var road in roads) { var segment = Intersection(road, watermainbuf); var segmentlength = Length(segment, 'meter'); if (segmentlength > maxsegmentlength) { CoordID = road["Coordinated_ID"]; maxsegmentlength = segmentlength; } } return CoordID; // create the ID using NextSequenceValue } else { // what to return when the main is not contained? return null; } }