topic Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator in ArcGIS Pro SDK Questions

In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Thu, 05 Aug 2021 18:00:44 GMT

My company's software is used internationally so we test with different operating system (Windows) regional settings (i.e., various country specific numeric formats). One section of our code uses the EditOperation Modify method to change some geometries. This code works fine in ArcGIS Pro v2.6.x and v2.7.x with different regional settings, but in v2.8.1 when the regional settings are set to a region that uses a comma instead of a decimal point as the decimal separator, it no longer works correctly. Specifically, the changed geometries end up with shape area = 0 and they disappear from the map. If I go into the Windows 10 region settings and manually change the decimal symbol to a point, it works fine again, so the decimal separator is the problem. Has anyone else encountered this? Any work-arounds? This seems to be a bug....

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

NarelleChedzey — Thu, 05 Aug 2021 23:09:01 GMT

Hi Karen,

Can you perhaps answer a few questions about your scenario to help us track this problem down. I am currently unable to reproduce on 2.8 final, 2.8.1 or even our current build.

- Are you using file geodatabase or enterprise data? If enterprise, what database platform (Oracle, SQL etc)

- What overload of EditOperation.Modify are you using? Are you modifying geometry or attributes or geometry and attributes. I tested using this overload passing only the layer, oid and geometry (No attributes).

public void Modify(Layer layer, long oid, Geometry geometry, Dictionary<string, object> attributes = null);

- Is there anything special about your data; ie does it participate in a topology, utility network etc? I was just using a polygon layer inserted via Map Notes.

- I was using France as my region ensuring that the decimal separator was the comma. Can you duplicate the problem with many different regions that use the comma as the decimal separator?

- Finally, maybe this is obvious, but have you verified via the debugger that the new geometry shape is a non empty geometry before passing it to EditOperation.Modify? (https://pro.arcgis.com/en/pro-app/latest/sdk/api-reference/#topic8175.html)

Thanks for any answers you can provide.

Narelle

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Thu, 05 Aug 2021 23:23:35 GMT

Hi Narelle,

I am only modifying the geometry (no attributes). The data is file geodatabase data (polygons) and there isn't anything special about it. I was using German (Germany) as the region. The problem occurred for me in 2.8, 2.8.1 and 2.8.2. An the problem is very consistent - it happens every time. The exact same add-in works fine in 2.6 and 2.7.4.

Yes, I have verified that the geometries aren't empty. And I am using the same overload that you did - layer, oid, geometry. I'm basically replacing the geometries in one feature class with geometries from another. I'd be happy to show you what is happening if you want a demo.

Karen

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

Wolf — Fri, 06 Aug 2021 13:18:10 GMT

Hallo Karen,

I will setup a test system with German language and region and try to reproduce your issue. Can you tell me the projections that you are using for your geometries (both the feature class that you are modifying and the feature class from where you copy the data)? Or maybe you can attach a sample dataset to your reply.

Wolf

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

Wolf — Fri, 06 Aug 2021 18:50:25 GMT

Hi Karen,

I was not able to duplicate the issue you are seeing. I attached my test add-in (2.8.2) and my test project. You click a button on the test add-in it first creates a new feature and then updates the same feature on subsequent clicks. Also, is it possible that the geometry you are copying into the modified feature is disposed by the time you are calling editOperation.Execute()? Note that in my sample I use .Clone() to prevent this from happening.

// search the source for the matching parcel record // copy only one polygon Geometry parcelPolygon = null; using (var cursor = sourceLayer.Search(new QueryFilter() { WhereClause = selectionSourceQuery })) { if (cursor.MoveNext()) { using (var parcelFeature = cursor.Current as Feature) { // note: cloning the gemetry makes sure that the // geometry persists outside the context of the cursor parcelPolygon = parcelFeature.GetShape().Clone(); } } }

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Mon, 09 Aug 2021 23:08:32 GMT

Hi Wolf,

I tried using my own data with your code, and it doesn't work in there even with a regular decimal point! I'm not sure what's going on. I've attached a project for you to take a look at and my changes to the visual studio solution. This code is changing objectID 117 in the Modify feature to class to the geometry from objectID 1 in the Source feature class.

Note that in my existing code it still works correctly with a decimal point but not with a decimal comma in 2.8, but it works with both in 2.6.x and 2.7.x. Also, the code with developed in 2.6, but it builds fine and works fine (except for this one issue) in 2.8.

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

Wolf — Tue, 10 Aug 2021 15:29:08 GMT

Thanks Karen,

Thangs for the sample data. I am able to replicate what you are seeing with your data, however, in my tests the copied geometry is 'nulled' regardless on my language / region settings. I will let you know what i find.

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Tue, 10 Aug 2021 16:50:47 GMT

Thanks Wolf! I'm glad you were able to replicate it. I was seeing the same thing - it doesn't work regardless of region setting. It's in my original code that it only fails with the European number settings.

I hope you are able to solve this issue - it would be really helpful!

Karen

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

Wolf — Tue, 10 Aug 2021 19:07:55 GMT

Hi Karen,

We are still trying to figure out what exactly is causing this issue. It appears to be data related. In the meantime I received a workaround that will fix this issue for the time being. The workaround writes over the 'null' geometry in an EditOperation call back, it is using the Geodatabase API to do so. The Geodatabase API doesn't seem to have any problems with the data. I modified the code you sent me with the EditOperation call back workaround below.

protected override async void OnClick() { var sourceLayerName = "Source"; var modifyLayerName = "Modify"; var SourceFieldName = "OBJECTID"; var ModifyFieldName = "OBJECTID"; var selectionSourceQuery = $@"{SourceFieldName} = 1"; var selectionModifyQuery = $@"{ModifyFieldName} = 117"; var sourceLayer = MapView.Active.Map.GetLayersAsFlattenedList().Where((l) => l.Name == sourceLayerName).FirstOrDefault() as FeatureLayer; if (sourceLayer == null) { MessageBox.Show($@"Unable to find {sourceLayerName} in the active map"); return; } var modifyLayer = MapView.Active.Map.GetLayersAsFlattenedList().OfType<FeatureLayer>().FirstOrDefault(f => f.Name == modifyLayerName); if (modifyLayer == null) { MessageBox.Show($@"Unable to find {modifyLayerName} in the active map"); return; } await QueuedTask.Run(() => { // search the source for the matching parcel record // copy only one polygon Geometry sourcePolygon = null; using (var cursor = sourceLayer.Search(new QueryFilter() { WhereClause = selectionSourceQuery })) { if (cursor.MoveNext()) { using (var myFeature = cursor.Current as Feature) { sourcePolygon = myFeature.GetShape().Clone(); } } } if (sourcePolygon == null) { MessageBox.Show($@"The add-in was not able to find a parcel where '{selectionSourceQuery}' is true."); return; } using (Table table = modifyLayer.GetTable()) { EditOperation editOperation = new EditOperation { Name = "Modify a geometry callback" }; editOperation.Callback(context => { QueryFilter filter = new QueryFilter { WhereClause = selectionModifyQuery }; using (RowCursor rowCursor = table.Search(filter, false)) { while (rowCursor.MoveNext()) { using (Feature feature = (Feature)rowCursor.Current) { // In order to update the Map and/or the attribute table. // Has to be called before any changes are made to the row. context.Invalidate(feature); feature.SetShape(sourcePolygon); //After all the changes are done, persist it. feature.Store(); // Has to be called after the store too. context.Invalidate(feature); } } } }, table); // create the polygon feature editOperation.Modify(modifyLayer, 117, sourcePolygon); if (!editOperation.Execute()) { MessageBox.Show($@"Unable to create a new '{sourceLayer}' record: {editOperation.ErrorMessage}"); } } }); }

I will give you an update on our findings.

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Tue, 10 Aug 2021 19:23:04 GMT

Thanks! I will give this a try. Will this call back operation work in Pro v2.6 and 2.7?

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Tue, 10 Aug 2021 19:53:02 GMT

Hi Wolf,

When I try this code I get an error on line 64 (SetShape) that says "Geometry cannot have Z values". This is using the same data I sent you.

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Tue, 10 Aug 2021 20:04:27 GMT

Hi Wolf,

When I try this code I get an error on line 64 (SetShape) that says "Geometry cannot have z-values". This is using the same data I sent you.

Karen

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

Wolf — Tue, 10 Aug 2021 20:31:27 GMT

Strange, both feature classes you sent me have 'No Z values'. That would mean that z-values got added to the geometry. Can you double check your feature classes ? I used v 2.8.2.

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Tue, 10 Aug 2021 22:10:58 GMT

Something was weird was going on with the data I was using (which was different that what I sent you). It seems to be working now. Yay!

Am I correct in assuming this line doesn't need to be in there?:

editOperation.Modify(modifyLayer, 117, sourcePolygon);

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

Wolf — Wed, 11 Aug 2021 16:36:12 GMT

No, you have to leave the editOperation.Modify line in the code, even so your 'sourcePolygon' will be overwritten in the callback. The editOperation.Modify triggers the callback, the callback in turn then writes the 'untouched' sourcePolygon geometry through the geodatabase API.
We know at this point that there is some problem with the sourcePolygon geometry, we don't know what the exact problem is yet. The reason why you get an empty geometry is because EditOperation will 'simplify' every geometry before saving it in the geodatabase. Apparently this 'simplification' is the not working correctly and results in an empty geometry. We are trying to find what the issue with the geometry is and also a method to fix it. We tried some of the GP tools to fix the geometry but those had the same problem. Anyways i will keep you updated on our progress, but for now that's the only workaround we have. Also remember that your geometry still has an issue even once you write it directly into the geodatabase, so editing in Pro will not work for this geometry.

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Wed, 11 Aug 2021 16:44:18 GMT

Thanks Wolf,

Please keep me updated on what you find out about the data issue. These exact same geometries worked fine in v2.6 and 2.7, so I can't help but think that something in Pro changed in 2.8 to cause this issue.

When I use your "call back" code in my application (as opposed to in the solution you sent, where I had it working), I keep getting the "Geometry cannot have z-values" error on the SetShape() method even though the data doesn't have z-values!?!? Very strange..... and also a bit frustrating.

Thanks for your help.

Karen

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

NarelleChedzey — Wed, 11 Aug 2021 16:57:40 GMT

Hi Karen,

Sorry if this is obvious again, but can you confirm that your geometry itself is not Z enabled prior to the EditOperation.Callback function - https://pro.arcgis.com/en/pro-app/latest/sdk/api-reference/#topic8174.html

Even though your feature classes are not Z-enabled, and your source data from the feature classes are not Z-anabled, some geometry routines may add the Z flag to your geometry if you are doing certain manipulations between retrieving the geometry from the feature class and then storing it in the second feature class.

Thanks

Narelle

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Wed, 11 Aug 2021 17:05:54 GMT

Hi Narelle,

I checked and the individual geometry DOES show HasZ = true, even though the feature class is not z-enabled. Is there any way I can set the z flag to false?

Karen

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

NarelleChedzey — Wed, 11 Aug 2021 17:17:02 GMT

Karen,

The following code should create you a polygon without Z. Because geometries are immutable, you need to use a geometry builder object, manipulate the Z flag and then obtain a new geometry.

Polygon polygonNoZ = null; // needs to run on MCT using (var builder = new PolygonBuilder(polygon)) { builder.HasZ = false; polygonNoZ = builder.ToGeometry(); }

However I would also recommend trying to determine which line of code turned your non Z-enabled source data into Z-enabled polygons.

Narelle

Re: In v2.8.1 EditOperation Modify method not working correctly with European comma decimal separator

KarenMeinstein — Wed, 11 Aug 2021 17:25:24 GMT

Thanks Narelle! I will give that a try.

The geometry is z-enabled as soon as I retrieve it from the non-z-enabled feature class. If it's possible to save a z-enabled polygon in a non-z-enabled feature class, I supposed it could have happened when the polygon was initially created and saved.