topic Re: CancelEdit in OnRowChangeEvent not working in ArcGIS Pro SDK Questions

CancelEdit in OnRowChangeEvent not working

MKa — Sun, 12 Dec 2021 08:36:39 GMT

I am in the process of upgrading my users to the newest version of ArcGIS Pro 2.4.3 and testing my code. It appears that CancelEdit is not performing as expecting in the OnRowChangeEvent? It seems to work in OnRowDeleteEvent but not in OnRowChange?

else if (ConditionTrue) //rollback
                        {
                            //CANCEL the Redraw Change
                            args.CancelEdit(() => ChangeError("Changes Not Allowed!", "Parent Shape Cannot be changed"));
                        }‍‍‍‍‍

I also put in simply args.CancelEdit() and that failed too

Re: CancelEdit in OnRowChangeEvent not working

MKa — Fri, 24 Jan 2020 14:52:00 GMT

I can seem to figure out why this doesn't work in my code. I am unable to upgrade until I allow users to either cancel their changes or stop them from performing certain changes. I upgraded my arcgis pro sdk from 2.2.3

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Fri, 24 Jan 2020 19:18:21 GMT

Hi M,

Whats the datasource for the edits you want to cancel?

And confirming that the code worked at 2.2.3?

Thanks

Sean

Re: CancelEdit in OnRowChangeEvent not working

MKa — Fri, 24 Jan 2020 19:50:50 GMT

The datasource if a featureservice and it currently works in 2.2.3 that is in our Production environment. I am moving to 2.4.3

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Fri, 24 Jan 2020 22:28:20 GMT

Thanks, looking into it.

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Fri, 24 Jan 2020 22:52:23 GMT

Seems to be working for me on Pro 2.4.3 against a feature service on 10.6 windows portal. All three change events are ok, they can be cancelled.

Whats your server environment?

Re: CancelEdit in OnRowChangeEvent not working

MKa — Sat, 25 Jan 2020 00:08:54 GMT

I am on server 10.5.1.

you got your code to undo the vertex edit in the on change event?

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Sun, 12 Dec 2021 08:36:42 GMT

Sure, here's the code which cancels all.

    protected override void OnClick()
    {
      //run on MCT
      QueuedTask.Run(() =>
      {
        var mapLayers = MapView.Active.Map.GetLayersAsFlattenedList().OfType<FeatureLayer>();
        foreach (var layer in mapLayers)
        {
          var layerTable = layer.GetTable();
          RowChangedEvent.Subscribe(onRowEvent, layerTable);
          RowCreatedEvent.Subscribe(onRowEvent, layerTable);
          RowDeletedEvent.Subscribe(onRowEvent, layerTable);
        }
      });
    }

    private void onRowEvent(RowChangedEventArgs obj)
    {
      obj.CancelEdit();
    }‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: CancelEdit in OnRowChangeEvent not working

MKa — Sat, 25 Jan 2020 00:46:02 GMT

I am out now for a couple days but I will dig into this on Monday, but do you think my conditional statement around it affects something.

your canceledit is the only statement in the event. I have 3 conditionals and a try catch. But my cancel edits are the last statements run? Long shot guess without being able to strip my code down to what you have here.

again this isn’t happening in my delete event.

Re: CancelEdit in OnRowChangeEvent not working

MKa — Sun, 12 Dec 2021 08:36:44 GMT

I have narrowed down why this is happening, but might need some guidance. It appears that in the RowChange event this is happening because I load an inspector in the event to check a value of the selected row. If that value is true i cancel the edit. This DOES NOT work in the row change event. In the delete event, I have to check a value as well using an inspector and this DOES work. When I load an inspector in the onDelete it works like it should in 2.4.3, but in onChange if I use the inspector.load for that arg and objectid, the canceledit does not work

This does not work in the onChange event (it doesn't rollback)

//This doesn't rollback the change because of the inspr.load, i have stepped through both 
//with and without this line.  This worked in the old version


protected async static void OnRowChangeEvent(RowChangedEventArgs args)
        {
            Inspector inspr = new Inspector();

            long _updateOID = args.Row.GetObjectID();

            //Get the layer of the selected item
            FeatureClass newFC = (FeatureClass)args.Row.GetTable();
            string updateItemName = newFC.GetDefinition().GetAliasName();
            FeatureLayer firstFeatureLayer = FeatureServiceManagement.GetFeatureLayer(updateItemName);

            //Load the inspector                
            await inspr.LoadAsync(firstFeatureLayer, _updateOID);

            args.CancelEdit();
}
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

This DOES work in the onDelete event (it doesn't delete, it rolls back)

protected async static void OnRowDeleteEvent(RowChangedEventArgs args)
        {
            Inspector inspr = new Inspector();

            long _updateOID = args.Row.GetObjectID();

            //Get the layer of the selected item
            FeatureClass newFC = (FeatureClass)args.Row.GetTable();
            string updateItemName = newFC.GetDefinition().GetAliasName();
            FeatureLayer firstFeatureLayer = FeatureServiceManagement.GetFeatureLayer(updateItemName);

            //Load the inspector                
            await inspr.LoadAsync(firstFeatureLayer, _updateOID);

            args.CancelEdit();
}‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Sun, 12 Dec 2021 08:36:47 GMT

Thanks! its easily reproducible in 2.4 with the inspector.load example.

The good news is its not reproducible in 2.5 or 2.6 because of the way the editor now works with feature services and the undo stack.

As a workaround if you dont need the inspector to do anything fancy with the returned row, you can alternately read/write values using the row index as shown below:

    private void onRowEvent(RowChangedEventArgs obj)
    {
      //var testLyr = MapView.Active.Map.FindLayers("FireHydrants").First() as FeatureLayer;
      //var insp = new Inspector();
      //insp.Load(testLyr, obj.Row.GetObjectID());

      //get a row value
      var op = obj.Row["Operable"];
      //set the row value
      obj.Row["Corroded"] = 1;

      //cancel the edit
      obj.CancelEdit();
    }‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Im submitting an issue as a potential fix for 2.4 if a future patch is planned.

Re: CancelEdit in OnRowChangeEvent not working

MKa — Tue, 28 Jan 2020 15:09:19 GMT

can you think of any other work around where I can load the Inspector. I use the inspector in the row change to do a number of things and don't want to really change all my code if I don't have to? I load the inspector for this Row into an object that then has functions to ask and query information about the specific layer and related layers to the Row that is being edited and updated.

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Tue, 28 Jan 2020 20:10:20 GMT

I cant think of a workaround using the inspector. You would have to look into the core.data (geodatabase) api to get the same information.

Re: CancelEdit in OnRowChangeEvent not working

MKa — Tue, 28 Jan 2020 22:45:00 GMT

I was able to use the Row to detect if a CancelEdit had to be performed. Thank you for your help in this. Should I look into moving all of my inspector code to use Row instead? I build most of my program on the Inspector model, but maybe I should switch back to Row like we use to do with ArcObjects?

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Wed, 29 Jan 2020 00:24:38 GMT

I would keep using the Inspector pattern outside of the row events as its just too convenient to use over the 'geodatabase' api within edit operations.

Re: CancelEdit in OnRowChangeEvent not working

MKa — Thu, 06 Feb 2020 17:28:30 GMT

It seems that I can get this to work using the Rows. But I have noticed now that anytime I use Insperctor in the Row events at all, it begins to seriously slow down ArcGIS Pro. If you simply load an Inspector in the Row event, after a couple of times the system will start to degrade. Is there something that is not getting "Cleaned Up" or "Disposed" of in the Row event when you want to load an inspector from the Row that was sent in?

Re: CancelEdit in OnRowChangeEvent not working

Anonymous User — Fri, 07 Feb 2020 00:30:18 GMT

Hi M,

I'll try and replicate the issue, how are you measuring the performance degradation?