topic Re: Edit operation failed - data is currently locked? in ArcGIS Pro SDK Questions

Edit operation failed - data is currently locked?

Anonymous User — Mon, 07 Mar 2016 15:41:44 GMT

I'm trying to use an edit operation to populate attributes of a newly added field in a feature class. But the edit operation fails with the following message: "Edit operation failed. The data is currently locked by another user and cannot be saved"

My workflow is as follows:

Create new feature class using existing feature class as template (using GP) - success
Copy selected features in template feature class to the new feature class (using GP) - success
Create a new field in feature class (using GP) - success
Try to populate the new field (using this example) - error

What's locking the data? It's certainly not another user. I'm the only user. The gdb workspace is a temp folder in my user appdata dir.

The data isn't on the map or open anywhere else.

Re: Edit operation failed - data is currently locked?

Anonymous User — Sun, 12 Dec 2021 10:31:15 GMT

Hi Luke,

The following code works for me in Pro 1.3. I haven't tried release 1.2 yet. What version are you on?

   protected override async void OnClick()
    {
      //create feature class from template
      var mva = Geoprocessing.MakeValueArray(@"C:\arcgis\ArcTutor\Editing\Zion.gdb", "test", "POINT",@"C:\arcgis\ArcTutor\Editing\Zion.gdb\Ranger_stations");
      var cts = new System.Threading.CancellationTokenSource();
      var result = await Geoprocessing.ExecuteToolAsync("CreateFeatureclass_management", mva, null, cts.Token,null,GPExecuteToolFlags.RefreshProjectItems);

      //copy selected features from a layer in the map to feature class
      mva = Geoprocessing.MakeValueArray("Ranger stations", @"C:\arcgis\ArcTutor\Editing\Zion.gdb\test");
      result = await Geoprocessing.ExecuteToolAsync("CopyFeatures_management", mva,null,cts.Token,null,GPExecuteToolFlags.None);
      //add field to test feature class
      mva = Geoprocessing.MakeValueArray(@"C:\arcgis\ArcTutor\Editing\Zion.gdb\test", "someID", "LONG");
      result = await Geoprocessing.ExecuteToolAsync("AddField_management", mva, null, cts.Token, null, GPExecuteToolFlags.None);
      //calculate field value with editor callback.
      await QueuedTask.Run(() =>
      {
        using (Geodatabase geodatabase = new Geodatabase(@"C:\arcgis\ArcTutor\Editing\Zion.gdb"))
        using (FeatureClass featureClass = geodatabase.OpenDataset<FeatureClass>("test"))
        using (FeatureClassDefinition featureClassDefinition = featureClass.GetDefinition())
        {
          int someIndex = featureClassDefinition.FindField("someID");
          EditOperation editOperation = new EditOperation();
          editOperation.Callback(context =>
          {
            using (RowCursor rowCursor = featureClass.Search(null, false))
            {
              while (rowCursor.MoveNext())
              {
                using (Feature feature = (Feature)rowCursor.Current)
                {
                  feature[someIndex] = 42;
                  feature.Store();
                }
              }
            }
          }, featureClass);
          editOperation.ExecuteAsync();
        }
      });
      //delete the feature class to cleanup
    }

Just as a side note because the target feature class ("test") is not in the map, you can use the editor callback method to update values with the rowcursor as shown in the example. If the layer was in the map however, I would use the editor inspector class and editoperation modify combo to calc the field. Its just easier.

Re: Edit operation failed - data is currently locked?

Anonymous User — Sun, 12 Dec 2021 10:31:18 GMT

Hi Sean,

I tried that exact code in 1.2 (with added step to create GDB) and the editOperation returns true (I assume success), but the new field will not populate. It just remains <null>.

I want to edit datastore data, not map data, so went for the callback approach.

See code below:

protected override async void OnClick()
        {
            //create geodatabase
            var cts = new System.Threading.CancellationTokenSource();
            var mva = Geoprocessing.MakeValueArray(@"D:\Temp", "Test.gdb");
            var result = await Geoprocessing.ExecuteToolAsync("CreateFileGDB_management", mva, null, cts.Token, null, GPExecuteToolFlags.RefreshProjectItems);

            //create feature class from template
            mva = Geoprocessing.MakeValueArray(@"D:\Temp\Test.gdb", "Test", "POLYGON", templateTablePath);
            result = await Geoprocessing.ExecuteToolAsync("CreateFeatureclass_management", mva, null, cts.Token, null, GPExecuteToolFlags.RefreshProjectItems);

            //copy selected features from a layer in the map to feature class
            mva = Geoprocessing.MakeValueArray(templateTablePath, @"D:\Temp\Test.gdb\Test");
            result = await Geoprocessing.ExecuteToolAsync("CopyFeatures_management", mva, null, cts.Token, null, GPExecuteToolFlags.None);

            //add field to test feature class
            mva = Geoprocessing.MakeValueArray(@"D:\Temp\Test.gdb\Test", "someID", "LONG");
            result = await Geoprocessing.ExecuteToolAsync("AddField_management", mva, null, cts.Token, null, GPExecuteToolFlags.None);

            //calculate field value with editor callback.
            await QueuedTask.Run(() =>
            {
                using (Geodatabase geodatabase = new Geodatabase(@"D:\Temp\Test.gdb"))
                using (FeatureClass featureClass = geodatabase.OpenDataset<FeatureClass>("Test"))
                using (FeatureClassDefinition featureClassDefinition = featureClass.GetDefinition())
                {
                    int someIndex = featureClassDefinition.FindField("someID");
                    EditOperation editOperation = new EditOperation();
                    editOperation.Callback(context =>
                    {
                        using (RowCursor rowCursor = featureClass.Search(null, false))
                        {
                            while (rowCursor.MoveNext())
                            {
                                using (Feature feature = (Feature)rowCursor.Current)
                                {
                                   
                                    feature[someIndex] = 42;
                                    feature.Store();
                                }
                            }
                        }
                    }, featureClass);
                    editOperation.ExecuteAsync();
                }

            });

            MessageBox.Show("Complete");
        }

Cheers,

Luke

Re: Edit operation failed - data is currently locked?

Anonymous User — Sun, 12 Dec 2021 10:31:21 GMT

I'm also unable to edit the field using the inspector class. I've added the feature class in question to the map as a new featurelayer, and used the code below to update the custom field, but values are still null.

When I open the inspector object in debug I can even see that the field attribute is being correctly populated for each feature ("current value" attribute is correct) - but the edits don't ever get applied, despite op.Execute() returning true.

await QueuedTask.Run(() =>
{
    //add the output layer to the map
    var lyr = LayerFactory.CreateFeatureLayer(new Uri(outputFcPath), MapView.Active.Map, LayerPosition.AddToTop);
    var cur = lyr.Search();

    //populate the TEST field
    if (lyr.CanEditData())
    {
       
        while (cur.MoveNext())
        {
            var insp = new Inspector();
            var feature = cur.Current;
            insp.Load(lyr, feature.GetObjectID());
            insp["TEST"] = "testvalue";
            var op = new EditOperation();
            op.Name = "Populate test field";
            op.Modify(insp);
            op.Execute();
        }
    }
});

Re: Edit operation failed - data is currently locked?

Anonymous User — Sat, 12 Mar 2016 00:18:21 GMT

Luke,

Sorry about the delay, its dev summit week. I tried to reproduce this at 1.2 and it works ok for me with that code and the arc tutorial data. Something is blocking your layers or workspace but I cant think of anything obvious at this point. If nobody else chimes in here I would contact tech support and be prepared to supply the code and data for the reproducible case you have.

Re: Edit operation failed - data is currently locked?

ThomasEmge — Mon, 14 Mar 2016 18:58:50 GMT

Luke,

please do take a look at the sample code again. I believe you are missing the context.invalidate call.

However for just changing a single attribute using the callback approach is overkill. A single edit operation with multiple Modify calls should suffice.

Thomas

Re: Edit operation failed - data is currently locked?

Anonymous User — Tue, 15 Mar 2016 13:38:30 GMT

Hi Thomas,

I had included the invalidate call originally but it make no difference unfortunately. Plus from what I'm reading on the editing concepts page, it would seem it's only necessary when I want to refresh the map (which I don't need).

Refreshing the map (or the attributes table) is only needed when the Callback method is used to edit datasets from datastores.
To refresh the map to reflect changes made in the data, call the IEditContext.Invalidate method on the IEditContext parameter on the Action delegate passed into the callback.
Note: If it is known that the edits being made are not going to affect the rendering of any layers, you could avoid calling it at all; or if you knew it would only affect color and not location, you could call it at the end of store.

As I'm not editing data that's on the map - do I have a choice to not use the callback approach? I thought the inspector was only for map data.

Luke

Re: Edit operation failed - data is currently locked?

Anonymous User — Tue, 15 Mar 2016 15:23:47 GMT

Hi Sean,

Hope the summit was good this year! Thanks for testing that - i'll revisit my code this week and perhaps try some other data. Must be something on my side...

Cheers,

Luke

Re: Edit operation failed - data is currently locked?

ThomasEmge — Tue, 15 Mar 2016 18:11:47 GMT

Luke,

you were stating earlier that the field remains <null>. Depending on when and where you are checking the changed attribute value the invalidate is required as Pro might be showing you a cached state of the data and unless you invalidate the cached state is considered the current state.

Please do take a look at ArcGIS Pro 1.2 API Reference Guide for the overloaded Create method. We have method signatures that accept a table as an argument. A feature class is inheriting from table so you can have multiple feature classes participate in a single edit operation regardless if they are shown in the map or not. Please keep in mind that you will still need to save the edits done by the edit operation in order to be persisted in the geodatabase.

The alternative is ArcGIS Pro 1.2 API Reference Guide which is new at 1.2 and is happening as a single source on the geodatabase.

Thomas

Re: Edit operation failed - data is currently locked?

MaxMax2 — Tue, 04 Jul 2017 09:42:07 GMT

Luke Coursey‌ I have the same problem. Did you find a solution?

I made simple test: I executed Add Field tool on shapefile and found 3 (!!!) locks near shp file after tool has finished. Seems like a bug on the ESRI side. I sure that Add Field shouldn't lock dataset. Sean Jones‌ Did you reproduce the issue?

Re: Edit operation failed - data is currently locked?

Anonymous User — Wed, 05 Jul 2017 16:54:30 GMT

Yes this is an issue after Add Field or anything that grabs a schema lock. This was fixed in 2.0.

Re: Edit operation failed - data is currently locked?

MaxMax2 — Thu, 06 Jul 2017 02:56:30 GMT

Hmm.. As I said in my previous post Add Field with shapefile as an input table produces lock files near shp. These lock files will be removed only when I close ArcGIS Pro. Is it OK? I suppose tools that change schema must delete locks were set by them. I see this behavior in 2.0.

Re: Edit operation failed - data is currently locked?

TimothyMichael — Tue, 18 Jul 2017 12:46:52 GMT

I am also getting the same behavior at 2.0, attempting to modify features in a file geodatabase. Closing and reopening ArcGIS Pro 'fixes' the issue.

Re: Edit operation failed - data is currently locked?

Anonymous User — Thu, 20 Jul 2017 20:13:09 GMT

Max and Tim, what are your workflows here to add the field and do an edit?

Are you adding a field manually or through code?

What sorts of edits are you making after that? Any .callback code?

Thanks

Sean

Re: Edit operation failed - data is currently locked?

MaxMax2 — Fri, 21 Jul 2017 02:54:11 GMT

Hi Sean,

My workflow was:

create feature class via executing appropriate geoprocessing tool;
get path to created feature class as result of previous step;
get Item by this path (through ItemFactory) and add feature layer by this item to a map;
add fields to the created feature class via executing appropriate geoprocessing tool;
execute EditOperation via callback which populates the feature class with some features.

In 1.4 this stuff works fine, in 2.0 not. Edit operation was failed with the "Edit operation failed. The data is currently locked by another user and cannot be saved" message. I even didn't fall to the callback's body.

But I fixed this with moving step 3 (adding of feature layer to a map) to the end of instructions list above. I decided to make a clean test creating test add-in and reproduce this workflow, and got no errors... So it is kind of mystic.

But as I said in my previous post "Add Field with shapefile as an input table produces lock files near shp". I mean executing the tool from ArcGIS Pro, not programmatically. Unfortunately I didn't see any reaction of the ESRI staff to this behavior. For me it seems like a bug.

Re: Edit operation failed - data is currently locked?

Anonymous User — Fri, 21 Jul 2017 23:26:33 GMT

You'll see a bunch of *.lock files in a geodatabase during normal operation. These are either shared or exclusive locks depending on what you are doing. Schema locks are a type of exclusive lock which are set on a dataset when its modified (add field, field index etc). Exclusive locks are normally removed when the operation completes. Shared locks are removed when the dataset is no longer being referenced by anything. In a file geodatabase you can get more information about locks via ArcObjects. For enterprises geodatabases there is a dialog (administer geodatabase in ArcMap or database properties in Pro).

For this particular bug, add field wasn't removing the exclusive lock in a timely manner.

Re: Edit operation failed - data is currently locked?

MaxMax2 — Sun, 23 Jul 2017 08:05:16 GMT

Yes, I know about exclusive/shared locks since I work with them using ArcObjects. In ArcGIS Pro 2.0 I see that Add Field doesn't delete locks were set by this tool for shapefiles. Do you confirm this issue?

Re: Edit operation failed - data is currently locked?

Anonymous User — Mon, 24 Jul 2017 21:10:00 GMT

Hi Max,

I still cant reproduce this with shapefiles. I tried a few things, through the UI with GP tools and the editor to create a shapefile, add a field and make some edits. No locking persisted.

Programmatically, create a shape file, add a field and calc values with editor callback. The shapefile wasn't added to the map during this. No locking persisted.

Programmatically, created a shapefile, added a field, added the shapefile to a new map, calc values with edit operation (callback isn't recommended here as the layer is in the map). No locking persisted.

In all three cases there are three shared resource lock files (*.sr.lock) remaining, but this is normal. They are removed when Pro exits, assuming nothing else is referencing the shape file.

Re: Edit operation failed - data is currently locked?

RichardReinicke — Wed, 23 Aug 2017 10:05:52 GMT

Hi, I`m also encountering lock problems in the ArcGIS Pro SDK while creating and editing FGDB Feature Classes. Creation works without errors but the population with EditOperation only work once.

I`m calling

await Project.Current.SaveEditsAsync();

after my whole process is done, which should finish all remaining edit locks, or not? My code is shown here:
Writing Features into FGDB very slow

I`m repeating this multiple times in my running ArcGIS Pro session. User is selecting a MeasureSet, if its not availabale in FGDB it will be fetached from Postgres DB, written into FGDB and loaded into the map.

This works only once. The second time, fc is created in DB but I never enter my EditOperation callback, instead I get "ArcGIS.Core.Data.GeodatabaseTableException".

I have to reopen ArcGIS Pro to get it again work only once!!!

So this also doesn`t get fixed when migrating to 2.x?