topic Re: Bug in Modifying Feature? in ArcGIS Pro SDK Questions

Bug in Modifying Feature?

SusanFarley — Mon, 23 Sep 2019 20:59:33 GMT

I have two Node layers in my map with the second layer being a copy of the first. I am enabling users to merge similar nodes to help clean up data, but all alterations are done on the copy layer in case the user later decides those nodes shouldn't be merged. So in my code I have:

//MergeRow is the new row and SelectedNodes is the list of rows to be deleted

public async Task<bool> MergeNodes(DataRow MergedRow, List<DataRow> SelectedNodes) {

var modifyFeature = new EditOperation();

modifyFeature.Name = "Merged Nodes";

//Other stuff

modifyFeature.Delete(MergeNodeLayer, Int64.Parse(SelectedNodes[0][oidNum].ToString()));

modifyFeature.Execute();

return true;

}

Even though I pass in the MergeNodeLayer, it deletes the node from both the control layer and the new layer. Is this a bug with delete or am I doing something wrong? The nodes on both layers have the same oids since it is a direct copy so it is deleting the correct one from each layer, but it should only be deleting the one for the layer I passed in.

Thank you,

Susan

Re: Bug in Modifying Feature?

Anonymous User — Mon, 23 Sep 2019 23:48:08 GMT

Susan,

It sounds like both layers in the map may be pointing to the same feature class. You can check this under the layer properties source tab for each.

How did you copy the layer?

Re: Bug in Modifying Feature?

SusanFarley — Tue, 24 Sep 2019 12:03:47 GMT

await QueuedTask.Run(() => {

if (LayerFactory.Instance.CanCopyLayer(frmLayer)) {

var newLayer = LayerFactor.Instance.CopyLayer(fmLayer, MapView.Active.Map);

newLayer.SetName (String.Format("{0}_Copy", frmLayer.Name)

}

How do I make it create a copy of the featureclass as well?

Thank you,

Susan

Re: Bug in Modifying Feature?

Anonymous User — Sun, 12 Dec 2021 09:20:24 GMT

Susan,

The easiest way is to use the geoprocessing copy features tool.

      var mva = Geoprocessing.MakeValueArray(@"Hydrant", @"D:\arcgis\ArcTutor\Editing\Zion.gdb\hydrant2");
      Geoprocessing.ExecuteToolAsync("CopyFeatures_management", mva);‍‍

This will copy selected features from the input layer (or all if none are selected) into the new feature class and add a new layer to the current map. You wont need to copy the layer with the LayerFactory.

Re: Bug in Modifying Feature?

SusanFarley — Wed, 25 Sep 2019 17:44:44 GMT

I'm guessing the C# version of that is:

foreach (BasicFeatureLayer fmLayer in lyr) //there is a node layer and a link layer

{

string newLayerName = String.Format("{0}_NewCopy", frmLayer.Name);

string pathToFeature = $@"{gdbPath}\{newLayerName}";

List<object> args = new List<object>() { gdbPath, newLayerName, featType.ToString(), "",

hasMeasure, "DISABLED"};

var res = await Geoprocessing.ExecuteToolAsync("management.CreateFeatureClass",

Geoprocessing.MakeValueArray(args.ToArray()));

await QueuedTask.Run(() => {

var mva = Geoprocessing.MakeValueArray(fmLayer, pathToFeature );

Geoprocessing.ExecuteToolAsync("management.CopyFeatures", mva);

}

Two questions:

Is there a faster way to accomplish this? For two small layers (only 8270 nodes), this takes 1 minute and 24 seconds. The 1:24 is for copying both layers.
On the new copies of the layers, it always seems to remove the first column of the attribute table (be it FID or Object_ID), replace it with Object_Id, but restart the numbering so that it is different than the original layer. Is there a way to prevent this? The user is looking or nodes and links in the "original layers" to merge in the "copied layers" so this causes an issue since

var modifyInspector = new Inspector(true);

modifyInspector.Load( MergeNodeLayer, refId); // this looks at the first column data and, with it being

//renumbered, will not edit the same node selected from the first layer as in the

//merge layer.

Example:

Original Layer

FID Shape Name Type

0 .... Street PolyLine

1 .... Road PolyLine

Copied Layer

OBJECTID Shape Name Type

1 .... Street PolyLine

2 .... Road PolyLine

Re: Bug in Modifying Feature?

Anonymous User — Sun, 12 Dec 2021 09:20:27 GMT

I hadn't considered copyfeatures re-initializing the object ids, but that makes sense since the input can be a layer. Surprisingly it also happens if you specify the featureclass as the input.

Two alternatives. Use the geoprocessing copy tool instead, which only takes featureclasses as input. This will preserve the object ids and should be faster too as it doesn't interrogate the layer.

      var mva = Geoprocessing.MakeValueArray(@"D:\arcgis\ArcTutor\Editing\Zion.gdb\Hydrant", @"D:\arcgis\ArcTutor\Editing\Zion.gdb\hydrant2");
      Geoprocessing.ExecuteToolAsync("Copy_management", mva);‍‍

The featureclass to featureclass tool is the other option but I haven't tried that.

There's no SDK API calls to copy featureclasses apart from going through the geoprocessing tools as the UI does.

Re: Bug in Modifying Feature?

SusanFarley — Wed, 25 Sep 2019 19:26:38 GMT

I changed my code to (I'm guessing C# translation of your code above):

foreach (BasicFeatureLayer fmLayer in lyr) //there is a node layer and a link layer

{

string newLayerName = String.Format("{0}_NewCopy", frmLayer.Name);

string pathToFeature = $@"{gdbPath}\{newLayerName}";

string pathFromFeature = $@"{gdbPath}\{frmLayer.Name}";

var mva = Geoprocessing.MakeValueArray(pathFromFeature , pathToFeature );

var res = await Geoprocessing.ExecuteToolAsync("management.Copy", mva);

}

And it does nothing so I'm guessing I am doing something wrong. Any ideas what?

Thank you,

Susan

Re: Bug in Modifying Feature?

Anonymous User — Wed, 25 Sep 2019 20:01:49 GMT

Hmm, it looks reasonable. The syntax for the GP tool name ("management.Copy" or ""Copy_managment") will work either way so thats not the issue.

Make sure the pathFromFeature and pathToFeature strings make sense for a featureclass and you could also try those manually in the geoprocessing copy tool to see if it works there.

Your using the layer name as the feature class input which may not always be the same, particularly if the layer name has a space, the corresponding featureclass name wont.

Lastly, check the res variable (an IGPResult) to see the error message.

Re: Bug in Modifying Feature?

SusanFarley — Thu, 26 Sep 2019 14:02:34 GMT

The problem is that I was trying to Copy the FeatureLayer and that doesn't work with Copy. Do you know how I can get the Feature Dataset from the Feature Layer?

Thank you,

Susan

Re: Bug in Modifying Feature?

SusanFarley — Thu, 26 Sep 2019 19:39:36 GMT

I'm not sure if this is correct, but I have been trying this which is also not working.

foreach (BasicFeatureLayer fmLayer in lyr) //there is a node layer and a link layer

{

string newLayerName = String.Format("{0}_NewCopy", frmLayer.Name);

string pathToFeature = $@"{gdbPath}\{newLayerName}";

string pathFromFeature = $@"{gdbPath}\{frmLayer.Name}";

await QueuedTask.Run(() =>

{

using (Table tbl = fmLayer.GetTable())

{

var mva = Geoprocessing.MakeValueArray(tbl, pathToFeature );

var res = await Geoprocessing.ExecuteToolAsync("management.Copy", mva);

}

res.Exception is null, res.Status = WaitingToRun, and res.Result = null.

I noticed that mva contains only strings when it is sent to Copy_management. Do you know how I correct this?

Thank you,

Susan

Re: Bug in Modifying Feature?

Anonymous User — Sun, 12 Dec 2021 09:20:30 GMT

Hi Susan,

To get the underlying featureclass path from a feature layer you'll have to concatenate the datastore path and the featureclass name. You can then feed this into the "mva" then into the geoprocessing tool. Note that if the featureclass was in a featuredataset in the datastore you would include that in the path too (determined from featureclass.GetFeatureDataset()).

Here's an example

      QueuedTask.Run(async () =>
      {
        //find hydrant layer
        var hydLayer = MapView.Active.Map.FindLayers("Hydrant").FirstOrDefault() as FeatureLayer;

        //get the underlying featureclass path for the layer
        var hydClass = hydLayer.GetFeatureClass();

        //get the datastore for the featureclass
        var hydStore = hydClass.GetDatastore();

        //concat hydrant path (datastore and featureclass name)
        var hydPath = hydStore.GetPath().AbsolutePath + @"/" + hydClass.GetName();

        //make the value array and pass to the GP tool
        var mva = Geoprocessing.MakeValueArray(@hydPath, $@"{hydPath}2");
        await Geoprocessing.ExecuteToolAsync("Copy_management", mva);
      });‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: Bug in Modifying Feature?

SusanFarley — Mon, 30 Sep 2019 15:58:21 GMT

I must be doing something wrong. Here is my code:

public async Task<string[]> CopyLayer()

{

var lyr = _arcFac.MainMapView.Map.GetLayersAsFlattenedList();

string[] newLayers = new string[lyr.Count]();

await QueuedTask.Run(() =>

{

foreach (BasicFeatureLayer fmLayer in lyr)

{

var hydLayer = MapView.Active.Map.FindLayers(fmLayer.Name).FirstOrDefault() as FeatureLayer; //I also tried this with = fmLayer as FeatureLayer and got the same result

var hydClass = hydLayer.GetFeatureClass();

var hydStore = hydClass.GetDatastore();

var hydPath = hydStore.GetPath().AbsolutePath + @"/" + hydClass.GetName();

var mva = Geoprocessing.MakeValueArray(@hydPath, $@"{hydPath}2");
var res = Geoprocessing.ExecuteToolAsync("Copy_management", mva);

}
});

}

Though this does create lock files, it does not create new layers for me. I was originally running it with files on a network share drive, I moved those files locally and tried again. I get the same result. "res" does not contain an error and just says awaiting thread to complete. Any ideas? I cannot send you my direct code or my shape files. Sorry.

Thank you,

Susan

Re: Bug in Modifying Feature?

Anonymous User — Mon, 30 Sep 2019 17:07:51 GMT

Hi Susan,

Finding the layers twice is a bit of overkill so assuming you just want to work with featurelayers, you can change the first list to:

var lyr = MapView.Active.Map.GetLayersAsFlattenedList().OfType<FeatureLayer>();‍

Your foreach loop then looks like:

foreach (var fmLayer in lyr)‍

then you can get the featureclass from your fmLayer instead of hydlayer etc.

Next, set a break point and run the add-in through the debugger, stepping through the code to see if the values make sense. Ideally through each loop the mva variable should look correct:

Re: Bug in Modifying Feature?

SusanFarley — Mon, 30 Sep 2019 19:55:45 GMT

My mva is:

"C:/Temp/all_nodes_shp"

"C:/Temp/all_nodes_shp2"

and my res2 is:

AyncState = null

CancellationPending = false

CreationOptions = None

Exception = null

ID = some number

Result = null

Status = WaitingToRun

Does it matter that I am using shape files? Should the hydPath include the .shp extention?

Thank you,

Susan

Re: Bug in Modifying Feature?

SusanFarley — Mon, 30 Sep 2019 20:10:10 GMT

That was it. It needed the extension.

Thank you,

Susan

Re: Bug in Modifying Feature?

SusanFarley — Mon, 30 Sep 2019 20:27:57 GMT

Do you know how to programmatically get the file extension since I won't know if the user is using shapefiles, layers, or a gdb file?

Thank you,

Susan

Re: Bug in Modifying Feature?

Anonymous User — Sun, 12 Dec 2021 09:20:32 GMT

Hi Susan,

Yes, again its a bit convoluted.

        //get the datastore for the featureclass
        var hydStore = hydClass.GetDatastore();

        if (hydStore is FileSystemDatastore)
        {
          var cp = hydStore.GetConnector() as FileSystemConnectionPath;
          var t = cp.Type; //shapefile or raster?
        }‍‍‍‍‍‍‍‍

From the featureclass you get the datastore which is a type of filesystem (shapefiles or raster), local or enterprise. For the filesystemdatastore you can further identify a shapefile or raster source. You cant directly get the shapefile extension.

Ive asked the geodatabase team to make this whole thing easier...

Re: Bug in Modifying Feature?

SusanFarley — Mon, 07 Oct 2019 20:35:19 GMT

Thank you! This works great for shape files and raster files, but I was just testing for files in a geodatabase and it does not work. We are so close.

foreach (BasicFeatureLayer fmLayer in lyr)

{

var hydLayer = fmLayer as FeatureLayer

var hydClass = hydLayer.GetFeatureClass();

var hydStore = hydClass.GetDatastore();

string fileExtention = "";

if (hydStore is FileSystemDatastore)

{

var cp = hydStore.GetConnector() as FileSystemConnectionPath;

if (cp.Type == FileSystemDataStpreType.Shapefile)

fileExtention = ".shp";

}

//fileExtention is an empty string in the case of a geodb.

var hydPath = hydStore.GetPath().AbsolutePath + @"/" +

hydClass.GetName() + fileExtention;

var mva = Geoprocessing.MakeValueArray(@hydPath, $@"{hydPath}2") + fileExtention;
var res = Geoprocessing.ExecuteToolAsync("Copy_management", mva);

}

Re: Bug in Modifying Feature?

Anonymous User — Sun, 12 Dec 2021 09:20:35 GMT

Hi Susan,

I'd probably just do the extension as part of the mva string so it becomes:

        //concat hydrant path (datastore and featureclass name)
        var hydPath = hydStore.GetPath().AbsolutePath + @"/" + hydClass.GetName();

        //make the value array and pass to the GP tool
        var mva = Geoprocessing.MakeValueArray(@hydPath + fileExtention, $@"{hydPath}2" + fileExtention);
        await Geoprocessing.ExecuteToolAsync("Copy_management", mva);‍‍‍‍‍‍

This should work for all types.

Re: Bug in Modifying Feature?

SusanFarley — Tue, 08 Oct 2019 12:03:52 GMT

It works for everything except when the files are part of a gdb file. I have a SmallTest.gdb with two layers in it. hydstor is a Geodatabase. When I try the code above to create copies of them, it doesn't. There are no errors. The res is:

AyncState = null

CancellationPending = false

CreationOptions = None

Exception = null

ID = some number

Result = null

Status = WaitingToRun

So it is like before when I didn't have the proper file extension.

Thank you,

Susan