topic Re: Arcade scripting in Attribute Rules in ArcGIS Pro Questions

Arcade scripting in Attribute Rules

LorindaGilbert — Thu, 01 Apr 2021 18:15:56 GMT

Hi All,

I've gotten over my hurtle with creating attribute rules now, but I'm a newbie with Arcade - either in the WAB or in Pro.

I'm attempting to create a Calculation rule that is based on If Then Else statements. I am getting a message about Invalid expression. Error on line 8. Open parenthesis expected.

Here's the beginning of my expression; at the end I do have return eru; As this is the field that I am attempting to calculate. There will be three of these set up so as to do the required pre-calcs before getting the last two calculations that are the real ones to be returned and saved.

It is highly likely that I'm missing just something simple, I thought that I was following the examples that I found for doing calcs and using if statements. But ....

if billclass == 'D'
eru = 0
else if billclass in ('V','I','H')
eru = Round(parea/43560,2)
else if billclass == 'R'
eru = Round(parea*(2000/7760)/2000,2)
else if billclass in ('A','O')

.....

Thanks,

Lorinda

Re: Arcade scripting in Attribute Rules

Luke_Pinner — Thu, 01 Apr 2021 18:43:52 GMT

You're missing a statement after the last.else if.

Re: Arcade scripting in Attribute Rules

JoeBorgione — Thu, 01 Apr 2021 19:21:31 GMT

var fs = FeatureSetByName($datastore,"IDF_Stormwater"); var billclass = fs["MultiUserType"]; var eru = fs["ERUArea"]; var parea = fs["IDFArea"]; var pimparea = fs["ImperviousArea"]; var dwell = fs["Dwellings"]; if billclass == 'D' eru = 0 else if billclass in ('V','I','H') eru = Round(parea/43560,2) else if billclass == 'R' eru = Round(parea*(2000/7760)/2000,2) else if billclass in ('A','O') //// Need something here as Luke points out

I took the liberty to copy and paste your code into the code editor; makes it easier to read. If you expand the three dots to expand the tool bar and then choose the "Insert/Edit Code Sample" tool that looks like this: </> you can format your code as it is meant to be read. I used JavaScript for this...

Re: Arcade scripting in Attribute Rules

LorindaGilbert — Thu, 01 Apr 2021 19:25:06 GMT

Not really, the remainder of the script is after a few more lines:

else if billclass = 'R' && pimparea = 0
eru = Round(parea*(2000/7760)/2000,2)
else if billclass = 'R' && pimarea > 0
eru = (Round(pimparea/2000,2)

return eru;

Re: Arcade scripting in Attribute Rules

LorindaGilbert — Thu, 01 Apr 2021 19:26:39 GMT

My full script is this:

if billclass == 'D'
eru = 0
else if billclass in ('V','I','H')
eru = Round(parea/43560,2)
else if billclass == 'R'
eru = Round(parea*(2000/7760)/2000,2)
else if billclass in ('A','O')
eru = Round(pimparea/2000,2)
else if billclass == 'M' && dwell in (1,2)
imparea = parea*0.3192
else if bill class == 'M' && dwell in (3,4)
imparea = parea*0.5093
else if billclass == 'M' && dwell > 4
imparea = parea*0.5613
else if billclass in ('M','A','O') && pimparea = 0
eru = Round(pimpara/2000,2)
else if billclass = 'R' && pimparea = 0
eru = Round(parea*(2000/7760)/2000,2)
else if billclass = 'R' && pimarea > 0
eru = (Round(pimparea/2000,2)

return eru;

Yes, I see that I am missing an end if it is needed.

Re: Arcade scripting in Attribute Rules

JoeBorgione — Thu, 01 Apr 2021 19:31:32 GMT

else if billclass = 'R' && pimparea = 0 /* Could this be a problem */ eru = Round(parea*(2000/7760)/2000,2) else if billclass = 'R' && pimarea > 0 /* as well as this */ eru = (Round(pimparea/2000,2) return eru; /* else if billclass == ('R' && pimparea = 0) ... else if billclass == ('R' && pimarea > 0) */

Re: Arcade scripting in Attribute Rules

Luke_Pinner — Thu, 01 Apr 2021 22:32:24 GMT

eru = (Round(pimparea/2000,2)

return eru;

Either remove the bracket before Round or add a closing bracket.

Re: Arcade scripting in Attribute Rules

JoeBorgione — Thu, 01 Apr 2021 22:34:02 GMT

Good Catch @Luke_Pinner !

Re: Arcade scripting in Attribute Rules

Luke_Pinner — Thu, 01 Apr 2021 23:12:02 GMT

@LorindaGilbert wrote:
Not really, the remainder of the script is after a few more lines:

Which is where the error is.

Re: Arcade scripting in Attribute Rules

LorindaGilbert — Fri, 02 Apr 2021 00:36:24 GMT

Alas, that didn't solve the expected open parenthesis error.

Haven't checked what Joe Borgione mentioned with the two items on one line yet and the &&. Had to start on another project in FME right now. Will try this again tomorrow.

Re: Arcade scripting in Attribute Rules

Luke_Pinner — Fri, 02 Apr 2021 11:44:42 GMT

Not altogether familiar with arcade, but it uses Javascript like syntax.

So your statement should look something like:

if (condition1) { // block of code to be executed if condition1 is true } else if (condition2) { // block of code to be executed if condition1 is false and condition2 is true } else { // block of code to be executed if the condition1 is false and condition2 is false }

For your code, something like:

if (billclass == 'D') { eru = 0 } else if (['V','I','H'].indexOf(billclass) >= 0) { eru = Round(parea/43560,2) } else if (billclass == 'R') { eru = Round(parea*(2000/7760)/2000,2) } etc... return eru;

Note there's no "in" operator, so even if you got the if and else if syntax correct, you'll get a Syntax Error: Binary Operator not recognised in so I've used the indexOf function and I've changed your python-like tuples ('V','I','H') to JavaScript-like arrays ['V','I','H']

I recommend you look at the arcade reference.

Re: Arcade scripting in Attribute Rules

KenBuja — Fri, 02 Apr 2021 13:30:20 GMT

You can leave off the brackets if there is only one line in the condition, although it's good practice to use them. This code does work

var test = ""; if ($feature.name1 == 'value1') test = 1; else if ($feature.name1 == 'value2') test = 2; return test;

Re: Arcade scripting in Attribute Rules

LorindaGilbert — Wed, 07 Apr 2021 16:16:21 GMT

Hi All,

I've gotten past that first hurtle, have three attribute rules validating and saved in the project - still have to test to see if they are doing as expected though. That's another day.

I've now run into a situation where I need to do another if/then/else statement, but need to have it with two parts. If field1 == value && field2 between "0123" and "1789" - yes, the values are stored as text.

Can this be done? I've tried to find some examples, but may not be putting the proper search string in.

Thanks for your help!

Lorinda

Re: Arcade scripting in Attribute Rules

JoeBorgione — Wed, 07 Apr 2021 17:02:53 GMT

Check out the logic page for arcade

Also, you can use the Arcade Playground to do just that: play with Arcade. I played around with this statement there until I got it right...

var field1 = 12 var field2 = 250 if (field1 == 12 && field2 < 300 && field2 > 200){ Console("yay")}

The playground is the only place I know where the Console() function works. It's the same as the print() function in python.

Re: Arcade scripting in Attribute Rules

LorindaGilbert — Wed, 07 Apr 2021 20:25:24 GMT

Where do you find this playground for testing commands? I've not seen it yet. I can see where it could be really useful.

BTW, love your 'signature'; I can relate 😅

Thanks,

Lorinda

Re: Arcade scripting in Attribute Rules

JoeBorgione — Wed, 07 Apr 2021 20:29:46 GMT

click in the link in my post...

Also, depending on what you are using, you will be presented the same Arcade edit window, which allows you, test, access global variables and functions.

Re: Arcade scripting in Attribute Rules

LorindaGilbert — Wed, 07 Apr 2021 20:40:03 GMT

Thanks, was going to edit the post to say that I saw the link afterwards, but you beat me to it. Hazards of having an eye infection, things are a bit blurry.

I'll take a look at your suggestions, I've been wracking my brain trying to figure out the proper terms for looking up some of these things and having troubles with it. But bookmarking several items for the next go around with this exercise. Have a few legacy apps to migrate to new and hopefully improved processes.

Thanks,

Lorinda

Re: Arcade scripting in Attribute Rules

JoeBorgione — Wed, 07 Apr 2021 20:41:36 GMT

I've been attending the developers summit yesterday and today, and have learned a ton of Arcade tips and tricks...

Re: Arcade scripting in Attribute Rules

LorindaGilbert — Mon, 26 Apr 2021 20:47:53 GMT

Hi All,

I really appreciate the help that's being offered. I've been searching for how to do nested if then now and have gotten hung up again. I'm sure that it is something that I'm overlooking, but I've tried many iterations and still get that I have 'Unexpected Identifier' on line 31, the last else if. This is the testing that I'm using in the playground.

Thanks,

Lorinda

var billclass = "V"
var dor = 6400
var parea = 3457
var newfee = 0
var pimparea = 1500;
var dwell = 2;
var ouswmm = "Y"

if (parea > 0 && (billclass == "V") && (dor < 6647 && dor > 5399)) {
newfee = Round(((parea/43560)*(12*0.1*5.99))+119.88,2)
}
else if (parea > 43560 && (billclass == "V") && (dor < 5400 || dor > 6647)) {
newfee = Round((parea/43560)*(12*(4.0 +(0.2*5.99))),2)
}
else if (parea <= 43560 && (billclass == "V")) {
newfee = Round((12*(4.0 +(0.2*5.99))),2)
}
else {
if ((billclass == "M") && ((pimparea/2000) < (1.15 * dwell)) && (ouswmm == "N")) {
newfee = Round((pimparea/2000)*(12*(4.00 + (1.0* 5.99))),2)
}
else if ((billclass == "M") && (pimparea/2000 < (1.15 * dwell)) && (ouswmm == "Y")) {
newfee = Round((pimparea/2000)*(12*(4.00 + (0.3* 5.99))),2)
}
else if ((billclass == "M") && (pimparea/2000 >= (1.15 * dwell)) && (ouswmm == "N")) {
newfee = ((119.88*1.15)*dwell)
}
else if ((billclass == "M") && (pimparea/2000 >= (1.15 * dwell)) && (ouswmm == "Y")) {
newfee = ((69.56*1.15)*dwell)
}
else if billclass == "M" && newfee < 5 {
newfee = 5
}
}
}
Console (newfee)

Re: Arcade scripting in Attribute Rules

KenBuja — Tue, 27 Apr 2021 14:08:50 GMT

You're missing parenthesis around the last else if and you have an extra "}" at the end. It's easier to see this if you indent the code.

var billclass = "V" var dor = 6400 var parea = 3457 var newfee = 0 var pimparea = 1500; var dwell = 2; var ouswmm = "Y" if (parea > 0 && (billclass == "V") && (dor < 6647 && dor > 5399)) { newfee = Round(((parea / 43560) * (12 * 0.1 * 5.99)) + 119.88, 2) } else if (parea > 43560 && (billclass == "V") && (dor < 5400 || dor > 6647)) { newfee = Round((parea / 43560) * (12 * (4.0 + (0.2 * 5.99))), 2) } else if (parea <= 43560 && (billclass == "V")) { newfee = Round((12 * (4.0 + (0.2 * 5.99))), 2) } else { if ((billclass == "M") && ((pimparea / 2000) < (1.15 * dwell)) && (ouswmm == "N")) { newfee = Round((pimparea / 2000) * (12 * (4.00 + (1.0 * 5.99))), 2) } else if ((billclass == "M") && (pimparea / 2000 < (1.15 * dwell)) && (ouswmm == "Y")) { newfee = Round((pimparea / 2000) * (12 * (4.00 + (0.3 * 5.99))), 2) } else if ((billclass == "M") && (pimparea / 2000 >= (1.15 * dwell)) && (ouswmm == "N")) { newfee = ((119.88 * 1.15) * dwell) } else if ((billclass == "M") && (pimparea / 2000 >= (1.15 * dwell)) && (ouswmm == "Y")) { newfee = ((69.56 * 1.15) * dwell) } else if (billclass == "M" && newfee < 5) { newfee = 5 } } Console(newfee)