topic Re: arcpy.da.UpdateCursor fails to update geometry in ArcGIS API for Python Questions

arcpy.da.UpdateCursor fails to update geometry

BledarBirbo1 — Sun, 12 Dec 2021 09:39:38 GMT

Hi.

I am having the following issue when i try to update an SDE Geodatabase featureclass geometry from arcpy

Using:

ArcGIS 10.3.1

SQL Server Geodatabase

Line featureclass with enabled: Archiving , Editor Tracking and Registered as Versioned.

The line featureclass also participates in a replica as the source layer.

The line fetureclass can be edited fine from arcmap.

The issue:

Because we do receive new updated line geometries (features) from another source i have bulid a python script that joins the 2 datasets based on an attribute key and and tries to update the geometry on the Line Featureclass.

I am using the following code tu update the geometry.

fieldNames = ['ID', 'SHAPE@','SHAPE@WKT']
edit.startEditing()
edit.startOperation()
with arcpy.da.UpdateCursor(line_layer, fieldNames) as updateCursor:
 for tmpRow in updateCursor:
    tmpRow[1] = #newgeometry that was read previusly
    updateCursor.updateRow(tmpRow)
edit.stopOperation()
edit.stopEditing(True)‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

The code runs without any error but the geometry is not updated. I tested the code for other attributes and they were updated correctly.

Any ideas ?

Thanks.

Re: arcpy.da.UpdateCursor fails to update geometry

IanMurray — Thu, 26 Jan 2017 13:50:35 GMT

after you set the values with the cursor for the row, you need to have cursor.updateRow(tmpRow), otherwise it doesn't save the values.

Add the following to a new line after the current line 6 with the same indent as line 6:

cursor.updateRow(tmpRow)

See https://pro.arcgis.com/en/pro-app/arcpy/data-access/updatecursor-class.htm example 1 for another example if needed.

Re: arcpy.da.UpdateCursor fails to update geometry

BledarBirbo1 — Thu, 26 Jan 2017 14:00:27 GMT

Hi.

There is an update command i just forgot to copy it in this post.

So that do not help.

Re: arcpy.da.UpdateCursor fails to update geometry

KimOllivier — Fri, 27 Jan 2017 09:40:10 GMT

You have skipped the key item - what geometry are you adding? How did you get it? Is it really a geometry?

I don't think you can join two featureclasses and retrieve both geometries at once. You are probably just replacing the geometry with itself.

I would create a python dictionary of source geometries keyed by the id using a list comprehension and a ReadCursor.

Then close the cursor and open an UpdateCursor and iterate over the list. You could even speed it up

by using an SQL query to only select records to be updated with an IN sql clause of the keys.

Re: arcpy.da.UpdateCursor fails to update geometry

BledarBirbo1 — Fri, 27 Jan 2017 10:45:04 GMT

The geometry that is beeing assigned is not the same and is fine.

Re: arcpy.da.UpdateCursor fails to update geometry

KimOllivier — Fri, 27 Jan 2017 11:30:11 GMT

Ok, well how many features are in the layer definition?

Can you print out the ID and featurecount?

I assume you are using some sort of index based on the ID to get the respective geometry to add?

Why are you getting the geometry out twice in the updateCursor?

Re: arcpy.da.UpdateCursor fails to update geometry

BledarBirbo1 — Sun, 12 Dec 2021 09:39:41 GMT

There are 300 new features that are beeing read from a SearchCursor.

Their geometry is then stored on a python list as Geometry object and as WKT plus the OBJECTID

During the UpdateCursor each feature is matched with the ones that were read before from the python list based on OBJECTID. If matched then the

 tmpRow[1] = objectlist[matchedindex] geometry.
#even constructing a new Geometry from the WKT like this does not work 
tmpRow[1] = arcpy.FromKWT(objectlist[matchedindex] wkt)

Re: arcpy.da.UpdateCursor fails to update geometry

KimOllivier — Fri, 27 Jan 2017 11:52:33 GMT

Is this too simple? If the geometry is WKT format then the insert should use tmpRow[2] not tmpRow[1] because the field spec you must have is SHAPE@WKT

Re: arcpy.da.UpdateCursor fails to update geometry

KimOllivier — Fri, 27 Jan 2017 11:55:18 GMT

Rather than a list of geometries a dictionary of geometries is more direct to insert.

Re: arcpy.da.UpdateCursor fails to update geometry

KimOllivier — Fri, 27 Jan 2017 12:04:48 GMT

Do you need a geometry AND a wkt version? Surely one will do. You would have to be careful to get the one in the list.

Would it not be easier to just write row[1] = objectdict[row[0]] where the objectdict is a dictionary of shapes indexed by ID

I am trying to help you debug your code, so I would put in a lot of print statements that confirm you do have a geometry and it is

in the right row element by printing out a WKT representation as you go and then break after the first one.

If you only put up pseudocode you are hiding your problem with your assumptions on where the problem lies. It would be much better

if you posted your real code.

Re: arcpy.da.UpdateCursor fails to update geometry

VinceAngelo — Fri, 27 Jan 2017 15:02:49 GMT

kimo wrote:
Do you need a geometry AND a wkt version? Surely one will do. You would have to be careful to get the one in the list.

This is the key point. By specifying an update of the same column in two different forms, but only updating the first referenced input, the code is likely updating the column with the new content, then updating it again with the previous contents.

Multiple references to the same geometry column in an UPDATE or INSERT cursor really ought to raise an error.

- V

Re: arcpy.da.UpdateCursor fails to update geometry

BledarBirbo1 — Fri, 27 Jan 2017 16:46:58 GMT

Leaving only the SHAPE@WKT field in the UpdateCursor and updating only that fixed it.

Thanks.

Re: arcpy.da.UpdateCursor fails to update geometry

JoshuaBixby — Sun, 12 Dec 2021 09:39:43 GMT

Why use SHAPE@WKT instead of SHAPE@ ? From a performance perspective, I can't imagine returning the WKT instead of a geometry object saves much, and there are cases where the WKT doesn't exactly equal the geometry. For example, with curves:

>>> esri_json = {  
...     "curvePaths": [[  
...         [1,5],  
...         {"c": [[7,3], [6,2]]}  
...     ]],  
...     "spatialReference": {"wkid": 0}  
... }  
...   
>>> ln = arcpy.AsShape(esri_json, True)
>>> ln.JSON
u'{"curvePaths":[[[1,5],{"c":[[7,3],[6,2]]}]],"spatialReference":{"wkid":null}}'
>>> 
>>> arcpy.FromWKT(ln.WKT).JSON
u'{"paths":[[[1,5],[0.99399503194559768,4.9030739951953093],[0.99088008165787445,4.8060121224880596],[0.99065791395499181,4.7089005336315006],[0.99332872603216815,4.6118254245067529],[0.99889014728664582,4.5148729586156593], ..., [6.7724322738783158,2.6854575752247012],[6.8328139890149053,2.7615151752781921],[6.8909032081665362,2.8393377469851719],[6.9466483715607055,2.9188562153236042],[7,3]]],"spatialReference":{"wkid":null}}'‍‍‍‍‍‍‍‍‍‍‍‍‍‍

In the example above, the true curve is approximated when dumped out in WKT, and regenerating the geometry from that WKT makes for a different geometry, although practically the same.