topic Re: Hide popup on polygon vertice click in ArcGIS JavaScript Maps SDK Questions

Hide popup on polygon vertice click

rsharma — Mon, 11 May 2020 07:35:19 GMT

A default popup appear when i click on vertice of polygon. As i m also using markers with popup in my app, but they also appear on my vertices with default body.

The line in bold shows my popup, but it should not work for polygon vertices.

        // This function is called when a user clicks on the view.
        function setUpGraphicClickHandler() {
          view.on("click", function(event) {
            view.hitTest(event).then(function(response) {
              var results = response.results;
            if(results.length === 0){
              sketchViewModel.complete();
               markersketchViewModel.complete();
            }
              // Check if the new development graphic and temp graphics with attribute named newDevelopment was clicked and pass
              // the graphic to sketchViewModel.update() with reshape tool.
              results.forEach(function(result) {
                if (
                  result.graphic.layer === sketchViewModel.layer &&
                  result.graphic.attributes &&
                  result.graphic.attributes.newDevelopment
                ) {
                  sketchViewModel.update([result.graphic], { tool: "reshape" });
                } else if(
                  result.graphic.layer === markersketchViewModel.layer &&
                  result.graphic.attributes &&
                  result.graphic.attributes.newDevelopment){
                 markersketchViewModel.update([result.graphic], { tool: "reshape" });
                }
                else if(sketchViewModel.state !== 'active'){
                  sketchViewModel.cancel();
                 // view.popup.open({features: [result.graphic], location: result.graphic.geometry});
                } else if(markersketchViewModel!== 'active' ){
                   markersketchViewModel.cancel();
                  view.popup.open({features: [result.graphic], location: result.graphic.geometry});

                }
              });
            });
          });
        }//End setUpGraphicClickHandler

Re: Hide popup on polygon vertice click

RobertScheitlin__GISP — Mon, 11 May 2020 12:29:49 GMT

Rajni,

The popup is appearing because you are telling it to in your code.

                } else if(markersketchViewModel!== 'active' ){
                   markersketchViewModel.cancel();
                  view.popup.open({features: [result.graphic], location: result.graphic.geometry});

}

You have markersketchViewModel!== 'active' . Well markersketchViewModel is never going to equal a string of active... Maybe you mean markersketchViewModel.state !== 'active'.

Re: Hide popup on polygon vertice click

rsharma — Mon, 11 May 2020 12:35:58 GMT

Ok, but the the problem still persists, default popup still appears on vertices

Re: Hide popup on polygon vertice click

RobertScheitlin__GISP — Mon, 11 May 2020 12:45:05 GMT

Your next issue is that you are not checking the state of your default sketchviewmodel.

Re: Hide popup on polygon vertice click

rsharma — Mon, 11 May 2020 12:50:28 GMT

Sir

I am checking its state here

else if(sketchViewModel.state !== 'active'){
                  sketchViewModel.cancel();
                 // view.popup.open({features: [result.graphic], location: result.graphic.geometry});
                }

Re: Hide popup on polygon vertice click

RobertScheitlin__GISP — Mon, 11 May 2020 12:57:33 GMT

Rajni,

Hmm. is that code from a different area of your code?

I was envisioning something like this:

                } else if(markersketchViewModel.state !== 'active' && sketchViewModel.state !== 'active'){
                   markersketchViewModel.cancel();
                  view.popup.open({features: [result.graphic], location: result.graphic.geometry});

}

Re: Hide popup on polygon vertice click

rsharma — Mon, 11 May 2020 13:04:09 GMT

No sir

I have sketchviewmodel for property boundaries and markersketchviewmodel to create marker with polygons. So i have 2 sketchview models iin my code,

but markersketchview model default popup appear for vertices of sketchviewmodel.

Now i m confused!!!

                }
              });
            });
          });
        }//End setUpGraphicClickHandler

Re: Hide popup on polygon vertice click

RobertScheitlin__GISP — Mon, 11 May 2020 13:08:39 GMT

Well you have me confused too. Why in the world do you have two different sketchview models? You do not not need a different on just to draw points/markers, that just complicates your code...

Re: Hide popup on polygon vertice click

rsharma — Mon, 11 May 2020 13:14:52 GMT

Well markersketchviewmodel draw boundaries also with different color and attributes you can say zones on the person properties to separate them like areas in property with low signal areas of property or high signal, ie the idea, so they must be used and act differently alot.

So to separate basic property polygon from their numerous areas of it

Re: Hide popup on polygon vertice click

rsharma — Mon, 11 May 2020 13:17:17 GMT

and their graphic layer iss also differnt. to make layers working more comfortable for zones and basic properties

Re: Hide popup on polygon vertice click

RobertScheitlin__GISP — Mon, 11 May 2020 13:21:31 GMT

Well because you are using two SVMs then you need to check the state of both of them like I suggested last post.

Re: Hide popup on polygon vertice click

rsharma — Tue, 12 May 2020 12:05:29 GMT

Sir

I am already checking the state for both of them, I don't know where i m getting wrong.

Re: Hide popup on polygon vertice click

RobertScheitlin__GISP — Tue, 12 May 2020 12:16:53 GMT

Honestly I do not either. If you have vertices showing then one of the SVMs should be active, unless you are manually adding the vertices to some graphics layer.

Re: Hide popup on polygon vertice click

rsharma — Tue, 12 May 2020 12:23:43 GMT

But i m using this condition, how can a popup appear , if they are active.

I am adding markers with popup on separate layers.

else if(sketchViewModel.state !== 'active'){
                  sketchViewModel.cancel();
                  //view.popup.open({features: [result.graphic], location: result.graphic.geometry});
                } else if(markersketchViewModel.state!== 'active'){
                   markersketchViewModel.cancel();
                  view.popup.open({features: [result.graphic], location: result.graphic.geometry});

}

Re: Hide popup on polygon vertice click

rsharma — Tue, 12 May 2020 12:27:52 GMT

this is the marker add on click

      view.on("click", function(evt) {
            if(getmarkerclick==true){
              counter++;
               getmarkercoordinates(view.toMap({x:evt.x, y: evt.y}));
               getmarkerclick=false;
            }
          }); //End view click

            //Plot marker on map on click
            window.getmarkercoordinates=function(pt){
              var p = new Point({
                          longitude: pt.longitude,
                          latitude:pt.latitude,
                          spatialReference: { wkid: 4326 }
                      });

           var changedSymbol=changedsymbol(markertype);
            var g = new Graphic({
                        geometry: webMercatorUtils.geographicToWebMercator(p),
                        symbol: changedSymbol,
                        attributes: {
                  newDevelopment: "new marker",
                  state: "new",
                  uniquetype:markertype,
                  markerId:"0",
                  marker_temp_Id:counter,
                  comment:comment
                }
              });

         //define popup body here
         var popup_html = ' <div class="be-form-wrapper">';
                  popup_html += '<div class="cmt_txt">'+comment +'</div></div>'
                  popup_html += '<div class="cat-btn-wrapper">';

popup_html += '<button class="btn btn-width close_marker" data-url="">Cancel</button>';
popup_html += '</div> </div></div>';

                  //add content of popup body here
                  g.popupTemplate = {
                    title : ' ',
                    content: popup_html
                  };
             markerGL.add(g);
            };

Re: Hide popup on polygon vertice click

RobertScheitlin__GISP — Sun, 12 Dec 2021 07:41:55 GMT

Rajni,

I think I recommended before that you check the state of both SVMs at the same time not in separate else ifs.

}else if(markersketchViewModel.state!== 'active' && sketchViewModel.state !== 'active'){
  if(markersketchViewModel){
    markersketchViewModel.cancel();
  }
  if(sketchViewModel){
    sketchViewModel.cancel();
  }
  view.popup.open({features: [result.graphic], location: result.graphic.geometry});
}‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Re: Hide popup on polygon vertice click

rsharma — Thu, 14 May 2020 05:16:15 GMT

Well your code blocked my markers also, so i did some minor editing, and now it works fine.

else if(sketchViewModel.state !== 'active'){
sketchViewModel.cancel();
//view.popup.open({features: [result.graphic], location: result.graphic.geometry});
} else if(markersketchViewModel.state!== 'active'){
markersketchViewModel.cancel();
if( result.graphic.attributes &&
result.graphic.attributes.newDevelopment){
view.popup.open({features: [result.graphic], location: result.graphic.geometry});
}
}