topic Javascript error: function not defined???? in ArcGIS JavaScript Maps SDK Questions

Javascript error: function not defined????

Anonymous User — Mon, 26 Aug 2013 15:24:22 GMT

however it IS defined....here:

require(["dojo/dom",
        "dojo/_base/array",
        "dojo/_base/Color",
        "dojo/parser",

...

],

function(dom, array, Color, parser, Map, esriLang, Graphic, FeatureLayer, InfoTemplate, GraphicsLayer, SimpleRenderer, Point, FeatureSet,
             ClosestFacilityTask, ClosestFacilityParameters, SimpleMarkerSymbol, SimpleLineSymbol){

      var map, incidentsGraphicsLayer, routeGraphicLayer, closestFacilityTask, params, facilitiesFeatureLayer, handler;


    function myFunction() {
      alert("Do Something");
    }

});

<body class="claro">
...

<div> <button onClick="myFunction()">Pick Point</button></div>
</body>
</html>

Re: Javascript error: function not defined????

BenFousek — Mon, 26 Aug 2013 15:29:58 GMT

onClick will not work on html elemets. You want onclick.

<button onclick="myFunction()">Pick Point</button>

onClick is a dojo event for widgets like dijit/form/Button.

<div data-dojo-type="dijit/form/Button" data-dojo-props="label: 'Pick Point', onClick: function() { myFucntion() }"></div>

Re: Javascript error: function not defined????

derekswingley1 — Sun, 12 Dec 2021 04:18:40 GMT

myFunction is not available in the global scope, which is where it needs to be if you want it to run via an onclick attribute of an html element. You could create myFunction as a global by putting:

var myFunciton;

at the root of your script tag and then:

myFunction = function() {
  alert("Do Something");
}

But that's the wrong way to do this. In general, it's bad practice to add onclick handlers via markup. Mixing JS and markup is not a good habit to develop. Instead, get a reference to your element (could use dojo/dom.byId or dojo/query) and bind a click handler with dojo/on.

Re: Javascript error: function not defined????

Anonymous User — Mon, 26 Aug 2013 16:20:34 GMT

onClick will not work on html elemets. You want onclick.
<button onclick="myFunction()">Pick Point</button>
onClick is a dojo event for widgets like dijit/form/Button.
<div data-dojo-type="dijit/form/Button" data-dojo-props="label: 'Pick Point', onClick: function() { myFucntion() }"></div>

Thanks for the quick reply, Ben. However that did not remedy the issue. Same error message.

Thanks!

rGIbson

Re: Javascript error: function not defined????

BenFousek — Mon, 26 Aug 2013 16:23:34 GMT

Look at Derek's post. I missed the fact myFunction() wasn't also globally available.

Re: Javascript error: function not defined????

Anonymous User — Mon, 26 Aug 2013 16:36:56 GMT

Good tip....thanks, Derek.

So something like this did the trick perfectly.

registry.byId("trace").on("click", fireTrace);

function fireTrace() {
doSomething;
}

<button id="trace" data-dojo-type="dijit/form/Button">Pick Point</button>

Thanks again, Derek and Ben for your quick replies and help.

rGibson

Re: Javascript error: function not defined????

derekswingley1 — Mon, 26 Aug 2013 16:41:38 GMT

Nice, glad we could help!

Re: Javascript error: function not defined????

JeffPace — Sun, 12 Dec 2021 04:18:43 GMT

I know you already have an answer, but I struggled with this last week and found an even easier solution, adding one line to your code

//define a variable for your function
var myFunction = function myFunction() {
alert("Do Something");
}

//make function global
lang.setObject("myFunction", myFunction);

Re: Javascript error: function not defined????

Anonymous User — Tue, 27 Aug 2013 17:30:10 GMT

However now I'm curious why this returns "undefined"

registry.byId("toolBuffer").on("click", fireBuffer);

...

function fireBuffer() {
alert(dom.byId('toolBuffer').value);
}

....

<input id="toolBuffer" data-dojo-type="dijit/form/Button" data-dojo-props="iconClass:'findNear', showLabel: false" value="buff"></button>

Re: Javascript error: function not defined????

BenFousek — Tue, 27 Aug 2013 17:40:23 GMT

Try this:

Add value as property:
[HTML]<input id="toolBuffer" data-dojo-type="dijit/form/Button" data-dojo-props="iconClass:'findNear', showLabel: false, value: 'buff'"></button>[/HTML]

Use .get('value') to get the value:

dom.byId('toolBuffer').get('value');

Re: Javascript error: function not defined????

Anonymous User — Tue, 27 Aug 2013 17:46:24 GMT

Try this:

Add value as property:
[HTML]<input id="toolBuffer" data-dojo-type="dijit/form/Button" data-dojo-props="iconClass:'findNear', showLabel: false, value: 'buff'"></button>[/HTML]

Use .get('value') to get the value:
dom.byId('toolBuffer').get('value');

Throws this error:

Uncaught TypeError: Object #<HTMLSpanElement> has no method 'get'

Re: Javascript error: function not defined????

BenFousek — Tue, 27 Aug 2013 17:55:37 GMT

Sorry...use dijit.byId because it's a widget.

dijit.byId('toolBuffer').get('value');

Re: Javascript error: function not defined????

Anonymous User — Tue, 27 Aug 2013 17:57:41 GMT

Sorry...use dijit.byId because it's a widget.
dijit.byId('toolBuffer').get('value');

That was it....

Thanks!

rGibson