esri/views/SceneView module breaks Object.assign()

MatejVrtich — Thu, 23 Jul 2015 11:39:42 GMT

There is Object.assign() polyfill coming with esri/views/SceneView module (inside the esri/views/3d/canvas3d/webgl-engine/lib/es6-shim submodule).

This polyfill seems to be wrong.

According the https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign, the Object.assign() should be able to process multiple sources, which the Object.assign() polyfill coming with esri/views/SceneView does not support.

Example:

Object.assign({}, {a:1}, {b:2}); // should return {a:1, b:2}, the polyfill returns {a:1}.

You can try the example alive:

1. Open http://developers.arcgis.com/javascript/beta/sample-code/source-code/3d/basic3d/index.html in Chrome (Chrome does not implement the Object.assign() yet, so the polyfill will be used)

2. Run Object.assign({}, {a:1}, {b:2}); in the console

3. The result is {a:1}

5. Run Object.assign({}, {a:1}, {b:2}); in console

6. The result is {a:1, b:2}

Generally I do not think it is good idea to pollute global scope with polyfills coming with EsriJS library itself.

Re: esri/views/SceneView module breaks Object.assign()

YannCabon — Fri, 24 Jul 2015 19:02:44 GMT

Hi Matej,

we will work on this for beta2.