topic Re: Measurement widget in 3.10 ends prematurely in ArcGIS JavaScript Maps SDK Questions

BUG: Measurement widget measure-end event issue.

AdrianMarsden — Mon, 28 Jul 2014 13:58:06 GMT

II have a widget



    var measurement = new esri.dijit.Measurement({
        map: map,
        defaultAreaUnit: esri.Units.SQUARE_METERS,
        defaultLengthUnit: esri.Units.METERS
    }, dojo.byId('measurementDiv'));
    //measurement.hideTool("location");
    


    measurement.on("measure-end", function (evt) {
        console.debug("Really ended?")
        this.setTool(evt.activeTool, false);
        enableID();
    });
    measurement.startup();

Define as above.

However the measure-end event is fired after each node of an area measure from the third node onwards. There follows a large error message

The task does, however keep going when area is being measured.

Strange? Or my fault?

ACM

UPDATE

Using the older dojo.connect

    dojo.connect(measurement, "onMeasureEnd", function (activeTool, geometry) {
        this.setTool(activeTool, false);
        enableID();    
    });

And the event fires, as before on the third click, for area, but doesn't have the error, and re-enables my ID task.

It looks like the new widget is firing the OnMeasureEnd event each time a result for the area is required - the old tool only got the result on double click - ending the drawing.

the code worked fine in 3.8 & 3.9

Re: Measurement widget in 3.10 ends prematurely

AdrianMarsden — Tue, 29 Jul 2014 10:08:51 GMT

More info

I've edited the official smaple

Measurement | ArcGIS API for JavaScript‌

I used my Proxy of course, and mofified the measurement definition

            var measurement = new Measurement({
                map: map
            }, dom.byId("measurementDiv"));
           
            measurement.startup();
            measurement.on("measure-end", function (evt) {
           console.debug("not really the end?")     
           this.setTool(evt.activeTool, false);
            });

This fails in the same way.

Unless told otherwise, I'm calling this one a BUG.

Re: Measurement widget in 3.10 ends prematurely

JonathanUihlein — Wed, 30 Jul 2014 17:38:12 GMT

Hi Adrian,

Great point. This was an underlying change that should have been highlighted in the release notes.

There are still many more widget changes coming so thanks for the feedback.

As you noted, the 'measure-end' event now fires when a successful shape is drawn (3+ nodes).

This allows a user to immediately access the geometry of the freshly drawn polyline.

To know when the shape is truly done being drawn, you need to check the geometry.type property in the callback.

on(measurement, "measure-end", function(evt){
  if(evt.geometry.type === "polygon"){
    console.log("Really done.");
  }
});

Hope this helps.Let me know if you have any more questions.

Again, all feedback is appreciated, especially concerning current widget functionality and potential enhancements.

Re: Measurement widget in 3.10 ends prematurely

AdrianMarsden — Thu, 31 Jul 2014 08:43:26 GMT

Jonathan

Thanks for that, my code now looks like

    measurement.on("measure-end", function (evt) {
        console.debug(evt)
        if (evt.geometry.type === "polygon") {
            console.log("Really done.");
        }
    });

But it fails - looking at the evt object (hence my console line) it is, as I thought it would be, a polygon after three nodes have been drawn - output below, first is after a single click (ie still drawing), second after a double click

basecode.js?123:252

Really done. basecode.js?123:254

Really done.

And adding the line I want in

 this.setTool(evt.activeTool, false);

Throws a huge error, starting

"TypeError: undefined is not a function

Only reverting to the older style event link

    dojo.connect(measurement, "onMeasureEnd", function (activeTool, geometry) {
        console.debug(activeTool);
        console.debug(geometry);
        this.setTool(activeTool, false);
        enableID();    
    });

gets the tool disabled - but of course it disables as soon as the third node is created. And geometry type is always polygon.

Would adding a Double Click event be too much to ask?

Cheers

ACM

Re: Measurement widget in 3.10 ends prematurely

JonathanUihlein — Mon, 04 Aug 2014 15:29:02 GMT

This works for me in the sandbox sample:

measurement.on("measure-end", function (evt) { 
  if (evt.geometry.type === "polygon") { 
    console.log("Really done."); 
    measurement.setTool(evt.toolName, false);
  } 
});

Re: BUG: Measurement widget measure-end event issue.

AdrianMarsden — Tue, 05 Aug 2014 08:27:31 GMT

Jonathan

Nope still broken. My code is old style code, so I have the below code in my init function

        var measurement = new esri.dijit.Measurement({
            map: map,
            defaultAreaUnit: esri.Units.SQUARE_METERS,
            defaultLengthUnit: esri.Units.METERS
        }, dojo.byId('measurementDiv'));
    //measurement.hideTool("location");
        measurement.on("measure-end", function (evt) {
            if (evt.geometry.type === "polygon") {
                console.log("Really done.");
                measurement.setTool(evt.toolName, false);
            }
        });
        measurement.startup();

And it still returns a polygon after the third click, so ends the task.

Cheers

ACM

Re: BUG: Measurement widget measure-end event issue.

RiyasDeen — Tue, 05 Aug 2014 09:39:09 GMT

Hi Jonathan,

Your solution works unless as long as i don't measure a self intersecting polygon. Refer image.

Once a create a self intersecting polygon toll gets reset.

Re: BUG: Measurement widget measure-end event issue.

AdrianMarsden — Tue, 05 Aug 2014 10:31:57 GMT

Ok - so two issues now - I think it is time to call the new features in 3.10 as broken, don't you? We need a few more events to hook into and the measure end event to be just that. An event that fires when the measurement has ended - it works for the length, which returns the value after each click, but only fires the measure end event after a double click.

Re: BUG: Measurement widget measure-end event issue.

RiyasDeen — Tue, 05 Aug 2014 12:36:46 GMT

Hi Adrian,

What I noticed was a bug on the workaround suggested by jonathan. Never the less measure end event would be one of those important event, I used it in couple of my project, thankfully they are still on good old 3.3

Re: BUG: Measurement widget measure-end event issue.

RiyasDeen — Tue, 05 Aug 2014 12:42:09 GMT

my project was in 3.7, not 3.3

Re: BUG: Measurement widget measure-end event issue.

AdrianMarsden — Mon, 11 Aug 2014 12:37:44 GMT

Anyone any ideas on this? As it is it is a breaking change preventing me from moving to 3.10.

Re: BUG: Measurement widget measure-end event issue.

NicholasHaney — Mon, 11 Aug 2014 18:16:57 GMT

I'm not sure I would call this a bug, it's more like a needed enhancement. Anyway, here is some code that will provide a work around for your issue:

//Variable to keep track of whether the measurement has ended

var end = false;

//If the map is double clicked, and the polygon measure tool is currently selected, set end to true

map.on("dbl-click", function() {

if(dom.byId("dijit_form_ToggleButton_0").getAttribute("aria-pressed") == "true") {

end = true;

}

//If end is true, execute your functions

measure.on("measure-end", function() {

if (end == true) {

end = false;

}

There may be (and probably is) a more elegant way to do this but this fixed the problem you described.

Re: BUG: Measurement widget measure-end event issue.

AdrianMarsden — Tue, 12 Aug 2014 15:39:50 GMT

Thanks for that - I'll try it later. But I do think it is a bug, or a t least a "Breaking Change" as the examples given measurement-amd | API Reference | ArcGIS API for JavaScript no longer work as the event no longer does what it says it does.

On-measure-end is quite clear in what it should do, an event that fires when measurement is ended. It doesn't. It fires when a polygon has been created and an intermediate measurement has been calculated.

This only fails for area. For length a result is returned with each click without firing the on-measure-end event.

Re: BUG: Measurement widget measure-end event issue.

KellyHutchins — Tue, 12 Aug 2014 16:44:09 GMT

Adrian,

This one looks like a bug to me. Do you have support? If so can you submit an issue to them for this so we can get it logged into the system as a bug.

Thanks

Kelly

Re: BUG: Measurement widget measure-end event issue.

AdrianMarsden — Wed, 13 Aug 2014 10:27:45 GMT

Yep - got it with Esri(UK) at the moment, but not much movement.

Re: BUG: Measurement widget measure-end event issue.

AdrianMarsden — Thu, 14 Aug 2014 13:27:45 GMT

logged as a bug

Esri Inc Bug: NIM#104292

I'll update here if I hear anything else, but as it is a bug it has now left the control of our local Esri.

Re: BUG: Measurement widget measure-end event issue.

AdrianMarsden — Tue, 07 Oct 2014 14:17:52 GMT

This bug has been fixed in 3.11 - I've just tested it and the measure-end event only triggers when the area tool is double clicked rather than at each node.

There's also a few new events. Enjoy

Re: BUG: Measurement widget measure-end event issue.

DustinNelson — Thu, 27 Aug 2015 20:04:53 GMT

This is kind of an older post but I was running into similar issues and wanted to share my workaround...

The documentation still says that this will work but I was still getting error messages

measurement.on("measure-end", function(evt){
this.setTool(evt.activeTool, false);
});

I changed my code to evt.toolName and was able to get around the error message coming up:

measureW.on("measure-end", function(evt)

{

measureW.setTool(evt.toolName, false);

});

If you need to be more specific you can modify the code to something like

if(evt.toolName == "location")

Hope this saves someone a little debugging time out there.