topic Re: If then condition with combo boxes in JavaScript API? in ArcGIS JavaScript Maps SDK Questions

If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 07 Oct 2014 22:24:31 GMT

I am receiving a syntax error; unexpected identifier at line 5. @

dijit.byId("cbRequestType").on('change', function (MFValue) {
    if (MFValue == 'Electronic Waste') {
    dijit.byID("cbMFSubType").set('value', 'Copy Machine'); 
    } 
    else if MFValue == '...'{
      dijit.by.ID('cbMFSubType').set('value', 'Printer'); 
    }
  });

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Tue, 07 Oct 2014 22:39:52 GMT

Geoffery,

Try placing your else if condition in parens


dijit.byId("cbRequestType").on('change', function (MFValue) {  
    if (MFValue == 'Electronic Waste') {  
    dijit.byID("cbMFSubType").set('value', 'Copy Machine');   
    }    
    else if (MFValue == '...') {  
      dijit.by.ID('cbMFSubType').set('value', 'Printer');   
    }  
  });

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 07 Oct 2014 22:52:18 GMT

Thank you Robert.

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 14 Oct 2014 16:01:31 GMT

I am getting back around to this, I am fairly novice with JavaScript. The code snippet above is ideal for my application, if E-WASTE is chosen in cbRequestType then cbEWASTE populates with different types of e-waste commodites. See my code below; what could be wrong with this that it does not pass to the combo box? I have a function which populates the e-waste combo box from the feature layer, should this be removed?

(dijit.byId("cbRequestType").on('change', function(MFValue) {

if (MFValue == 'E-WASTE') {

dijit.byID("cbEWASTE").set('value', 'Copy Machine');

}

else if (MFValue == '...') {

dijit.by.ID('cbEWASTE').set('value', 'Printer');

}

});

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Tue, 14 Oct 2014 18:28:25 GMT

Geoffery,

So are you trying to set the Combobox selected value (i.e. the CB is already populated with values and you are just trying to set the selected value of the CB)?

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 14 Oct 2014 18:50:42 GMT

Yes, so if cbRequestType is set with E-WASTE then cbSubType is to populate with e-waste types.

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Tue, 14 Oct 2014 19:28:27 GMT

Geoffery,

I am still unsure, based on your responses if the cbRequestType combobox ALREADY has the appropriate choices and you just want to select one certain value from it, or do you need to populate the CB with specific values.

I have a function which populates the e-waste combo box from the feature layer, should this be removed?

This makes it sound like you already have the desired values as part of this combobox, but I am not sure this is the case.

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 14 Oct 2014 19:36:09 GMT

Thank you for your help Robert. cbRequestType has the values which are to be passed to the next cb, which I will hardcode and not pass from the feature layer.

So again, if I select E-WASTE from cbRequestType, I'd like cbEWASTE to populate with e-waste types such as copier, scanner, pc, etc. But if WHITE GOODS is selected from cbRequestType I would like my cbEWASTE to populate with white goods types, such as refrigerators, metals, etc.

cbRequestType populates from my feature layer, but based on the script, it would be easier to hard code the statement which links cbRequestType to cbEWASTE.

So I would like to pass a function which populates cbEWASTE on change of cbRequestType...I will have many other fields which follow the same format, so e-waste is just an example...

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Tue, 14 Oct 2014 20:56:00 GMT

Geoffery,

I was so confused by your desired workflow I did not see the errors in your code.

dijit.byID is suppose to be dijit.byId (notice capital I only) then in your else you have dijit.by.ID...

Correct code:

          (dijit.byId("cbRequestType")).on('change',function(MFValue){
            if (MFValue == 'E-WASTE') {
              dijit.byId("cbEWASTE").set('value', 'Copy Machine');
            } else if (MFValue == '...') {
              dijit.byId('cbEWASTE').set('value', 'Printer');
            }
          });

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 14 Oct 2014 21:22:06 GMT

Not really sure what's incorrect then. I am receiving the error; Uncaught ReferenceError: dijit is not defined serviceRequest.js:1638(anonymous function).

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Tue, 14 Oct 2014 21:27:12 GMT

Geoffery,

Are you saying that you did not receive any errors before when you were using dijit.byID?...

Here is a working sample:

<!DOCTYPE html>
<html >
<head>

    <link rel="stylesheet" href="http://js.arcgis.com/3.11/dijit/themes/claro/claro.css">
    <script src="http://js.arcgis.com/3.11/"></script> 
    
    <script>
        require([
          "dojo/dom",
          "dojo/on",
          "dojo/parser", 
          "dijit/form/ComboBox"
        ], 
        function(
          dom, on, parser){
          parser.parse();
          (dijit.byId("cbRequestType")).on('change',function(MFValue){
            if (MFValue == 'E-WASTE') {
              dijit.byId("cbEWASTE").set('value', 'Copy Machine');
            } else if (MFValue == '...') {
              dijit.byId('cbEWASTE').set('value', 'Printer');
            }
          });
        });
    </script>
</head>
<body class="claro">
    <select data-dojo-type="dijit/form/ComboBox" id="cbRequestType" name="RequestType">
      <option>...</option>
      <option>E-WASTE</option>
      <option>Blah</option>
    </select>
    <select data-dojo-type="dijit/form/ComboBox" id="cbEWASTE" name="EWASTE"/>
</body>
</html>

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 14 Oct 2014 21:52:07 GMT

Hi Robert,

This solution works great, I will try it in my application and give you an update, my initial errors I suppose came from the fact that my syntax was incorrect. I really appreciate your assistance.

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Tue, 14 Oct 2014 23:37:46 GMT

Robert,

Your solution is great, however I think that there was a bit of confusion.

Please see the screen shot. I am currently passing a layer with several request types.

I would like to populate the description combo boxes with related request types, so I am not necessarily creating new combo boxes as your example indicates, only populating my description cb boxes with hard coded parameters...i.e. copier, etc.

The code that I am working with now populates each of the combo boxes based on the feature layer domain. Since these descriptions are not coming from my feature layer, I gather that this portion of the code is correct, but I am still missing something to pass to the description combo boxes.

function(  
          dom, on, parser){  
          parser.parse();  
          (dijit.byId("cbRequestType")).on('change',function(MFValue){  
            if (MFValue == 'E-WASTE') {  
              dijit.byId("Description1").set('value', 'Copy Machine');  
            } else if (MFValue == '...') {  
              dijit.byId('Description1').set('value', 'Printer');  
            }  
          });  
        });

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Wed, 15 Oct 2014 15:25:16 GMT

Geoffery,

I am unsure how to help you more... If the ID of the combobox that you want to change is "Description1" then the code dijit.byId("Description1").set('value', 'Copy Machine'); should work fine (if all you are wanting to do is set the selected value of the combobox). I have asked a couple of time now if this is all you are wanting to do or not, but maybe you are really wanting to add multiple values to the combobox that can be chosen from. Is this the case? If so then look at this sample:

<!DOCTYPE html>
<html >
<head>

    <link rel="stylesheet" href="http://js.arcgis.com/3.11/dijit/themes/claro/claro.css">
    <script src="http://js.arcgis.com/3.11/"></script> 
    
    <script>
        require([
          "dojo/dom",
          "dojo/on",
          "dojo/parser",
          "dojo/store/Memory",
          "dijit/form/ComboBox"
        ], 
        function(
          dom, on, parser, Memory){
          parser.parse();
          
          var eWasteStore = new Memory({
            data: [
                {name:"copier", id:"1"},
                {name:"scanner", id:"2"},
                {name:"PC", id:"3"},
                {name:"etc", id:"4"}
            ]
          });

          var whiteGoodsStore = new Memory({
            data: [
                {name:"refrigerators", id:"1"},
                {name:"metals", id:"2"},
                {name:"etc", id:"3"}
            ]
          });
          
          (dijit.byId("cbRequestType")).on('change',function(MFValue){
            if (MFValue == 'E-WASTE') {
              dijit.byId("cbEWASTE").setAttribute("store", eWasteStore);
            } else if (MFValue == 'WHITE GOODS') {
              dijit.byId('cbEWASTE').setAttribute("store", whiteGoodsStore);
            }
          });
        });
    </script>
</head>
<body class="claro">
    <select data-dojo-type="dijit/form/ComboBox" id="cbRequestType" name="RequestType">
      <option>...</option>
      <option>E-WASTE</option>
      <option>WHITE GOODS</option>
    </select>
    <select data-dojo-type="dijit/form/ComboBox" id="cbEWASTE" name="EWASTE"/>
</body>
</html>

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Wed, 15 Oct 2014 16:05:55 GMT

Hi Robert,

I am eternally grateful for your assistance, this seems like the correct solution, I am just having trouble applying to my existing code, thank you so much.

My only question is at line 47 claro is already defined in my HTML, so I am having a bit of trouble seeing where I'd drop that block, especially if my commodities are already defined and referenced from my feature layer.

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Wed, 15 Oct 2014 16:17:58 GMT

Geoffery,

If you already have "claro" defined for the body of your app then you don't need to do anything.

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Wed, 15 Oct 2014 17:22:07 GMT

I see,

The issue is that two new combo boxes are created. Not sure what causes this, I am referencing two cb boxes that are present in the application. I think the statement in order to retrieve my request type should be data specific and iterate through the layer to grab those fields....I really appreciate your assistance Robert but this is proving to be a bit more difficult than I thought initially.

EDIT: I would like to parse through the applications current feature layer and return the new items in existent cb boxes.

The feature layer maintains the request type and there are description cb boxes that are there to link the two...

Re: If then condition with combo boxes in JavaScript API?

RobertScheitlin__GISP — Wed, 15 Oct 2014 18:14:21 GMT

Geoffery,

The code I provided was just a sample for you to learn from and was not intended to be copied into your existing code. If you need something you can just copy and paste then you will have to provide your full code for me to work with.

Re: If then condition with combo boxes in JavaScript API?

GeoffreyWest — Wed, 15 Oct 2014 18:25:00 GMT

Robert,

Please follow me on GeoNet and I will inbox you...I connected with ESRI support regarding the matter and I think that they can offer further assistance from here. I greatly appreciate your help.