topic Re: Want to create a module for this QueryTask functionality in ArcGIS JavaScript Maps SDK Questions

Want to create a module for this QueryTask functionality

TracySchloss — Sat, 11 Dec 2021 22:11:57 GMT

I have two external tables that contain an ID and a description. They are the basis for a set of menus, and since they are very similar in their schema, I'm attempting to create one tool for creating an array of code and description pairs. In addition, I'm using this as a learning tool for defining modules and it's not going so well. These these will eventually be input for menus, as well as look

These are two different tables and the field names are not identical, so I need to account for that as well.

In my Map module, myMap.js, I have defined this variable, which is a table I have loaded as a featureLayer, along with several other layers.

var specUrl = specialtyTable.url;

added a listener for the map load event:

myPopulateCodeList.populateCode('spec',specUrl);

The function populateCode is getting called, but I need to keep the codeList array as a variable, because I'll use it again in more than one place.

myPopulateCodeList.js

 define([
  "dojo/on", 
  "esri/tasks/QueryTask", 
  "esri/tasks/query"
  ], function(
  on,QueryTask, Query){
  var codeList = [];
      return {
        populateCode: function(codeType, url){
          switch (codeType) {
            case "spec":
              codeAtt = 'ID_SPECIALTY_PK';
              specAtt = 'TX_SPECIALTY_DESC';
              break;
            default:
              codeAtt = 'ID_PROV_TYPE_PK';
              specAtt = 'TX_PROV_DESC';
              break;
          }
          var queryTask = new QueryTask(url);
          var query = new Query();
          query.outFields = ["*"];
          query.where = "1=1";
          query.returnGeometry = false;
          on(queryTask, 'complete', this.codeResultsHandler);
          on(queryTask, 'error', this.errorHandler);
          queryTask.execute(query);
        },
        
        //builds codeList object containing codes and descriptions 
        codeResultsHandler: function(results){
          var numResults = results.featureSet.features.length;         
            for (var j = 0; j < numResults; j++) {
              var code = results.featureSet.features.attributes[codeAtt];
              var desc = results.featureSet.features.attributes[specAtt];
              codeList.push({
                code: code,
                desc: desc
              });
            }
            console.log('end of codeList array build');
            return codeList;
          },
        
        errorHandler: function(err){
          console.log("error in myPopulateCodeList, error: " + err.details);
        }
        
      }
    return codeList;
     
    });

I can see that codeList is getting populated with values from the results handler of the queryTask, but I can't figure out how to pass this result back to the calling function. This doesn't work:

var specCodeList = myPopulateCodeList.populateCode('spec',specUrl);

When I had it all in one big file, this was working, but I'm trying to learn how to break my work up into smaller bits.

Re: Want to create a module for this QueryTask functionality

SteveCole — Sat, 11 Dec 2021 22:11:59 GMT

Is there any reason why you just don't declare codeList as a global variable? Stands to reason this is why it probably worked when everything was in one long JS file.

Either declare it at the top of your myMap.js file (outside of the requires):

var codeList = [];

or if you don't like lots of individual global variables, create a single global object and then create/update codeList as you need to at the module level:

Create global object in myMap.js before requires:

var app = [];
app.codeList = [];

Create/update values down at the module level:

app.codeList.push({...

I've been really getting my feet wet lately with migrating my legacy JS over to AMD and, although it's entirely possible that I'm doing this wrong, I'm not returning anything from my created AMD modules:

define ([
  "dojo/_base/declare",
  "esri/tasks/PrintTemplate",
  "esri/tasks/PrintParameters",
  "esri/tasks/PrintTask"
], function (
  declare, PrintTemplate, PrintParameters, PrintTask
) {
    return declare(null,{...

I've had some issues when I want to pass a value WITHIN a module from one function to another (i.e. two levels down and trying to use this) but I generally find my module approach and the app.[object] approach works well enough for what I've been trying to do. Again, maybe I'm missing something or being a bit too simplistic.

Re: Want to create a module for this QueryTask functionality

RobertScheitlin__GISP — Sat, 11 Dec 2021 22:12:02 GMT

Tracy,

This is how I would code your module:

define([
  "dojo/on",
  "esri/tasks/QueryTask",
  "esri/tasks/query",
  "dojo/_base/lang"
  ], function(
  on, QueryTask, Query, lang){
  var mo = {
    codeList: [],
    populateCode: function(codeType, url){
      var codeAtt, specAtt;
      switch (codeType) {
        case "spec":
          codeAtt = "ID_SPECIALTY_PK";
          specAtt = "TX_SPECIALTY_DESC";
          break;
        default:
          codeAtt = "ID_PROV_TYPE_PK";
          specAtt = "TX_PROV_DESC";
          break;
      }
      var queryTask = new QueryTask(url);
      var query = new Query();
      query.outFields = ["*"];
      query.where = "1=1";
      query.returnGeometry = false;
      queryTask.execute(query, lang.hitch(this,function(results){
        var numResults = results.features.length;
        for (var j = 0; j < numResults; j++) {
          var code = results.fetures.attributes[codeAtt];
          var desc = results.features.attributes[specAtt];
          this.codeList.push({
            code: code,
            desc: desc
          });
        }
        console.log("end of codeList array build");
        return this.codeList;
      }), function(err){
        console.log("error in myPopulateCodeList, error: " + err.details);
      });
    }
  };
  return mo;
});

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 13:22:28 GMT

I would expect the 'mo' that is returned to be the codeList array, but when I call it from myMap.js as

var specCodeList = myPopulateCodeList.populateCode('spec',specUrl);

it is still undefined.

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 13:31:03 GMT

I'm trying not to have too many global variables, because once I have this code broken up, I know I'll have problems keeping track of where I'm settnig them.

I have two tables I need to process, and both arrays needs to be persistent. I have a field for specialty code and a field for provider type and each has a corresponding lookup table. Since that's the case, I can't just re-use codeList. I need something like specCodeList and providerCodeList.

Technically you don't have to have your code divided into modules to use AMD syntax. I switched from legacy to AMD a couple years ago. When I did it, though, I left it all in one file the same as I had it before. My projects aren't generally very big, so I felt OK about leaving that at that state. The project I have now is working just great, but it is now 1200 lines long and I'm tired of scrolling. Even if I've not fully embraced AMD, if I could get it into manageable chunks, I'd be better off.

Re: Want to create a module for this QueryTask functionality

RobertWinterbottom — Tue, 11 Aug 2015 13:35:32 GMT

I think it returning undefined looks to be the correct behavior the way that Robert Scheitlin, GISP defined it. Calling that populateCode function does not actually return anything it is just updating the codeList property. So I think you could try something like this:

myPopulateCodeList.populateCode('spec', specUrl);

console.log(myPopulateCodeList.codeList);

logging myPopulateCodeList.codeList should see some things have updated, but remember populateCode is an async function and may take time to complete so the data may not be available right away. Async operations are great to use dojo's deferred library.

Re: Want to create a module for this QueryTask functionality

RobertWinterbottom — Sat, 11 Dec 2021 22:12:05 GMT

Here is an example of Robert Scheitlin, GISP code but with deferred in it

define([  
  "dojo/on",  
  "esri/tasks/QueryTask",  
  "esri/tasks/query",  
  "dojo/_base/lang",
  "dojo/Deferred"  
  ], function(  
  on, QueryTask, Query, lang, Deferred){  
  var mo = {  
    codeList: [],  
    populateCode: function(codeType, url){  
      var codeAtt, specAtt;
      var deferred = new Deferred();  
      switch (codeType) {  
        case "spec":  
          codeAtt = "ID_SPECIALTY_PK";  
          specAtt = "TX_SPECIALTY_DESC";  
          break;  
        default:  
          codeAtt = "ID_PROV_TYPE_PK";  
          specAtt = "TX_PROV_DESC";  
          break;  
      }  
      var queryTask = new QueryTask(url);  
      var query = new Query();  
      query.outFields = ["*"];  
      query.where = "1=1";  
      query.returnGeometry = false;  
      queryTask.execute(query, lang.hitch(this,function(results){  
        var numResults = results.featureSet.features.length;  
        for (var j = 0; j < numResults; j++) {  
          var code = results.featureSet.features.attributes[codeAtt];  
          var desc = results.featureSet.features.attributes[specAtt];  
          this.codeList.push({  
            code: code,  
            desc: desc  
          });  
        }  
        console.log("end of codeList array build"); 
        deferred.resolve(this.codeList);
      }), function(err){  
        console.log("error in myPopulateCodeList, error: " + err.details);
        deferred.reject(err);  
      }); 
      return deferred; 
    }  
  };  
  return mo;  
});

Then you can use this in your code like so:

myPopulateCodeList.populateCode('spec', specUrl).then(function (codeList) {
  console.log(codeList);
}, function (err) {
  console.error(err);
});

Note this is not tested but should work fine. Anytime you want to make asynchronous requests, dojo/Deferred can be a great utility to have if you know how to use it. There is a lot of information on them here: dojo/Deferred — The Dojo Toolkit - Reference Guide

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 13:50:01 GMT

I can definitely see that I need to handle this is in a my async manner. The calling script myMap.js is getting to the console.log ('UR here') way before it finishes the results of the queryTask. I should mention the external table is a DB2 business table, nothing in geodatabase format, and I always operate under the assumption it's going to take longer to process any query.

Listing myPopulateCodeList.codeList in the console log displays an empty array.

I should also mention for anyone who wants to use this code for themselves that the queryTask results must be referenced as results.features, not results.featureSet.features. In my original posting, I had a separate results handler. When you call a separate results handler, that's when you need to results.featureSet.features to get to the individual features.

Re: Want to create a module for this QueryTask functionality

RobertWinterbottom — Tue, 11 Aug 2015 14:02:18 GMT

Ok, sounds like you may want to step through the callback to the query task as that may not be populating your codeList array, if it is, then you will want to figure out the best way for you to return it or return a signal that the query task is complete and the data is available.

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 14:31:01 GMT

Maybe I need to also incorporate the idea that Steve brought up. I need these codeList to continue to be available throughout the application. I'm actually using them as a lookup table, so every time I create a grid or info tag, I need them to look up what the description is to go with the code.

In my index.html I have defined

var app = {};

I guess I need to continue to make this available to my other .js files by passing it as a parameter?

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 14:42:30 GMT

I added an app variable and passing it to myMap.js.

This lets me do this with my codeLists:

myPopulateCodeList.populateCode('spec', specUrl).then(function (codeList) {

app.specCodeList = codeList;

console.log(codeList);

}, function (err) {

console.error(err);

});

myPopulateCodeList.populateCode('prov', provUrl).then(function (codeList) {

app.provCodeList = codeList;

console.log(codeList);

}, function (err) {

console.error(err);

});

I have two objects in app, but when I look at them more closely, they contain the exact same thing - the values from the first table I processed.

Re: Want to create a module for this QueryTask functionality

SteveCole — Tue, 11 Aug 2015 14:50:44 GMT

Tracy Schloss

If you follow what I was throwing out there, it should be

var app = [];

not

var app = {};

Re: Want to create a module for this QueryTask functionality

RobertScheitlin__GISP — Sat, 11 Dec 2021 22:12:08 GMT

Tracy,

If you are going to reuse the myPopulateCodeList then you will have to clear the codeList array each time you do populateCode function.

populateCode: function(codeType, url){
    this.codeList = [];
    var codeAtt, specAtt;
    ....

Or you create a new myPopulateCodeList each time.

Re: Want to create a module for this QueryTask functionality

RobertWinterbottom — Sat, 11 Dec 2021 22:12:10 GMT

Yes seems like your getting a reference to myPopulateCodeList.codeList. If your going to store those codeLists in the global scope then I would recommend modifying the module a little so codeList is not a property of myPopulateCodeList to prevent issues like this. Here is an example of the original sample I posted with some changes to make codeList not a property of myPopulateCodeList module.

define([    
  "dojo/on",    
  "esri/tasks/QueryTask",    
  "esri/tasks/query",    
  "dojo/_base/lang",  
  "dojo/Deferred"    
  ], function(    
  on, QueryTask, Query, lang, Deferred){    
  var mo = {    
    //codeList: [],   We don't want this as a property here, it should be a local variable in function below  
    populateCode: function(codeType, url){    
      var codeAtt, specAtt, codeList = [];  // Added local codeList here
      var deferred = new Deferred();    
      switch (codeType) {    
        case "spec":    
          codeAtt = "ID_SPECIALTY_PK";    
          specAtt = "TX_SPECIALTY_DESC";    
          break;    
        default:    
          codeAtt = "ID_PROV_TYPE_PK";    
          specAtt = "TX_PROV_DESC";    
          break;    
      }    
      var queryTask = new QueryTask(url);    
      var query = new Query();    
      query.outFields = ["*"];    
      query.where = "1=1";    
      query.returnGeometry = false;    
      queryTask.execute(query, lang.hitch(this,function(results){    
        var numResults = results.featureSet.features.length;    
        for (var j = 0; j < numResults; j++) {    
          var code = results.featureSet.features.attributes[codeAtt];    
          var desc = results.featureSet.features.attributes[specAtt]; 
          // push to the local codeList and not this.codeList   
          codeList.push({    
            code: code,    
            desc: desc    
          });    
        }    
        console.log("end of codeList array build");   
        deferred.resolve(codeList);  
      }), function(err){    
        console.log("error in myPopulateCodeList, error: " + err.details);  
        deferred.reject(err);    
      });   
      return deferred;   
    }    
  };    
  return mo;    
});

What was happening was that when you called the populateCode function, it was updating the myPopulateCodeList.codeList property. So when you call populateCode function it just updates the same property no matter what you pass into it. Doing it this way returns a new codeList each time and then you can append it to your global codeLists

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 14:56:53 GMT

That didn't do it. And I'm mistaken, they aren't both populated with the values of the first pass, they're both populated with the values from the 2nd time I called it.

Re: Want to create a module for this QueryTask functionality

RobertWinterbottom — Tue, 11 Aug 2015 15:02:41 GMT

Did you try making codeList a local variable inside the populateCode function? Try getting rid of this.codeList altogether and using var codeList = []; inside the populateCode function. If so, can you post your populateCode code for us to see?

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 15:11:42 GMT

It's the code you posted that had codeList as a local variable. There's enough posts here they are a little out of sequence. I was replying to comments at the same time other people were posting.

I do have two different codeLists stored under "app". I'm not sure these are going to be available in all the places I need them, though. I need to work a little further and see.

Re: Want to create a module for this QueryTask functionality

RobertWinterbottom — Tue, 11 Aug 2015 15:20:05 GMT

If app is global then it will be available everywhere without the need for you to pass it around. global variables attach themselves to the window object. I think you should be close, I don't see any reason why the code posted would return the same object from two different queries if it is creating a new array each time you query.

Re: Want to create a module for this QueryTask functionality

TracySchloss — Tue, 11 Aug 2015 15:31:13 GMT

It doesn't anymore. My comment about them being the same is a reply to Robert's post. I can never decide whether I should Reply to an individual post or 'Reply to original post'. It completely changes the order the threads are listed. Your version works.

This is an exercise for me in how to think in terms of modules. I have a working project, just all in one big file. I'm reviewing one section of code at a time, trying to determine what logically should go into its own module.

Re: Want to create a module for this QueryTask functionality

RobertWinterbottom — Tue, 11 Aug 2015 15:36:37 GMT

Ah ok got it, Yea the forum setup is a bit wonky sometimes. And the fact that there are two Roberts replying probably doesn't make it any less confusing haha. Seems like you have a good start though so good luck.