topic Re: Bug in Edit? in ArcGIS JavaScript Maps SDK Questions

Bug in Edit?

TimWitt — Mon, 30 Jun 2014 17:04:37 GMT

Hey everybody,

I have recently created a Draw App that uses Edit, to be able to edit graphics and text.

It can be found here: http://jsfiddle.net/timw1984/T27G4/

When I do the following steps there seems to be a problem though.

1) Write some text in the textbox on the right -> right-click the map and click on "Add Text"
2) Now right-click the text and choose "Edit"
3) This pops up a menu in which you can change color/Alignment or double-click the text and change what it says.

Once done I should be able to click the map and the menu should disappear, but it doesn't. I am using EDIT_TEXT constant to do this.

The weird part is, when I choose "Rotate/Scale" (which uses the SCALE constant) instead of "Edit", the same menu pops-up and now when I click on the map the menu disappears.

Am I doing something wrong or could this be a bug?

Tim

Re: Bug in Edit?

JeffPace — Mon, 30 Jun 2014 18:01:42 GMT

i am getting

Uncaught Error: [esri.toolbars.Edit::activate] Unable to activate the tool. Check if the tool is valid for the given geometry type. edit.js:22
w.activate edit.js:22
ctxMenuForGraphics.addChild.MenuItem.onClick (index):118
k.onItemClick _MenuBase.js:8
(anonymous function) _MenuBase.js:4
(anonymous function)

Re: Bug in Edit?

JeffPace — Mon, 30 Jun 2014 18:20:26 GMT

odd. ok it is coming back as a point. Which is good. You are setting the point with a textsymbol properly.

however when you pass that to
editToolbar.activate(Edit.EDIT_TEXT, selected);

i get the
[esri.toolbars.Edit::activate] Unable to activate the tool. Check if the tool is valid for the given geometry type.
Which is why you cant close it, because it wasnt properly created.

What I can't figure out is, why not? it looks like everything is fine.

Re: Bug in Edit?

TimWitt — Mon, 30 Jun 2014 18:30:45 GMT

Hey Jeff,

thanks for checking it out.

I know, its a headscratcher, especially since all the functions of the "Edit" tool work properly (you can change alignment and change the color of the text) it just doesn't close.

Tim

Re: Bug in Edit?

JeffPace — Mon, 30 Jun 2014 19:31:48 GMT

as much as you can sniff an obfuscated API, it looks like your point is failing the _IsTextSymbol internal check of edit.js

Re: Bug in Edit?

TimWitt — Tue, 01 Jul 2014 12:09:40 GMT

I wonder if anyone has a working example that lets text be edited, I just don't see why it shouldn't work.

Nevermind I found a working example here.

The difference here is that they declare a point first to get the location of the text, I feed it the location directly. Could that cause the issue? If so, how would I solve that problem?

Re: Bug in Edit?

MatthewLofgren — Tue, 01 Jul 2014 16:41:17 GMT

Looking at the error, it looks like Text editing (maybe all points) requires Edit.EDIT_VERTICES, Edit.EDIT_TEXT (text only?), Edit.MOVE tools

n=this._enableBoxEditing(b,c,p);(a&e)===e&&(k=this._enableVertexEditing(b));(a&g)===g&&this._enableTextEditing(b);if(!h&&!k&&!n)throw Error("[esri.toolbars.Edit::activate] Unable to activate the tool. Check if the tool is valid for the given geometry type.");

The code below prevents the error, which makes the popup work as expected....

function createGraphicsMenu() {       // Creates right-click context menu for GRAPHICS       ctxMenuForGraphics = new Menu({});       ctxMenuForGraphics.addChild(new MenuItem({          label: "Edit",         onClick: function() {           if ( selected.geometry.type !== "point" ) {           editToolbar.activate(Edit.EDIT_VERTICES, selected);           } else {             editToolbar.activate(Edit.MOVE | Edit.EDIT_VERTICES | Edit.EDIT_TEXT, selected);           }         }        }));

Re: Bug in Edit?

JeffPace — Sat, 11 Dec 2021 16:44:47 GMT

Looking at the error, it looks like Text editing (maybe all points) requires Edit.EDIT_VERTICES, Edit.EDIT_TEXT (text only?), Edit.MOVE tools

n=this._enableBoxEditing(b,c,p);(a&e)===e&&(k=this._enableVertexEditing(b));(a&g)===g&&this._enableTextEditing(b);if(!h&&!k&&!n)throw Error("[esri.toolbars.Edit::activate] Unable to activate the tool. Check if the tool is valid for the given geometry type.");

The code below prevents the error, which makes the popup work as expected....
function createGraphicsMenu() {
      // Creates right-click context menu for GRAPHICS
      ctxMenuForGraphics = new Menu({});
      ctxMenuForGraphics.addChild(new MenuItem({ 
        label: "Edit",
        onClick: function() {
          if ( selected.geometry.type !== "point" ) {
          editToolbar.activate(Edit.EDIT_VERTICES, selected);
          } else {
            editToolbar.activate(Edit.MOVE | Edit.EDIT_VERTICES | Edit.EDIT_TEXT, selected);
          }
        } 
      }));

nicely done. I got to there in the code, but couldnt get the solution out. excellent

Re: Bug in Edit?

TimWitt — Tue, 01 Jul 2014 18:13:00 GMT

Matt,

great job! I still wonder if this is a bug maybe?

Thanks anyways!

Tim