topic Re: Can't "save" a feature from QueryTask. Argh! in ArcGIS JavaScript Maps SDK Questions

Can't "save" a feature from QueryTask. Argh!

SteveCole — Wed, 03 Oct 2012 19:10:42 GMT

This is probably pretty easy but I can't seem to get what I'm doing wrong. I have a function, kicked off via a button click, that queries a particular layer, and then does some additional queries & data retrieval against three other layers. Basically, I have one location and I want to extract information from three other datasets that overlap its spatial extent.

Anyways, what I've tried to do is an initial query to my layer which has my spatial location (using an FID which I pass to the function). Once I query that layer, I was to "save" the feature to a variable so I can quickly use it in my subsequent queryTask calls. Here's my simple code:

function getProjectReport(theFid) {  var theParam = theFid.split(",");   var query = new esri.tasks.Query();      query.where = "FID=" + theParam[0];  query.outFields = ["*"];  query.returnGeometry = true;    var theGraphic;    //Specify the appropriate point/line map service depending on what was clicked  switch (theParam[1]) {   case "point":    var queryTask = new esri.tasks.QueryTask("URL #1");      break;   case "polyline":    var queryTask = new esri.tasks.QueryTask("URL #2");      break;  }          queryTask.execute(query,function(featureSet) {     dojo.forEach(featureSet.features, function(feature) {      theGraphic = feature;                 });  });     console.log(theGraphic.attributes.PROJECT); }

Now, the queryTask finds my record but when it gets to my "console.log" line, it errors out and tells me that my variable theGraphic is undefined. I've defined my variable at the beginning of my function so why doesn't my assignment persist after the end ofmy forEach loop? How do I fix this so I can re-use theGraphic later on in my function?

Thanks again!
Steve

Re: Can't "save" a feature from QueryTask. Argh!

BillDaigle — Sat, 11 Dec 2021 15:07:40 GMT

You're passing the graphic to the console before the execute task has finished running. Place the console.log inside the callback for the execute function.

queryTask.execute(query,function(featureSet) {  
  dojo.forEach(featureSet.features, function(feature) {
     theGraphic = feature;       
                });
                console.log(theGraphic.attributes.PROJECT);
 });

Just FYI, based on the above code, theGraphic is only going to represent the last item in the featureSet.

Re: Can't "save" a feature from QueryTask. Argh!

SteveCole — Wed, 03 Oct 2012 19:57:50 GMT

Hi Bill,

There is only one item return via the query so that part is fine. The reason I included the console.log code line outside of the loop was to reinforce the point that my variable is not persisting beyond the scope of the forEach loop. This is something I want it to do.

Re: Can't "save" a feature from QueryTask. Argh!

__Rich_ — Sat, 11 Dec 2021 15:07:43 GMT

Bill's right, put some console.logs in around the code and you'll see the order that things get executed.

Don't forget the QueryTask.execute() is async and won't block on execution...

Here's your original code, complete with bug but with some log outputs:

function getProjectReport(theFid) {
 var theParam = theFid.split(",");

 var query = new esri.tasks.Query();    
 query.where = "FID=" + theParam[0];
 query.outFields = ["*"];
 query.returnGeometry = true;
 
 var theGraphic;
 
 //Specify the appropriate point/line map service depending on what was clicked
 switch (theParam[1]) {
  case "point":
   var queryTask = new esri.tasks.QueryTask("URL #1");  
   break;
  case "polyline":
   var queryTask = new esri.tasks.QueryTask("URL #2");  
   break;
 }

        console.log("Calling execute()");
        queryTask.execute(query,function(featureSet) {
               console.log("Task callback called");
  dojo.forEach(featureSet.features, function(feature,i) {
                          console.log("Looping through features, current feature index =" + i + " about to set theGraphic variable");
     theGraphic = feature;
                          console.log("Have set theGraphic variable for feature index = " + i);
                });
 }); 
 console.log("Trying to log theGraphic stuff, this will fail...");
 console.log(theGraphic.attributes.PROJECT);
}

Re: Can't "save" a feature from QueryTask. Argh!

SteveCole — Wed, 03 Oct 2012 20:41:47 GMT

Yes- I understand what Bill (and you) are saying.

What I'm not doing a good job of saying is that I want/need to access theGraphic variable AFTER the conclusion of the queryTask.Execute routine. I need to re-use the geometry and some of it's attributes for subsequent queries on additional datasets.

As my code currently exists, I can't- and I don't know what to change to get it to behave in the manner I need. I thought by declaring theGraphic as a variable at the beginning of the function it would persist and be accessible throughout the entire function but it's not (or I'm using it wrong).

Re: Can't "save" a feature from QueryTask. Argh!

WyattPearsall — Wed, 03 Oct 2012 21:27:43 GMT

The variable should be persisting, you are just accessing it before it gets set.
When you execute a query, your code continues running and the callback isn't
called until the request is ready. This is good, because it doesn't lock your screen
when you make a request, but you have to recognize that until your callback is actually
called, none of the code within it has taken place. This is what is happening to your
variable assignment.

The callback of the query is the ideal place to do work that depends on a variable in the query,
because you are guaranteed that the query has completed. Thus, nesting your queries in callback
functions will allow you to take advantage of asynchronous without running into timing problems.

Re: Can't "save" a feature from QueryTask. Argh!

KellyHutchins — Wed, 03 Oct 2012 22:57:21 GMT

Steve,

Are you trying to query multiple layers at the same time? If so perhaps this sample will help:

http://help.arcgis.com/en/webapi/javascript/arcgis/help/jssamples/query_deferred_list.html

The sample shows how to work with a dojo deferred list to get notified when multiple query tasks have completed.

Re: Can't "save" a feature from QueryTask. Argh!

__Rich_ — Sat, 11 Dec 2021 15:07:45 GMT

Yes- I understand what Bill (and you) are saying.

What I'm not doing a good job of saying is that I want/need to access theGraphic variable AFTER the conclusion of the queryTask.Execute routine. I need to re-use the geometry and some of it's attributes for subsequent queries on additional datasets.

As my code currently exists, I can't- and I don't know what to change to get it to behave in the manner I need. I thought by declaring theGraphic as a variable at the beginning of the function it would persist and be accessible throughout the entire function but it's not (or I'm using it wrong).

...and we understand what you are saying.

You can access theGraphic variable, no problem there, it's just then when you try it hasn't been populated yet.

See:

function getProjectReport(theFid) {
 var theParam = theFid.split(",");

 var query = new esri.tasks.Query();    
 query.where = "FID=" + theParam[0];
 query.outFields = ["*"];
 query.returnGeometry = true;
 
 var theGraphic = {attributes:{PROJECT:"nothing set yet"}};
 
 //Specify the appropriate point/line map service depending on what was clicked
 switch (theParam[1]) {
  case "point":
   var queryTask = new esri.tasks.QueryTask("URL #1");  
   break;
  case "polyline":
   var queryTask = new esri.tasks.QueryTask("URL #2");  
   break;
 }

        console.log("Calling execute()");
        queryTask.execute(query,function(featureSet) {
               console.log("Task callback called");
  dojo.forEach(featureSet.features, function(feature,i) {
                          console.log("Looping through features, current feature index =" + i + " about to set theGraphic variable");
     theGraphic = feature;
                          console.log("Have set theGraphic variable for feature index = " + i);
                });
 }); 
 console.log("Trying to log theGraphic stuff, this will output the initial value as the callback (probably, i.e. race conditions) hasn't fired yet...");
 console.log(theGraphic.attributes.PROJECT);
}

You must wait for the QueryTask callback to do it's thing before trying to use any values it sets.

Why can't you trigger whatever code needs to use the graphic from inside the callback? You could even pass the graphic out to another function - a callback from your callback if you like 😉

Re: Can't "save" a feature from QueryTask. Argh!

SteveCole — Sat, 11 Dec 2021 15:07:48 GMT

Ok, my apologies. The light bulb went off with Wyatt's description as to what's happening. So my problem is waiting until the callback finishes and it sounds like the deferredList that Kelly was suggesting might be the way to do this?

Here's my attempt to incorporate deferredList-

function getProjectReport(theFid) { 
 var theDocument, theGraphic 
 
 theGraphic = returnTipShape(theFid);
 
 console.log(theGraphic.attributes.PROJECT);
        .
        .
        .
}

function returnTipShape(param) {
 var theParam = param.split(",");

 var query = new esri.tasks.Query();    
 query.where = "FID=" + theParam[0];
 query.outFields = ["*"];
 query.returnGeometry = true;
 var theShape; 
 
 //Specify the appropriate point/line map service depending on what was clicked
 switch (theParam[1]) {
  case "point":
   var queryTask = new esri.tasks.QueryTask("http://dmc-arcgis.snoco.co.snohomish.wa.us/SnocoGISdev/rest/services/transportation/tipProjectsPoint/MapServer/0");  
   break;
  case "polyline":
   var queryTask = new esri.tasks.QueryTask("http://dmc-arcgis.snoco.co.snohomish.wa.us/SnocoGISdev/rest/services/transportation/tipProjectsLine/MapServer/0");  
   break;
 }

        dQuery = queryTask.execute(query); 

 var dList = new dojo.DeferredList([dQuery]);
 dList.then(function(results) {
  var featureSet = results[0];
  dojo.forEach(featureSet.features, function(feature) {
     theShape = feature;       
        });
 });
 
 return theShape;
}

I thought that if I put the queryTask and deferredList calls into a function, that would isolate the process until it finishes. Of course, I get the same error so it looks like I've just moved the same issue around.

Re: Can't "save" a feature from QueryTask. Argh!

BillDaigle — Sat, 11 Dec 2021 15:07:50 GMT

You're still not waiting for the response to be done before proceeding. You could do what your trying to do by nesting the second step inside a callback function:


function getProjectReport(theFid) { 
  var theDocument, theGraphic 
  
  returnTipShape(theFid,function(returnedShape){
    console.log(theGraphic.attributes.PROJECT);
        .
        .
        .
  });
  
  
}

function returnTipShape(param,callback) {
  var theParam = param.split(",");

  var query = new esri.tasks.Query();    
  query.where = "FID=" + theParam[0];
  query.outFields = ["*"];
  query.returnGeometry = true;
  var theShape; 
  
  //Specify the appropriate point/line map service depending on what was clicked
  switch (theParam[1]) {
    case "point":
      var queryTask = new esri.tasks.QueryTask("http://dmc-arcgis.snoco.co.snohomish.wa.us/SnocoGISdev/rest/services/transportation/tipProjectsPoint/MapServer/0");   
      break;
    case "polyline":
      var queryTask = new esri.tasks.QueryTask("http://dmc-arcgis.snoco.co.snohomish.wa.us/SnocoGISdev/rest/services/transportation/tipProjectsLine/MapServer/0");    
      break;
  }

  dQuery = queryTask.execute(query); 

  var dList = new dojo.DeferredList([dQuery]);
  dList.then(function(results) {
    var featureSet = results[0];
    dojo.forEach(featureSet.features, function(feature) {
        theShape = feature;       
        });
    callback(theShape);
  });
  
  //return theShape;
}

Also, you don't really need a deferredList in this case since you're only doing one call. Deferred lists are really only necessary when you need to wait for the response from multiples requests.

Re: Can't "save" a feature from QueryTask. Argh!

SteveCole — Sat, 11 Dec 2021 15:07:53 GMT

Many thanks to everyone's input in this thread. Getting this to work has been one of the toughest challenges for me since I started working with the javascript API. I do have things finally working but I did have to rethink my entire process. As several people pointed out, the callback routines were critical so I re-wrote my code to be less linear and more "modular." I had resisted this because of another constraint (this whole process will update an HTML template opened via an onClick event) but I did find a way. So to recap my solution...

My button's onClick event starts everything by calling this function:

function getProjectReport2(param) { 
 var theParam = param.split(",");
 var theShape;
 var query = new esri.tasks.Query();    
 query.where = "FID=" + theParam[0];
 query.outFields = ["*"];
 query.returnGeometry = true;

 //Specify the appropriate point/line map service depending on what was clicked
 switch (theParam[1]) {
 case "point":
   var queryTask = new esri.tasks.QueryTask("http://dmc-arcgis.snoco.co.snohomish.wa.us/SnocoGISdev/rest/services/transportation/tipProjectsPoint/MapServer/0");   
   break;
 case "polyline":
   var queryTask = new esri.tasks.QueryTask("URL to Map Servce");    
   break;
 }

 //The new browser window must be opened in the function called by the 'onClick' event so
 //the new window is created here and its associated variable is created with a global scope.
 //Calculate the center of the screen for placement of the new window
 var center_left = (screen.width / 2) - (1000 / 2);
 var center_top = (screen.height / 2) - (600 / 2); 
 newWindow = window.open('','mywindow','width=1000,height=600,menubar=yes,scrollbars=yes,left=' + center_left + ',top=' + center_top); 

 var dQuery = queryTask.execute(query,createDeferredResults);  
}

...which then passes the feature onto a separate callback function. I decided to use a deferredList as Kelly had suggested:

function createDeferredResults(featureSet) {
 var dTractRace, dTractIncome, dTractLep;

 dojo.forEach(featureSet.features, function(feature) {
   theTipProject = feature;       
 });
    
 var query = new esri.tasks.Query();    
 query.outFields = ["*"];
 query.returnGeometry = true;
 query.geometry = theTipProject.geometry;
 
 qTractRace = new esri.tasks.QueryTask("URL Service #1");
 qTractIncome = new esri.tasks.QueryTask("URL Service #2");
 qTractLep = new esri.tasks.QueryTask("URL Service #3");
 
 dTractRace = qTractRace.execute(query);
 dTractIncome = qTractIncome.execute(query);
 dTractLep = qTractLep.execute(query);
 
 defQuery = new dojo.DeferredList([dTractRace,dTractIncome,dTractLep]);
 defQuery.then(handleCensusResults);
}

Finally, another callback function where I finally get down to the task of updating my HTML template:

function handleCensusResults(results) {
 var raceResults, incomeResults, lepResults;

 raceResults = results[0][1].features;
 incomeResults = results[1][1].features;
 lepResults = results[2][1].features;
 .
        .
        .
 processRaceResults(raceResults);
}

Once again, thank you ALL for helping me!

Cheers,
Steve

topic Re: Can't "save" a feature from QueryTask. Argh! in ArcGIS JavaScript Maps SDK Questions

Can't &quot;save&quot; a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Re: Can't "save" a feature from QueryTask. Argh!

Can't "save" a feature from QueryTask. Argh!