topic Re: What is wrong with my syntax in this conditional statement? in ArcGIS JavaScript Maps SDK Questions

What is wrong with my syntax in this conditional statement?

ChrisSergent — Fri, 01 May 2015 18:13:13 GMT

I am trying to see if a field is empty, but I am receiving a syntax error. Any ideas:

on(dom.byId("btnFeedback"), "click", function () {

If(document.getElementById("eMail").value == null || document.getElementById("eMail").value == ""); {

alert("not working");

} else {

sendEmail();

}

);

Re: What is wrong with my syntax in this conditional statement?

SteveCole — Fri, 01 May 2015 18:15:57 GMT

Semi-colon at the end of the if line?...

Re: What is wrong with my syntax in this conditional statement?

ChrisSergent — Fri, 01 May 2015 18:21:50 GMT

Here is the complete block:

function sendEmail(ev) {

on(dom.byId("btnFeedback"), "click", function () {

If(document.getElementById("eMail").value == null || document.getElementById("eMail").value == "") {

alert("not working");

} else {

sendEmail();

}

);

I removed the semi-colon but still receive a syntax error.

Re: What is wrong with my syntax in this conditional statement?

DarrenWiens2 — Fri, 01 May 2015 18:23:20 GMT

sendEmail takes one parameter, but you pass none inside the else block. Although, you never actually use 'ev', so you may as well remove it.

Re: What is wrong with my syntax in this conditional statement?

SteveCole — Fri, 01 May 2015 18:25:33 GMT

How about....

If( (document.getElementById("eMail").value == null) || (document.getElementById("eMail").value == "") ) {

You could also try '===' (three equal signs) instead of '=='

Re: What is wrong with my syntax in this conditional statement?

ChrisSergent — Fri, 01 May 2015 18:31:50 GMT

It's still an error with the extra )

Re: What is wrong with my syntax in this conditional statement?

DarrenWiens2 — Fri, 01 May 2015 18:35:41 GMT

You may get better results by flipping it around (I suspect the problem is to do with "== null"):

If((document.getElementById("eMail").value) && document.getElementById("eMail").value != "")

Re: What is wrong with my syntax in this conditional statement?

ChrisSergent — Fri, 01 May 2015 18:40:19 GMT

Still getting a syntax error.

I have my code on github here if you want to see it: https://github.com/csergent45/streetSigns

I am working through two issues.

Re: What is wrong with my syntax in this conditional statement?

SteveCole — Fri, 01 May 2015 18:55:39 GMT

You said you have two issues. Is the other issue happening first? I've experienced situations where valid code broke due to an issue elsewhere in my code.

Re: What is wrong with my syntax in this conditional statement?

ChrisSergent — Fri, 01 May 2015 18:59:53 GMT

I am just trying to figure out a toggle layer visibility. I re-uploaded my project as I comment out what I am not working on so they don't conflict.

Re: What is wrong with my syntax in this conditional statement?

KellyHutchins — Fri, 01 May 2015 19:35:11 GMT

Can you provide more details about the error you are getting? Does it point to a particular line in your app?

Re: What is wrong with my syntax in this conditional statement?

ChrisSmith7 — Fri, 01 May 2015 20:03:32 GMT

Try this:

on(dom.byId("btnFeedback"), "click", function (e) {

if (document.getElementById("eMail") == null || document.getElementById("eMail").value == "") {

alert("not working");

} else {

sendEmail();

}

});

Hope this helps! I confirmed this is working on my end...

The way it sits now, whenever someone clicks on "btnFeedback", it will throw an alert window if the "eMail" element isn't on the page, or, it is, but the value is empty, otherwise, we'll send an e-mail.

I made some minor mods, including lowering the case on your initial "If" to "if". I removed the "value" method on your first condition... it shouldn't ever be null, just "". I left the check because if it's not on the page, it will throw the alert. getElementById should always return an object, even if it's not found... it'll be a null object. Additionally, I removed the ";" from your conditional and fixed your mismatched brackets.

Re: What is wrong with my syntax in this conditional statement?

curtvprice — Sat, 02 May 2015 18:08:13 GMT

Formatting Your Code In Geonet For The Visual Learner

Re: What is wrong with my syntax in this conditional statement?

ChrisSergent — Mon, 04 May 2015 14:55:19 GMT

Awesome! This worked on my end too! Thanks.

Re: What is wrong with my syntax in this conditional statement?

ChrisSergent — Mon, 04 May 2015 14:57:24 GMT

I can't believe I forgot to post the error message.

Just in case it helps, I'll add that to this thread as well:

ncaught SyntaxError: Unexpected token {