topic Re: How to manage multiple results from Asynch geoprocessing tool? in ArcGIS JavaScript Maps SDK Questions

How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Thu, 23 Aug 2012 12:15:50 GMT

I have a geoprocessing tool that is returning both a GPDataFile and a GPFeatureRecordSetLayer. How would I access both of these results?

I know how to do it in C#/Silverlight but I am new to Javascript and don't have a handle on all of the nomenclature for it yet.

Here is the C#/Silverlight Code

private void GeoprocessorTask_JobCompleted(object sender, JobInfoEventArgs e)         {             if (e.JobInfo.JobStatus != esriJobStatus.esriJobSucceeded)             {                 MessageBox.Show("Geoprocessor service failed" );                 ProcessingTextBlock.Text = "";                  ProcessingTextBlock.Visibility = Visibility.Collapsed;                                  GraphicsLayer graphicsLayer = Map.Layers["Results"] as GraphicsLayer;                 GraphicsLayer startLayer = Map.Layers["MyGraphicsLayer"] as GraphicsLayer;                 graphicsLayer.ClearGraphics();                 startLayer.ClearGraphics();                 this.SpreadModel.IsOpen = !this.SpreadModel.IsOpen;              }             else              {                 Geoprocessor geoprocessorTask = sender as Geoprocessor;                 geoprocessorTask.GetResultDataCompleted += (s1, ev1) =>                     {                                                                       if (ev1.Parameter is GPFeatureRecordSetLayer)                         {                             GraphicsLayer graphicsLayer = Map.Layers["Results"] as GraphicsLayer;                              GPFeatureRecordSetLayer gpLayer = ev1.Parameter as GPFeatureRecordSetLayer;                                  foreach (Graphic graphic in gpLayer.FeatureSet.Features)                             {                                                                                                     graphic.Symbol = LayoutRoot.Resources["MyGreenFillSymbol"] as ESRI.ArcGIS.Client.Symbols.Symbol;                                                                   graphicsLayer.Graphics.Add(graphic);                                                   }                          }                         if (ev1.Parameter is GPDataFile)                         {                             GPDataFile gpdata = ev1.Parameter as GPDataFile;                             Uri uri = new Uri(gpdata.Url);                             btndownload.NavigateUri = uri;                              urltodownload = uri;                                                           geoprocessorTask.GetResultDataAsync(e.JobInfo.JobId, "RelativeSpread");                                                      }                      };                  geoprocessorTask.GetResultDataAsync(e.JobInfo.JobId, "Outfile");                               }         }

Basically would like to take my C# code and convert it to Javascript /Dojo.

Re: How to manage multiple results from Asynch geoprocessing tool?

__Rich_ — Thu, 23 Aug 2012 12:47:43 GMT

Have you looked at the Samples?

There are several for geoprocessing tasks.

P.S. JavaScript not Java. 🙂

Re: How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Thu, 23 Aug 2012 14:10:08 GMT

Have you looked at the Samples?

There are several for geoprocessing tasks.

P.S. JavaScript not Java. 🙂

There is only one using asynchronous and it has one result not two. If it was synchronous I would just use result[0].value etc but it is not.

Re: How to manage multiple results from Asynch geoprocessing tool?

__Rich_ — Thu, 23 Aug 2012 14:38:09 GMT

There is only one using asynchronous and it has one result not two. If it was synchronous I would just use result[0].value etc but it is not.

That's not really an issue, you just have to get used to using callbacks to handle async responses. Functions are first-class objects in JavaScript so you define and pass them around, assign them to things (think delegate in C#) including assigning them as a callback handler for an async request.

I assume the sample you're referring to is this one?

I guess the "completeCallback" function is the equivalent of your "GeoprocessorTask_JobCompleted" method and receives a JobInfo object which is the same as your "JobInfoEventArgs".

Then you still make an async call to get the results by calling "getResultData" and you pass a callback to that method the same way that you're assigning an anonymous delegate (using lambda syntax) in C#, in the sample the callback is called "downloadFile". The callback receives an argument of type ParameterValue whereas in C# you're being passed "s1 and ev1".

I'm struggling to see where having 2 or 3 or 'n' tasks makes any difference?

Re: How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Thu, 23 Aug 2012 16:52:22 GMT

That's not really an issue, you just have to get used to using callbacks to handle async responses. Functions are first-class objects in JavaScript so you define and pass them around, assign them to things (think delegate in C#) including assigning them as a callback handler for an async request.

I assume the sample you're referring to is this one?

I guess the "completeCallback" function is the equivalent of your "GeoprocessorTask_JobCompleted" method and receives a JobInfo object which is the same as your "JobInfoEventArgs".

Then you still make an async call to get the results by calling "getResultData" and you pass a callback to that method the same way that you're assigning an anonymous delegate (using lambda syntax) in C#, in the sample the callback is called "downloadFile". The callback receives an argument of type ParameterValue whereas in C# you're being passed "s1 and ev1".

I'm struggling to see where having 2 or 3 or 'n' tasks makes any difference?

so basically I need to modify the downloadfile to then see if the result is a GPDataFile or other.
Can I enumerate the number of results retrieved so I can then use a 'for' statement to run while I still have results left to be processed?

When I call the first getResultsData specifying the first result I want to retrieve the script stops on completing that request. I then don't get to specify my second result in the getResultsData . How do I get my script to loop back to do another getResultsData?

Hopefully I am understanding you right.
Thanks for the help.

Re: How to manage multiple results from Asynch geoprocessing tool?

__Rich_ — Fri, 24 Aug 2012 07:19:08 GMT

so basically I need to modify the downloadfile to then see if the result is a GPDataFile or other.
Can I enumerate the number of results retrieved so I can then use a 'for' statement to run while I still have results left to be processed?

Yep, pretty much.

Although with your new-found understanding I think it'd be more beneficial for you to write this from scratch step-by-step so you get a really good 'feel' for what happens at each stage, but that's just my opinion 😉

Yep, you can iterate over the results, you could use intrinsic JavaScript looping constructs but you'd probably get more out of the array utilities provided by dojo - have a look here:- dojo-base-array

When I call the first getResultsData specifying the first result I want to retrieve the script stops on completing that request. I then don't get to specify my second result in the getResultsData . How do I get my script to loop back to do another getResultsData?

Not 100% sure what you mean? Let's have a look at the code.

Re: How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Sat, 11 Dec 2021 07:44:06 GMT

Yep, pretty much.

Although with your new-found understanding I think it'd be more beneficial for you to write this from scratch step-by-step so you get a really good 'feel' for what happens at each stage, but that's just my opinion 😉

Yep, you can iterate over the results, you could use intrinsic JavaScript looping constructs but you'd probably get more out of the array utilities provided by dojo - have a look here:- dojo-base-array

Not 100% sure what you mean? Let's have a look at the code.

OK here is my code

 function completeCallback(jobInfo){
            
                if (jobInfo.jobStatus !== "esriJobFailed") {
                
    gp.getResultData(jobInfo.jobId,"RelativeSpread",outputgraphic);
    gp.getResultData(jobInfo.jobId,"Outfile",downloadFile)
    
                   
                    
              
                }
            }
            
   
            
            function statusCallback(jobInfo){
                var status = jobInfo.jobStatus;
                if (status === "esriJobFailed") {
                    alert(status);
                    esri.hide(loading);
                }
                else 
                    if (status === "esriJobSucceeded") {
                        esri.hide(loading);
                    }
            }
            
            function downloadFile(outputFile){
            
                var theurl = outputFile.value.url;
                window.location = theurl;
    
            }
            
            function outputgraphic(resultGraphic){
            
                var polySymbol = new esri.symbol.SimpleFillSymbol();
                polySymbol.setOutline(new esri.symbol.SimpleLineSymbol(esri.symbol.SimpleLineSymbol.STYLE_SOLID, new dojo.Color([0, 0, 0, 0.5]), 1));
                polySymbol.setColor(new dojo.Color([255, 127, 0, 0.7]));
                var features = resultGraphic.value.features;
                for (var f = 0, fl = features.length; f < fl; f++) {
                
                    var feature = features;
                    if (f == 0) {
                        var polySymbolRed = new esri.symbol.SimpleFillSymbol();
                        polySymbolRed.setOutline(new esri.symbol.SimpleLineSymbol(esri.symbol.SimpleLineSymbol.STYLE_SOLID, new dojo.Color([0, 0, 0, 0.5]), 1));
                        polySymbolRed.setColor(new dojo.Color([56, 168, 0, 0.5]));
                        feature.setSymbol(polySymbolRed);
                    }
                    else 
                        if (f == 1) {
                            var polySymbolGreen = new esri.symbol.SimpleFillSymbol();
                            polySymbolGreen.setOutline(new esri.symbol.SimpleLineSymbol(esri.symbol.SimpleLineSymbol.STYLE_SOLID, new dojo.Color([0, 0, 0, 0.5]), 1));
                            polySymbolGreen.setColor(new dojo.Color([139, 209, 0, 0.5]));
                            feature.setSymbol(polySymbolGreen);
                        }
                        else 
                            if (f == 2) {
                                var polySymbolBlue = new esri.symbol.SimpleFillSymbol();
                                polySymbolBlue.setOutline(new esri.symbol.SimpleLineSymbol(esri.symbol.SimpleLineSymbol.STYLE_SOLID, new dojo.Color([0, 0, 0, 0.5]), 1));
                                polySymbolBlue.setColor(new dojo.Color([255, 255, 0, 0.5]));
                                feature.setSymbol(polySymbolBlue);
                            }
                            
                            else 
                                if (f == 3) {
                                    var polySymbolBlue = new esri.symbol.SimpleFillSymbol();
                                    polySymbolBlue.setOutline(new esri.symbol.SimpleLineSymbol(esri.symbol.SimpleLineSymbol.STYLE_SOLID, new dojo.Color([0, 0, 0, 0.5]), 1));
                                    polySymbolBlue.setColor(new dojo.Color([255, 128, 0, 0.5]));
                                    feature.setSymbol(polySymbolBlue);
                                }
                                else 
                                    if (f == 4) {
                                        var polySymbolBlue = new esri.symbol.SimpleFillSymbol();
                                        polySymbolBlue.setOutline(new esri.symbol.SimpleLineSymbol(esri.symbol.SimpleLineSymbol.STYLE_SOLID, new dojo.Color([0, 0, 0, 0.5]), 1));
                                        polySymbolBlue.setColor(new dojo.Color([255, 0, 0, 0.5]));
                                        feature.setSymbol(polySymbolBlue);
                                    }
                    
                    map.graphics.add(feature);
                    
                }
    
                
            }

According to fiddler both results(relativeSpread, Outfile) are retrieved. For some reason relativespread is not drawn on the map. If I delete out the call for the outfile results, relativespread is drawn fine.

Any idea why my graphic isn't getting drawn when I have a second gp.getResultData? For both instances outfile functions correctly if included in the getresultdata.

Fiddler returns both results

/ArcGIS/rest/services/APHIS/SpreadModel1/GPServer/APHIS%20Group1/jobs/jbb3326de83dd496fae901188259256d2/results/RelativeSpread?f=json&returnType=data&callback=dojo.io.script.jsonp_dojoIoScript9._jsonpCallback 
   
/ArcGIS/rest/services/APHIS/SpreadModel1/GPServer/APHIS%20Group1/jobs/jbb3326de83dd496fae901188259256d2/results/Outfile?f=json&returnType=data&callback=dojo.io.script.jsonp_dojoIoScript10._jsonpCallback

Re: How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Sat, 11 Dec 2021 07:44:08 GMT

nevermind fixed it with a deferred waiting for the first to finish

  if (jobInfo.jobStatus !== "esriJobFailed") {
                
                    var def = new dojo.Deferred();
                     setTimeout(function(){ def.resolve({called: true});}, 1000);
                    
                    gp.getResultData(jobInfo.jobId, "RelativeSpread", outputgraphic)
                    
                    def.then(function(){
                        gp.getResultData(jobInfo.jobId, "Outfile", downloadFile)
                    })

Re: How to manage multiple results from Asynch geoprocessing tool?

__Rich_ — Sat, 11 Dec 2021 07:44:11 GMT

That's kind of losing the benefit of doing async processing i.e. you're now blocking on something before starting something else, if they are independent then there's no need.

FWIW, the first problem I can see is this:

gp.getResultData(jobInfo.jobId,"RelativeSpread",outputgraphic);
gp.getResultData(jobInfo.jobId,"Outfile",downloadFile)

The completeCallback function will be called twice on separate occasions i.e. once for each task, your code (above) tries to access the results of each task both times! (comment out those two lines and put a breakpoint in then check out what's in the jobInfo argument on each call, this should clarify it for you)

You need to do something like check which task has returned then call the appropriate getResultData for that task, although overall I think you could re-write then whole lot to be more generic/reusable etc.

I really would start this again from scratch and check your understanding of async processing at each stage, once the penny drops you'll find this stuff easy 🙂

Re: How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Sat, 11 Dec 2021 07:44:14 GMT

That's kind of losing the benefit of doing async processing i.e. you're now blocking on something before starting something else, if they are independent then there's no need.

FWIW, the first problem I can see is this:
gp.getResultData(jobInfo.jobId,"RelativeSpread",outputgraphic);
gp.getResultData(jobInfo.jobId,"Outfile",downloadFile)
The completeCallback function will be called twice on separate occasions i.e. once for each task, your code (above) tries to access the results of each task both times! (comment out those two lines and put a breakpoint in then check out what's in the jobInfo argument on each call, this should clarify it for you)

You need to do something like check which task has returned then call the appropriate getResultData for that task, although overall I think you could re-write then whole lot to be more generic/reusable etc.

I really would start this again from scratch and check your understanding of async processing at each stage, once the penny drops you'll find this stuff easy 🙂

I don't think I understand. I only have one task giving me two results. How do I access the results without firing the getResultData twice, once for each result?

Thanks for your help I really do appreciate it.

Re: How to manage multiple results from Asynch geoprocessing tool?

__Rich_ — Tue, 28 Aug 2012 14:12:43 GMT

I don't think I understand. I only have one task giving me two results. How do I access the results without firing the getResultData twice, once for each result?

Thanks for your help I really do appreciate it.

Ah, that might be me - only skim-reading the code, let me check again. (not doing too well with this stuff today!)

Re: How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Sat, 11 Dec 2021 07:44:17 GMT

Ah, that might be me - only skim-reading the code, let me check again. (not doing too well with this stuff today!)

Here is my geoprocessing code

 function SpreadModel1(){
            
                if (map.graphics.graphics.length === 0) {
                    alert('Please place your starting point');
                    return;
                }
                //get starting point
                var features = [];
                features.push(map.graphics.graphics[0]);
                var featureSet = new esri.tasks.FeatureSet();
                featureSet.features = features;
                //get Break Values
                var box0 = dijit.byId("dbv1");
                gp = new esri.tasks.Geoprocessor("http://blah/ArcGIS/rest/services/APHIS/SpreadModel1/GPServer/APHIS%20Group1");
                
                
                
                var params = {
                    "Input_Layer": dijit.byId('spreadmodel1layers').value,
                    "Start_locations": featureSet,
                    "Default_break_values": box0.attr("value")
                }
                
                esri.show(loading);
                gp.submitJob(params, completeCallback, statusCallback, function(error){
                    alert(error);
                    esri.hide(loading);
                });
            }

Re: How to manage multiple results from Asynch geoprocessing tool?

__Rich_ — Tue, 28 Aug 2012 14:46:01 GMT

Nothing obvious leaps out, the only thing I've spotted so far is a missing semi colon!

gp.getResultData(jobInfo.jobId,"Outfile",downloadFile)

Perhaps someone with sharper eyes can spot an issue, I've tried re-jigging the sample to run multiple concurrent getDataResult() requests and can't recreate an issue so far.

Do both callbacks actually get invoked?

Re: How to manage multiple results from Asynch geoprocessing tool?

BrianMulcahy — Tue, 28 Aug 2012 14:59:37 GMT

Nothing obvious leaps out, the only thing I've spotted so far is a missing semi colon!
gp.getResultData(jobInfo.jobId,"Outfile",downloadFile)
Perhaps someone with sharper eyes can spot an issue, I've tried re-jigging the sample to run multiple concurrent getDataResult() requests and can't recreate an issue so far.

Do both callbacks actually get invoked?

well it was working with the deferred statement.

So now that I commented out the deferred statement and went back to just the simple getResultData, it works now.......
I am in awe about why it didn't work before, as both callbacks were getting invoked and I could see everything running without error.

I think I am just going to call it a week.

Thanks for the help.

Re: How to manage multiple results from Asynch geoprocessing tool?

__Rich_ — Tue, 28 Aug 2012 15:17:47 GMT

Ok, so everything's working as it should with no extra workarounds e.g. waiting?

If so, cool!

Time for a beer!

Hope I helped a bit 🙂